From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 26A2AA496 for ; Tue, 27 Mar 2018 22:48:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Mar 2018 13:48:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,368,1517904000"; d="scan'208";a="215411246" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by fmsmga005.fm.intel.com with ESMTP; 27 Mar 2018 13:48:02 -0700 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.61]) by IRSMSX107.ger.corp.intel.com ([169.254.10.157]) with mapi id 14.03.0319.002; Tue, 27 Mar 2018 21:48:02 +0100 From: "Richardson, Bruce" To: =?iso-8859-1?Q?Ga=EBtan_Rivet?= CC: Neil Horman , "dev@dpdk.org" , "Wiles, Keith" Thread-Topic: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization Thread-Index: AQHTxcIzQ+nG9z/CckCRxnIkJDfZnKPj9SgAgABg04CAAB/jAIAAEtiA///xOICAABQJMA== Date: Tue, 27 Mar 2018 20:48:01 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B07226BF75@IRSMSX103.ger.corp.intel.com> References: <20180327114750.GA30585@hmswarspite.think-freely.org> <20180327124000.6n63hpng53tm3bil@bidouze.vm.6wind.com> <20180327182633.GC30585@hmswarspite.think-freely.org> <20180327202040.rd3yixr67c3jbx4p@bidouze.vm.6wind.com> <20180327202807.GB16780@bricha3-MOBL.ger.corp.intel.com> <20180327203513.ubgyukhsqjqg7s7y@bidouze.vm.6wind.com> In-Reply-To: <20180327203513.ubgyukhsqjqg7s7y@bidouze.vm.6wind.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGZjNWIyZWYtYjU3Ny00ODgzLTg5Y2EtMmFkOTdiYWIxMGQ1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJmenZJa25HdkkxZldoZ0ZLUm55Q3A5dXJLa0NscTYrcUk5UGdtekVEdEtkSjF0WmhtakswNERGZGsxOU0zQXFFIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device iteration initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 20:48:05 -0000 > -----Original Message----- > From: Ga=EBtan Rivet [mailto:gaetan.rivet@6wind.com] > Sent: Tuesday, March 27, 2018 9:35 PM > To: Richardson, Bruce > Cc: Neil Horman ; dev@dpdk.org; Wiles, Keith > > Subject: Re: [dpdk-dev] [PATCH v3 10/20] eal/dev: implement device > iteration initialization >=20 > On Tue, Mar 27, 2018 at 09:28:07PM +0100, Bruce Richardson wrote: > > On Tue, Mar 27, 2018 at 10:20:40PM +0200, Ga=EBtan Rivet wrote: > > > On Tue, Mar 27, 2018 at 02:26:33PM -0400, Neil Horman wrote: > > > > On Tue, Mar 27, 2018 at 02:40:00PM +0200, Ga=EBtan Rivet wrote: > > > > > On Tue, Mar 27, 2018 at 07:47:50AM -0400, Neil Horman wrote: > > > > > > On Tue, Mar 27, 2018 at 01:18:34AM +0200, Gaetan Rivet wrote: > > > > > > > Parse a device description. > > > > > > > Split this description in their relevant part for each layers= . > > > > > > > No dynamic allocation is performed. > > > > > > > > > > > > > > Cc: Neil Horman > > > > > > > Cc: "Wiles, Keith" > > > > > > > Signed-off-by: Gaetan Rivet > > > > > > > --- > > > > > > > > > > > > > > This version uses librte_kvargs. > > > > > > > > > > > > > > > > > > > Otherwise, this looks pretty good to me > > > > > > > > > > Please look into the librte_kvargs compatibility patch as well > > > > > (quite short). I'm very unhappy about the logging hack. > > > > > There is always the solution of setting a function pointer on > > > > > rte_log with the proper loglevels and so on. > > > > > Ideally rte_log could be made independent (starting skimming EAL > > > > > from all the fat), but this is much less trivial. > > > > > > > > > just posted about that. I agree with Keith, I don't think you > > > > should need that patch. RTE_LOG just calls rte_vlog which contains > this code: > > > > > > > > if (f =3D=3D NULL) { > > > > f =3D default_log_stream; > > > > if (f =3D=3D NULL) { > > > > /* > > > > * Grab the current value of stderr here, > rather than > > > > * just initializing default_log_stream to > stderr. This > > > > * ensures that we will always use the > current value > > > > * of stderr, even if the application close= s > and > > > > * reopens it. > > > > */ > > > > f =3D stderr; > > > > } > > > > } > > > > } > > > > > > > > Which I read as saying that the logging library should back off to > > > > stderr if its not initialized yet. If you've encountered a > > > > problem that made you need that logging patch, it seems like you > > > > should be able to drop it, and we need to fix the logging library. > Can you elaborate on what you ran into here? > > > > > > > > Neil > > > > > > Neat. The issue is that rte_log.h is not symlink-ed until librte_eal > > > is processed. rte_log cannot be included. > > > > > Sure it can - just pass -I/path/to/eal as a cflag. > > > > /Bruce >=20 > When you put it this way... :) >=20 > Sure, this is a solution, of which early symlink was a genericization. > I'm just not a fan of having co-dependent libraries. >=20 > But this will probably come to that. >=20 The other alternative is what was done with rte_compat.h - create a new lib just with a single header file in it. Works ok too, and may seem less hacky to some folks. /Bruce