From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <bruce.richardson@intel.com> Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 33A112C18 for <dev@dpdk.org>; Thu, 7 Mar 2019 12:53:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Mar 2019 03:53:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,451,1544515200"; d="scan'208";a="138817911" Received: from irsmsx104.ger.corp.intel.com ([163.33.3.159]) by FMSMGA003.fm.intel.com with ESMTP; 07 Mar 2019 03:53:15 -0800 Received: from irsmsx103.ger.corp.intel.com ([169.254.3.152]) by IRSMSX104.ger.corp.intel.com ([169.254.5.56]) with mapi id 14.03.0415.000; Thu, 7 Mar 2019 11:53:14 +0000 From: "Richardson, Bruce" <bruce.richardson@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "Rawat, Anand" <anand.rawat@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Kadam, Pallavi" <pallavi.kadam@intel.com>, "Menon, Ranjit" <ranjit.menon@intel.com>, "Shaw, Jeffrey B" <jeffrey.b.shaw@intel.com> Thread-Topic: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows Thread-Index: AQHU1NAAV2rywi3vK0qhlI7hfPDs1qYACYeAgAAFdhA= Date: Thu, 7 Mar 2019 11:53:14 +0000 Message-ID: <59AF69C657FD0841A61C55336867B5B072759DEF@IRSMSX103.ger.corp.intel.com> References: <20190306041634.12976-1-anand.rawat@intel.com> <2354479.T0gxW44koM@xps> <20190307102451.GB374484@bricha3-MOBL.ger.corp.intel.com> <18942651.9Y0FxRHys3@xps> In-Reply-To: <18942651.9Y0FxRHys3@xps> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGMwYjNmYzYtYzJiOC00NDdiLWFhYWQtMjc4NjQ0Y2QzOWQ5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibGtHOGE5MWhNanA3UjVRWnR3bXQzUEFYY3ZXbE4xNEttRFlGQXpMZ21qb0sxYzB2U2ZoOTZPSTlMaUhUTzRXKyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 07 Mar 2019 11:53:17 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, March 7, 2019 11:33 AM > To: Richardson, Bruce <bruce.richardson@intel.com> > Cc: Rawat, Anand <anand.rawat@intel.com>; dev@dpdk.org; Kadam, Pallavi > <pallavi.kadam@intel.com>; Menon, Ranjit <ranjit.menon@intel.com>; Shaw, > Jeffrey B <jeffrey.b.shaw@intel.com> > Subject: Re: [dpdk-dev] [PATCH v2 2/6] eal: add header files to support > windows >=20 > 07/03/2019 11:24, Bruce Richardson: > > On Thu, Mar 07, 2019 at 09:45:57AM +0100, Thomas Monjalon wrote: > > > 07/03/2019 04:27, Anand Rawat: > > > > On 3/6/2019 3:31 AM, Thomas Monjalon wrote: > > > > > 06/03/2019 05:16, Anand Rawat: > > > > >> Added header files to support windows on x86 platforms. > > > > >> Updated rte_config to include rte_windows.h for windows build. > > > > > [...] > > > > >> --- a/config/rte_config.h > > > > >> +++ b/config/rte_config.h > > > > >> +/* windows specific*/ > > > > >> +#ifdef RTE_EXEC_ENV_WINDOWS > > > > >> +#include <rte_windows.h> > > > > >> +#endif > > > > > > > > > > Include in the config file looks wrong. > > > > > >> --- /dev/null > > > > >> +++ b/lib/librte_eal/windows/eal/include/exec-env/rte_windows.h > > > > > > > > > > I think we could remove the sub-directory exec-env. > > > > > Could we include this file from rte_common.h? > > > > rte_windows.h defines types and substitution macros which are > > > > needed to support common code on windows. So it should be included > > > > as a global include for every library on windows. > > > > rte_common.h is not included in all the source code and headers we > > > > currently build for windows. > > > > > > I think it is not an issue adding some rte_common.h include here and > > > there. > > > > > > > I'd be hesitant about putting it in rte_common.h without knowing the > > scope of the changes - "here and there" could end up being "everywhere"= . >=20 > It's already almost everywhere, and I think it's normal, it is the meanin= g > of "common". >=20 > % git grep rte_common.h | wc -l > 459 >=20 > % git grep rte_common.h lib | fgrep .h: | wc -l > 79 >=20 > If some .c files doesn't have rte_common.h included directly or indirectl= y > from other includes, it may be fixed. >=20 > > Another alternative is to see if most/all the definitions could > > actually be put in dpdk_conf and thereby go into the standard config.h > > file generated at build time. Anything that couldn't be done via > > macros or defines in the config could then look to be put maybe in > > rte_common.h or other locations, perhaps. >=20 > I think we should keep the semantic of what a config file is. > I don't see the need of adding more than strict config in it. >=20 Ok.