From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6CAA3A0C44;
	Mon, 14 Jun 2021 17:00:38 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 5909740DDB;
	Mon, 14 Jun 2021 17:00:38 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id CB8F04067E
 for <dev@dpdk.org>; Mon, 14 Jun 2021 17:00:36 +0200 (CEST)
Received: from [192.168.1.71] (unknown [188.170.85.171])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 6270F7F53D;
 Mon, 14 Jun 2021 18:00:34 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 6270F7F53D
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1623682836;
 bh=QPXOeV8dTRZYXeEUz7/sHkb0lLWx29mGgVwr+JG4nDM=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=afKTV5SgkMas/ZXlj8nrlHTBfKAzaZ3Cu6+EsPF3JjNjFJ5lCNdwQUzFAbudUXLYH
 qkBUAWKw5zdqbdXdkilaDbAffHocTF5t92HHw668BLuV7wI/x86QUgIuflRxLBz3/G
 mfv/C8SuVhdfbpA24jzwyFjaQ/W2diYd9jRq2iUQ=
To: "Min Hu (Connor)" <humin29@huawei.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
References: <1623553508-5478-1-git-send-email-humin29@huawei.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <59bcc1bc-a413-e1b9-698e-de23d8b27375@oktetlabs.ru>
Date: Mon, 14 Jun 2021 18:00:28 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.10.0
MIME-Version: 1.0
In-Reply-To: <1623553508-5478-1-git-send-email-humin29@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 0/4] features for hns3 PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/13/21 6:05 AM, Min Hu (Connor) wrote:
> This patch set contains 4 features for hns3 PMD:
> add query basic info support for VF
> support for VF modify VLAN filter state
> support multiple TC MAC pause
> supports disabling PFC by dev configure API
> 
> Chengchang Tang (2):
>    net/hns3: add query basic info support for VF
>    net/hns3: support for VF modify VLAN filter state
> 
> Huisong Li (2):
>    net/hns3: support multiple TC MAC pause
>    net/hns3: supports disabling PFC by dev configure API
> 
>   drivers/net/hns3/hns3_cmd.h       |  9 ++++
>   drivers/net/hns3/hns3_dcb.c       | 61 +++++++++++++------------
>   drivers/net/hns3/hns3_ethdev.c    |  5 +-
>   drivers/net/hns3/hns3_ethdev.h    |  7 +++
>   drivers/net/hns3/hns3_ethdev_vf.c | 96 ++++++++++++++++++++++++++++++---------
>   drivers/net/hns3/hns3_mbx.h       | 11 ++++-
>   6 files changed, 138 insertions(+), 51 deletions(-)
> 

Overall LGTM, but build breakage must be fixed.