From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 62953A054F;
	Wed, 25 May 2022 11:55:21 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 536B040146;
	Wed, 25 May 2022 11:55:21 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 4B71D400EF
 for <dev@dpdk.org>; Wed, 25 May 2022 11:55:19 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id CE3288B;
 Wed, 25 May 2022 12:55:18 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru CE3288B
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1653472518;
 bh=3i6iy21Lp+suEefzDKVtdJXMVhfA4QRDwpr+JNE0DjE=;
 h=Date:Subject:To:Cc:References:From:In-Reply-To:From;
 b=iyQz0wrWc2E38uKaccLdtJXm5UvlV8GpqXUAzkuRhZbq5buWOoUBcStb/oYIzna8p
 dSAaYNRq3vpUlnc5aFv7y+ho6Kt6/yjsn2fZZdPOQktqtzOxVQlpJp8DckyXkvOghe
 uM9pEyUU6sAeA7ZQ5HiocPotQcN2WzexiFrabHEQ=
Message-ID: <59cbc63c-f9a8-e666-9e87-d7825a3a4afa@oktetlabs.ru>
Date: Wed, 25 May 2022 12:55:18 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v8 3/5] ethdev: format module EEPROM for SFF-8079
Content-Language: en-US
To: Robin Zhang <robinx.zhang@intel.com>, dev@dpdk.org
Cc: thomas@monjalon.net, kevinx.liu@intel.com
References: <20220524062442.194809-1-robinx.zhang@intel.com>
 <20220525031446.72578-1-robinx.zhang@intel.com>
 <20220525031446.72578-4-robinx.zhang@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
In-Reply-To: <20220525031446.72578-4-robinx.zhang@intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Consider: "support SFF-8079 module information telemetry"
(if it fits in required number of symbols)

On 5/25/22 06:14, Robin Zhang wrote:
> This patch implements format module EEPROM information for
> SFF-8079 Rev 1.7

Add support for module EEPROM information format defined in
SFF-8079 Rev 1.7.

> diff --git a/lib/ethdev/sff_8079.c b/lib/ethdev/sff_8079.c
> new file mode 100644
> index 0000000000..cfa20bd3cb
> --- /dev/null
> +++ b/lib/ethdev/sff_8079.c
> @@ -0,0 +1,406 @@
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright(c) 2022 Intel Corporation
> + *
> + * Implements SFF-8079 optics diagnostics.
> + *

Please, remove extra empty line.

> + */
> +
> +#include <stdio.h>
> +#include <rte_mbuf.h>
> +#include <rte_ethdev.h>
> +#include <rte_flow.h>
> +#include "sff_common.h"
> +#include "ethdev_sff_telemetry.h"

Please, separate system, other DPDK and local headers.
Use double quotes for local headers.
Remove unnecessary includes.

> +	if (data[3] & (1 << 7))

Use RTE_BIT32 here and in similar cases below

> +	if (data[65] & (1 << 1))

Use RTE_BIT32 here as well.

> +		ssf_add_dict_string(d, name, "RX_LOS implemented");