From: Remy Horton <remy.horton@intel.com>
To: Zyta Szpak <zr@semihalf.com>,
thomas.monjalon@6wind.com, wenzhuo.lu@intel.com,
helin.zhang@intel.com, konstantin.ananyev@intel.com,
jingjing.wu@intel.com, jerin.jacob@caviumnetworks.com,
rahul.lakkireddy@chelsio.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v5 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params
Date: Mon, 4 Jul 2016 11:39:51 +0100 [thread overview]
Message-ID: <59d3c9d1-2c56-53b4-ff38-ab42ace12552@intel.com> (raw)
In-Reply-To: <1467615087-20510-2-git-send-email-zr@semihalf.com>
On 04/07/2016 07:51, Zyta Szpak wrote:
> From: Zyta Szpak <zr@semihalf.com>
>
> Version 4 of fixing the fixed register width assumption.
> The app was allocating too little space for 64-bit registers
> which resulted in memory corruption. This commit resolves
> this by getting the number of registers and size of register
> by rte_eth_dev_get_reg_info function called first time
> with data=NULL.
Comments regarding commit message on v4 1/2 also apply here..
It is also not v4.. :)
> Signed-off-by: Zyta Szpak <zr@semihalf.com>
> ---
> examples/ethtool/lib/rte_ethtool.c | 19 +++++++++++++------
> 1 file changed, 13 insertions(+), 6 deletions(-)
next prev parent reply other threads:[~2016-07-04 10:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 13:26 [dpdk-dev] [PATCH v4 1/2] ethdev: remove get_reg_length callback zr
2016-06-23 13:26 ` [dpdk-dev] [PATCH v4 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params zr
2016-06-27 10:46 ` Remy Horton
2016-06-27 10:46 ` [dpdk-dev] [PATCH v4 1/2] ethdev: remove get_reg_length callback Remy Horton
2016-06-28 16:05 ` Zyta Szpak
2016-06-27 15:19 ` Thomas Monjalon
2016-06-28 16:05 ` Zyta Szpak
2016-07-04 6:51 ` [dpdk-dev] [PATCH v5 " Zyta Szpak
2016-07-04 6:51 ` [dpdk-dev] [PATCH v5 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params Zyta Szpak
2016-07-04 10:39 ` Remy Horton [this message]
2016-07-04 10:38 ` [dpdk-dev] [PATCH v5 1/2] ethdev: remove get_reg_length callback Remy Horton
2016-07-04 11:34 ` Zyta Szpak
2016-07-04 11:36 ` [dpdk-dev] [PATCH v6 " Zyta Szpak
2016-07-04 11:36 ` [dpdk-dev] [PATCH v6 2/2] examples/ethtool: use rte_eth_dev_get_reg_info for reg params Zyta Szpak
2016-07-04 13:24 ` Remy Horton
2016-07-08 17:02 ` Thomas Monjalon
2016-07-04 13:24 ` [dpdk-dev] [PATCH v6 1/2] ethdev: remove get_reg_length callback Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=59d3c9d1-2c56-53b4-ff38-ab42ace12552@intel.com \
--to=remy.horton@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=jingjing.wu@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=thomas.monjalon@6wind.com \
--cc=wenzhuo.lu@intel.com \
--cc=zr@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).