From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C88341B13; Wed, 12 Jun 2024 03:00:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 181594028B; Wed, 12 Jun 2024 03:00:40 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2061.outbound.protection.outlook.com [40.107.236.61]) by mails.dpdk.org (Postfix) with ESMTP id A540B4021E for ; Wed, 12 Jun 2024 03:00:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NyTe7veCtVEUgy6DtAzd70W0PiY2FevS9a6opmP5OxZNlewjg99R5upikwDMvuengmX3wChQqOwOFz9EMHDrN+r0VUAvEbUf3SfUCkIiF3OOYnN+JMZENHVQ/EM4XEoT6Dnk+CRFrGfjtT6fEc0mMlyJFw92gPAw9ggnOH/LVievrLG8WmQ24NWaU8tUKR0S9JRjANSNMU5FtGdroMAxXcXE0H2ThjU3EL2cRSeMZ5t9scZzpPRtEUM3lihZhidj9OoKFh22ggdfVOrio1OYhI6dBuNUkqL7pa2MfwSHP5Vmlg7P+DT2rYxGNfqCsOndvYDSvpkqHJyMZZh9CAjVVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/+kYwin3Hfl/TjEPtw4VV/P/Ncl5u9oPiETcwohae8Y=; b=FeVP2+aU9jbXhXMkFLdr6MinLzcesn9qc57+8n83iRchfg+uQoLXhs6rTmsFkIU1gMqdxSxPya654MfrqvbbrJLnlshjXsw+PDK8NxisZImHYs2a+/YTe4Uhfcpft+CGft1yE4EvR0CjGi09taTv8Y59G0ryG8znzMyALf29ZRGvEOfthambbkOqvvZ10eROx55OzltlbV0/7RW3KSGIxySaVhO5NZ7QduXTqCTI1g0jS0zqB8EDv6LJcOsq9L95kEJIHJJn22XYlb0Mduulcgo1roSqPjAEQy1t8cnL6yHVdUTksLwph+9VF5MgLCZJma7PcjHxsX0aZmO28bujFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/+kYwin3Hfl/TjEPtw4VV/P/Ncl5u9oPiETcwohae8Y=; b=NwWTxaG+kAcDb3bcMjtRllTkQRfOCHivDSBIk9YAcmA1+53vr63gsaco/R6huDSGlSVqQTwdVLqpzeoNVzimq6rVTKoZkhp/EyrJDj5/Sv2se+6F+pSAavupA+3MPgxv13oWBLd61F0bqhyklhhjHIPv+tCZbIK+BtxZqQQnSLk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6459.namprd12.prod.outlook.com (2603:10b6:208:3a9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.37; Wed, 12 Jun 2024 01:00:35 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7633.036; Wed, 12 Jun 2024 01:00:35 +0000 Message-ID: <59dd1185-6eec-4a08-9d8f-aa184ba87cbf@amd.com> Date: Wed, 12 Jun 2024 02:00:24 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 3/4] net/ixgbe: remove use of VLAs To: Konstantin Ananyev , dev@dpdk.org Cc: hujiayu.hu@foxmail.com, roretzla@linux.microsoft.com, bruce.richardson@intel.com, anatoly.burakov@intel.com, vladimir.medvedkin@intel.com, Konstantin Ananyev References: <20240523162604.2600-1-konstantin.v.ananyev@yandex.ru> <20240523162604.2600-4-konstantin.v.ananyev@yandex.ru> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240523162604.2600-4-konstantin.v.ananyev@yandex.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB3PR08CA0002.eurprd08.prod.outlook.com (2603:10a6:8::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6459:EE_ X-MS-Office365-Filtering-Correlation-Id: 56bbc5d6-6413-4bbe-d733-08dc8a7b111e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230032|376006|366008|1800799016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VEFHRGY2VGNqK0xyRU43TU5POW9WbE1oRlVqYjJ5RU9SNVdpWFdhWGRjUTBY?= =?utf-8?B?cFFydXAxRFBMUjZHQ2wxNityZE12TGZxYmtRckJtb0hVVGQvNUxzZUxBVmNx?= =?utf-8?B?dWFDaVBnUHlVK3pYN3JhbTlzRm4zcTBxSDNIMktLQks1QlQ2Sy9uU2RBKzU3?= =?utf-8?B?ZGErenZDZ2d0MnQ5WCtWQ0RKdEozZnpWQ05zNDdBdHVlMU8zYXAzaEZYNzZv?= =?utf-8?B?ME9tWjV5eUN6RVBKYUZUa3FzcEd5K1V5a0pqVnZFU2thNXdMUFJJSkM3WGRi?= =?utf-8?B?M0xVcW1kcTJPWmpPZkpFQzcvMEEzVTJRY3l1SlVMQVBkVFMrNHNYY3NFb3hN?= =?utf-8?B?NVZoSCtUQkFwanJiZ0k2VkVtbGptOGU3d0RoVGpGS3R3TFhTODFLUndCUW1H?= =?utf-8?B?ZVBMR0trSXB6OEJVMFI0akFKc1hwOUNhMHlwaUZCb1UxNXFEQTh4NXN4ZHcr?= =?utf-8?B?K1RGeTNocnFhY2FrdGR0Z1VQSFhDcXZJT0J0bVNHVldwbHhYNTRyRldIN3B0?= =?utf-8?B?U0JreEpVakVmN3ViZ2lJUU04ZEhic1FLeFlPKytmYlJXWm44UWFqQ0dQMTVp?= =?utf-8?B?NXZRNCtnZlVoOWZGZGRVUitSblZreVZ4NEh0T0dUc012VXYzbmMwZWRVeEpR?= =?utf-8?B?R1lFV0g0WFNHdXVnb2pyMWNWRHlST1NrU3JWM25MS1JFVklwS2lJZHRqWlRV?= =?utf-8?B?Nll0cjBINDRLWDVMTWJleTFhUHpEbWdFTHc3alBScjdTSXlxQkM5VmhHaWl5?= =?utf-8?B?aGloaFVVenZlNnRtVitLMDluUjZGSGhOc3NCckpwUkJObmJrenprVGJhVHl2?= =?utf-8?B?dGtiSmE3REd0bUFleTJDZFl0TUY0WWhZUWtGRzdZU1dod2FzYXpNV3FjbzM3?= =?utf-8?B?QzJyWGgxNE1pN2xkdXZ5dEp5cllsQ0VMNkc5K0o4SlpDL3daUllHaUlOcVMz?= =?utf-8?B?NmJDOW9Oa0tsMVR0eXBqYmFOL1ZQMnFDZzcwWGFHU0RTRmIrUFBiOElFQ0du?= =?utf-8?B?NmNhM1JwQmt5cHFyemJQMDFNT2M4Z3pNTTk1blJiMnJBRWhBWDV1QUlUUm12?= =?utf-8?B?N3dRM0R1UW1VQ1NqbDJwbWY0Rkc1Nyt5emc5aHpXTDdjdkNveFhvOWlXMFpo?= =?utf-8?B?eExlZWx2WFFGUHd0TWl3QVF0dmpRa1F3dE5saWhVZEdrL2NxWk1wT3ZaV2Z6?= =?utf-8?B?Qm5KNmVvU05hVUE1ZnFCeTNoZGtOWVNRcVRSeGxjMWlOd215ZHRMUmJCWVVM?= =?utf-8?B?c2ZhRU9QaXpkYTlUTE5mSlVGYUx6NytwVEFEbStFVjAxejh0ODNGSmxrdTlS?= =?utf-8?B?b2laK0hJcERyVm50TElVdHgvZGZORUdGdmsyVWZiSit2dWcxdHJnMEZsbW95?= =?utf-8?B?aytibHJJaGovSlVMd09PaWZ5c1BCeUlnOUpPNW9QOGZyUWVsbVU1K01xeEJh?= =?utf-8?B?cTgyeWZYWFZHSnBOYUlHWngyakt0cHBPUVlLNHd5SW5XS2R6NGtvcytycmV4?= =?utf-8?B?T3ZpRk1uMHdBZmJUYWJFZk1TMXd5bDdYbi9mb3k3VXF0SWpFNkxwdVU5eUEy?= =?utf-8?B?YXo0aWxFV1p0RTBVWUJwSnl6V3JKVlZnbXZxUWdPWDNxc1NtUmpzVUtidVlj?= =?utf-8?B?dWkwVlg2RUFhc243STZLZmxPRnlvNnFFeU14Q1RTVmhweHZmd1N6eFJSclpr?= =?utf-8?B?RUVZU1Ird1RQNjlTTnY0TWM4YVRjdzZRblRiaW1UVWtSaDA0YUhxUmxWdVJW?= =?utf-8?Q?Nx9Yw1wIgeOj8xGaMOLfrCcJdE9kdwIG7lui8BU?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230032)(376006)(366008)(1800799016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MWt3b2wzRyt1K1N5UkNKMDFhbXJDVy84SGNxbElCVDcvSW53WjhYejRCS0ls?= =?utf-8?B?cFNFTGZFMDlBVUFlTlprbWdCbmMxampDQjhrQzBXZ3hGeXJvMkYxQ3ZlUCtl?= =?utf-8?B?M2lXci82NUI3YXhDWm1lQUhMazNFeGlWVHZFWHBVRnQ0anhZRWJjSTZ4bHp6?= =?utf-8?B?c3Rma255enEvQ3JhYmM3NEdranBjWWQ3NExkN0FFS2NQeXd3eFJUY2VzRVh3?= =?utf-8?B?dzdBSEJFc09ST3o3am0zUlRPSVY0TFNSWWFhQlVTV1FkVnRrZnlHck5ZNTJL?= =?utf-8?B?M3pxMmo4LzNWZzFoR1p2NHB3ZVlLWHQwOHBLMEdwME9KTzBlN3A3Zk0zZ0pG?= =?utf-8?B?Z1VVL2M0UkQ5N0gvSGRZT2ZsdytFbzBCN3pzODNETnRZK09wUGtrZURScEtk?= =?utf-8?B?cHNPWG80WVFzaFdZYTNVOEFRTFBsZkJYbjgxeFBIMGJ2dUhUZko3ZDV2Y200?= =?utf-8?B?VkhwdlA0Y2ZZMlpjYWxkQSthekt4YkkwQ3lyaGxIRzZOU1BJcU5vaW5kd20w?= =?utf-8?B?aHFnaDhnOWRCTGNuSFdNaFliTVd4WkNyQjJTZXUxeEF2ajBWTHVjQWsyYXV3?= =?utf-8?B?WXE2SWdOblNrNDdtSVBSNlVpRHJ6ZDVNVzFwMTZFTlhlL2U2RktZZTRRMXh0?= =?utf-8?B?cFViTVBTRHd6SWhmeWtLa2NZbnZYUmJBK21WSGY0SmI1T3FkV2V0Qyt5L1lT?= =?utf-8?B?WG1tV2t2VSt1V2JFNEllM0lPYUx4aGZLb1hSUmx2bXArRDgxa0c5ZEdkZzk5?= =?utf-8?B?bFE2VzM5MzUrMjNkZkNqcTBmNVBIa0lZazZwRi93REdIWFBJREV6d3o5TnNo?= =?utf-8?B?QmVybGRLeThDQ1NiQ1htbS9Ud0htK2xMQUZIWnV3cStHK3ZKc3pYNGhEcnlR?= =?utf-8?B?VVRDY2dSdEM5Y2pVUk5Ub0w2djdOL1JBSGJ0aFAvZ0pjRW9IMXloNS9MS1BK?= =?utf-8?B?SWF2ZUFIUXdqK3lTcGk5bDV3R253L0dRVXIxTFRMb0tLRFo1a0VNdDREZVNl?= =?utf-8?B?VWhBWitnZmJES0RaYm51NTFPMXplMklvb3kzb0puQ2ZFdkdFbmZRTDUyL0Vi?= =?utf-8?B?YmNlNUlPRkRORXNhdndKWHNsZ01XNW43a1ZGRjJCWXRmY0UyU0xyOVJZUlI1?= =?utf-8?B?ZlBXQ2pKQ1R0aXZTMlZhTkNVV2U5ZUZjR1BNSExyNmlaNkhyemowQ1VaMnFs?= =?utf-8?B?bjBWMzVtbnVVemlaRm9YOHBLS09IUkErbFdodS9kMzdDREpUR0R3dkJzK1JZ?= =?utf-8?B?VkYydHB3NmwwRm9lRnk1cjJCSkVyTnMzSFl6SmRtcXJ1eHNTcE9lVGNJSmQy?= =?utf-8?B?MEU3NzFWUzFxWXdHQWUrQUJUMkdTcDhjdXNtMWk3UXVtTDFNWXhVcTA1OXVj?= =?utf-8?B?QjBoeVF6WUttZWZLdlRaT2R6Sm9qUkdaNkgzN0xXa2k3UGlDalNRVjBGYzZn?= =?utf-8?B?c2NyRG85UDdMb3h5NzRPSmc1Y09pWWNENTBVUTEycEdPS1l5MytrdEYvaFFP?= =?utf-8?B?QW04b0tTSit3Y2UvSDhBYmRTQlJnbUNmd3g2bjBUVGZXRlEvSkNIKzhXVjR0?= =?utf-8?B?L1AzVDQ5UzV2a1VXQmphdnFmeENpUjRzRHdiT0tmWHk3dkk0L21jalFwdDlB?= =?utf-8?B?c0xKQ3gwUlQ3ak1MRVBEcCtKTUJqUlNwSHlJZFI0S1JTVCszZ2ZldGxZTk5I?= =?utf-8?B?aU43WXhYS2xnaXdYTTVXZ1Q1YXJ2eUdab1V4L1paN09SNWVUQnVRVjl6cUJs?= =?utf-8?B?dFNIczRSMFBKTEgxa1hmMjRjQzdvd3lna0lreU16SC9HR1I2TFJpNEVkdXkr?= =?utf-8?B?d2JudElScXVkQksvV083WUxBSXZBbUVhaEFYSHJQVXQydUl6SGIxVmUzM0dG?= =?utf-8?B?S2pTY1lSc213ekJIalR5ekxZYm5oOTVFYVNNbHd5ZHA0YWlYQ2NULzdteGcw?= =?utf-8?B?SnBFY3JBcS9ZRjMyUmRtRHlza2ZRc0FIM08xeGRyNUM4QTN6OHNQWmljR0Ev?= =?utf-8?B?U3hBYUVZRXl5M0FSS09Na05pdTl4Nkpsc1lOT2RaOUxERjN2TGJYbUJGaTJK?= =?utf-8?B?c3huZ3F3S3Z6NlNMdjNmTXFVdWFzNkRmZktGaExWa2cxNGpMRzNldVFJb1NX?= =?utf-8?Q?osRMcooi9kS6AGbd/RHsHjQO6?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 56bbc5d6-6413-4bbe-d733-08dc8a7b111e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2024 01:00:35.3894 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xbx0F9DyvluGrYnBY9qP+bojbUVbeJ8xK6dDXAf0N32QKNLCi3PJYYjXaJEYE0TI X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6459 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2024 5:26 PM, Konstantin Ananyev wrote: > From: Konstantin Ananyev > > 1) ../drivers/net/ixgbe/ixgbe_ethdev.c:3556:46: warning: variable length array used [-Wvla] > 2) ../drivers/net/ixgbe/ixgbe_ethdev.c:3739:23: warning: variable length array used [-Wvla] > 3) ../drivers/net/ixgbe/ixgbe_rxtx_vec_common.h:17:24: warning: variable length array used [-Wvla] > > For first two cases: in fact ixgbe_xstats_calc_num() always returns > constant value, so it should be safe to replace that function invocation > just with a macro that performs same calculations. > ack > For case #3: reassemble_packets() is invoked only by > ixgbe_recv_scattered_burst_vec(). > And in turn, ixgbe_recv_scattered_burst_vec() operates only on fixed > max amount of packets per call: RTE_IXGBE_MAX_RX_BURST. > So, it should be safe to replace VLA with fixed size array. > Ack I see you already add assert, +1. Do you think adding a comment that caller calls with max RTE_IXGBE_MAX_RX_BURST helps? > > Signed-off-by: Konstantin Ananyev > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 21 +++++++++++++-------- > drivers/net/ixgbe/ixgbe_rxtx_vec_common.h | 4 +++- > 2 files changed, 16 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c > index bbdc996f31..7843cd41d3 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -3432,11 +3432,16 @@ ixgbe_dev_stats_reset(struct rte_eth_dev *dev) > } > > /* This function calculates the number of xstats based on the current config */ > + > +#define IXGBE_XSTATS_CALC_NUM \ > + (IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS + \ > + (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) + \ > + (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES)) > + > static unsigned > -ixgbe_xstats_calc_num(void) { > - return IXGBE_NB_HW_STATS + IXGBE_NB_MACSEC_STATS + > - (IXGBE_NB_RXQ_PRIO_STATS * IXGBE_NB_RXQ_PRIO_VALUES) + > - (IXGBE_NB_TXQ_PRIO_STATS * IXGBE_NB_TXQ_PRIO_VALUES); > +ixgbe_xstats_calc_num(void) > +{ > + return IXGBE_XSTATS_CALC_NUM; > } > > static int ixgbe_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > @@ -3552,8 +3557,8 @@ static int ixgbe_dev_xstats_get_names_by_id( > } > > uint16_t i; > - uint16_t size = ixgbe_xstats_calc_num(); > - struct rte_eth_xstat_name xstats_names_copy[size]; > + struct rte_eth_xstat_name xstats_names_copy[IXGBE_XSTATS_CALC_NUM]; > + const uint16_t size = RTE_DIM(xstats_names_copy); > > ixgbe_dev_xstats_get_names_by_id(dev, NULL, xstats_names_copy, > size); > @@ -3735,8 +3740,8 @@ ixgbe_dev_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids, > } > > uint16_t i; > - uint16_t size = ixgbe_xstats_calc_num(); > - uint64_t values_copy[size]; > + uint64_t values_copy[IXGBE_XSTATS_CALC_NUM]; > + const uint16_t size = RTE_DIM(values_copy); > > ixgbe_dev_xstats_get_by_id(dev, NULL, values_copy, size); > > diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h > index a4d9ec9b08..c1cf0a581a 100644 > --- a/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h > +++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_common.h > @@ -14,11 +14,13 @@ static inline uint16_t > reassemble_packets(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_bufs, > uint16_t nb_bufs, uint8_t *split_flags) > { > - struct rte_mbuf *pkts[nb_bufs]; /*finished pkts*/ > + struct rte_mbuf *pkts[RTE_IXGBE_MAX_RX_BURST]; /*finished pkts*/ > struct rte_mbuf *start = rxq->pkt_first_seg; > struct rte_mbuf *end = rxq->pkt_last_seg; > unsigned int pkt_idx, buf_idx; > > + RTE_ASSERT(nb_bufs <= RTE_DIM(pkts)); > + > for (buf_idx = 0, pkt_idx = 0; buf_idx < nb_bufs; buf_idx++) { > if (end != NULL) { > /* processing a split packet */