From: "Kirill A. Korinsky" <kirill@korins.ky>
To: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Fix VMware emulated e1000 doesn't support INTX_DISABLE flag
Date: Mon, 28 Sep 2015 05:51:11 +0000 [thread overview]
Message-ID: <5C5B8A9A-609F-45D6-8C82-4643F88D702E@korins.ky> (raw)
In-Reply-To: <20150927144157.77708f7c@urahara>
> On 28 Sep 2015, at 01:41, Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> On Sun, 27 Sep 2015 12:51:06 +0400
> "Kirill A. Korinsky" <kirill@korins.ky> wrote:
>
>> When you try to run any DPDK-app in VMWare with e1000/82545EM NIC
>> you have a lot of lines like:
>>
>> EAL: Error reading from file descriptor 9: Input/output error
>>
>> The reason of this error is bad INTX emulation in VMWare
>> and pci_intx_mask_supported return false every time.
>> ---
>> lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> index 865a276..c85f7e5 100644
>> --- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> +++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
>> @@ -36,6 +36,7 @@
>> #ifdef CONFIG_XEN_DOM0
>> #include <xen/xen.h>
>> #endif
>> +#include <asm/hypervisor.h>
>> #include <rte_pci_dev_features.h>
>>
>> #include "compat.h"
>> @@ -508,7 +509,8 @@ igbuio_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
>> }
>> /* fall back to INTX */
>> case RTE_INTR_MODE_LEGACY:
>> - if (pci_intx_mask_supported(dev)) {
>> + /* VMware emulated e1000 doesn't support INTX_DISABLE flag */
>> + if (pci_intx_mask_supported(dev) || x86_hyper == &x86_hyper_vmware) {
>> dev_dbg(&dev->dev, "using INTX");
>> udev->info.irq_flags = IRQF_SHARED;
>> udev->info.irq = dev->irq;
>
> I don't think driver should be expecting INTx to work on VMware.
> If kernel test fails, it means masking is broken (in VMware).
>
>
> It is better for driver (E1000 PMD) to report that Link state interrupt does
> not work (if IRQ setup fails). Then application can test if LSC irq works
> and not enable it.
Sounds reasonable.
Thanks!
next prev parent reply other threads:[~2015-09-28 5:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 8:51 Kirill A. Korinsky
2015-09-27 21:41 ` Stephen Hemminger
2015-09-28 5:51 ` Kirill A. Korinsky [this message]
2015-09-28 11:33 ` Kirill A. Korinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5C5B8A9A-609F-45D6-8C82-4643F88D702E@korins.ky \
--to=kirill@korins.ky \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).