From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-VE1-obe.outbound.protection.outlook.com (mail-eopbgr50058.outbound.protection.outlook.com [40.107.5.58]) by dpdk.org (Postfix) with ESMTP id 58FB12BA5 for ; Mon, 12 Mar 2018 18:26:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=8/0yTv5Gyk3uSPffbhmtN588HY0ua6hTCnJR+Di6qoc=; b=P0brCmanzOJHnkuQCworowfkM0o6cLVu/T/2R/72iup7bnUrwQ+SsdQo68K1Va+AXkElTiSsWKdZzts6mlr9vlmjU0/QDuwokxLUCRATJuSWqHYykYAKE/Q0RPJaecY/J1F732igw0a3rvOxXAqAN1EkBRgGcPdyMoQWCRWmVD8= Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com (10.167.195.147) by VI1PR0501MB1983.eurprd05.prod.outlook.com (10.166.45.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Mon, 12 Mar 2018 17:26:11 +0000 Received: from VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::59c:947c:846:ff92]) by VI1PR0501MB2045.eurprd05.prod.outlook.com ([fe80::59c:947c:846:ff92%13]) with mapi id 15.20.0548.021; Mon, 12 Mar 2018 17:26:11 +0000 From: Yongseok Koh To: Ferruh Yigit CC: Wenzhuo Lu , Jingjing Wu , "dev@dpdk.org" , Shahaf Shuler Thread-Topic: [PATCH v2] app/testpmd: print Rx/Tx offload values Thread-Index: AQHTuhOS2rZZrAiAuUuotb/sUzLVbaPM2kUA Date: Mon, 12 Mar 2018 17:26:11 +0000 Message-ID: <5CD4CA47-AC99-42DB-8C09-DD235DF27195@mellanox.com> References: <20180306162822.61791-1-ferruh.yigit@intel.com> <20180312150523.74621-1-ferruh.yigit@intel.com> In-Reply-To: <20180312150523.74621-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; x-originating-ip: [209.116.155.178] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0501MB1983; 7:ivBaUWO+5+64H6XETTlDynYTITNOkVauCkhONQxKcdUHaZ0fQeWHTtDXzU10DuDuu1lzDdUo+eIrLJ5P1o9kvFymJ0o+ekhxJ01Y8ZftOhypGS7tj0oiGuEIxWhUuGJThPoXPEEOtkeUs+GkMR5cMyOy2XmBT1U8GcFR0hk5Oy2lq+F4kXGXt0M0fR2+43H8nzkv9c/3Q54vRJDH+eQ+V8AaJKtzi0AVad3aS360dohsikGticUdk36hmW39OY9T x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fd085804-7aa3-4cfd-43e5-08d5883e59ab x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB1983; x-ms-traffictypediagnostic: VI1PR0501MB1983: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(228905959029699); x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(93006095)(93001095)(10201501046)(3231220)(944501244)(52105095)(6055026)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR0501MB1983; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB1983; x-forefront-prvs: 06098A2863 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(39380400002)(366004)(346002)(39860400002)(376002)(189003)(199004)(229853002)(316002)(3280700002)(186003)(2900100001)(2950100002)(99286004)(6916009)(102836004)(8936002)(14454004)(59450400001)(478600001)(68736007)(54906003)(81166006)(81156014)(6506007)(8676002)(86362001)(97736004)(36756003)(26005)(83716003)(53546011)(76176011)(2906002)(3660700001)(105586002)(305945005)(5660300001)(106356001)(7736002)(25786009)(6486002)(33656002)(53936002)(66066001)(6246003)(6512007)(107886003)(4326008)(82746002)(6436002)(5250100002)(6116002)(3846002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB1983; H:VI1PR0501MB2045.eurprd05.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-microsoft-antispam-message-info: Y6v4vFECpC6GdZxzxr2pU820Er8M40MX9iKgZF18iY1SX/7hB8Ew+SZiFJI0lhwjNYKp2tCEuKQfD47ehyukbA6LMOigY+TihgTMW20XDB+UXo7s3GFzSo6HpaPPs47ULBMmUxnR4/9ait37+M6yHu5EeDNSnbTgqjv6Emam3LDS+gJHaK8jWrnEppLyClflSkY/owW+TP9jCM3ZyOKc8nVvzKgoO1I6dmT1jlwSpy1uJohIffvsjnnvHF388iMXv3TIUmmqdqxjSPFPvcQlU3u4ActQM2j4yJr9nwcS4NX/3IJ+nM4AkKqe8pKmmeCV9N2J3OrIkhj6u69Y3LYkMg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd085804-7aa3-4cfd-43e5-08d5883e59ab X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Mar 2018 17:26:11.5289 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB1983 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: print Rx/Tx offload values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Mar 2018 17:26:13 -0000 > On Mar 12, 2018, at 8:05 AM, Ferruh Yigit wrote: >=20 > Which per port offloads are enabled is not clear. Printing offloads > values at forwarding start. >=20 > CRC strip offload value was printed in more verbose manner, it is > removed since Rx/Tx offload values covers it and printing only CRC one > can cause confusion. >=20 > Hexadecimal offloads values are not very user friendly but preferred to > not create to much noise during forwarding start. >=20 > Signed-off-by: Ferruh Yigit > --- > Cc: Shahaf Shuler > Cc: Yongseok Koh >=20 > v2: > * Add Rxq and Txq stats too > * Split Rx an Tx related logs and place them related group > --- > app/test-pmd/config.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c > index 4bb255c62..6249b19bb 100644 > --- a/app/test-pmd/config.c > +++ b/app/test-pmd/config.c > @@ -1682,10 +1682,6 @@ rxtx_config_display(void) > struct rte_eth_txconf *tx_conf =3D &ports[pid].tx_conf; >=20 > printf(" port %d:\n", (unsigned int)pid); > - printf(" CRC stripping %s\n", > - (ports[pid].dev_conf.rxmode.offloads & > - DEV_RX_OFFLOAD_CRC_STRIP) ? > - "enabled" : "disabled"); > printf(" RX queues=3D%d - RX desc=3D%d - RX free threshold=3D%d\n", > nb_rxq, nb_rxd, rx_conf->rx_free_thresh); > printf(" RX threshold registers: pthresh=3D%d hthresh=3D%d " > @@ -1693,6 +1689,9 @@ rxtx_config_display(void) > rx_conf->rx_thresh.pthresh, > rx_conf->rx_thresh.hthresh, > rx_conf->rx_thresh.wthresh); > + printf(" Rx offloads=3D0x%"PRIx64" RXQ Offloads=3D0x%"PRIx64"\n", > + ports[pid].dev_conf.rxmode.offloads, > + rx_conf->offloads); > printf(" TX queues=3D%d - TX desc=3D%d - TX free threshold=3D%d\n", > nb_txq, nb_txd, tx_conf->tx_free_thresh); > printf(" TX threshold registers: pthresh=3D%d hthresh=3D%d " > @@ -1700,8 +1699,10 @@ rxtx_config_display(void) > tx_conf->tx_thresh.pthresh, > tx_conf->tx_thresh.hthresh, > tx_conf->tx_thresh.wthresh); > - printf(" TX RS bit threshold=3D%d - TXQ offloads=3D0x%"PRIx64"\n", > - tx_conf->tx_rs_thresh, tx_conf->offloads); > + printf(" TX RS bit threshold=3D%d\n", tx_conf->tx_rs_thresh); > + printf(" Tx Offloads=3D0x%"PRIx64" TXQ offloads=3D0x%"PRIx64"\n", Small comment. It would be better to be consistent between "Offloads" and "= offloads" for Rx and Tx. :-) Other than that, Acked-by: Yongseok Koh Thanks