Re: [dpdk-dev] [RFC v1 00/11] scapy/python extension

["Wiles, Keith" <keith.wiles@intel.com>]

> On Dec 5, 2017, at 12:04 AM, Xueming Li <xuemingl@mellanox.com> wrote:
> 
> quick guide document:
> https://github.com/steevenlee/dpdk/blob/master_scapy/doc/guides/howto/scapy.rst
> github branch:
> https://github.com/steevenlee/dpdk/tree/master_scapy
> 
> 
> Xueming Li (11):
>  lib/cmdline: support backspace key
>  lib/cmdline: init parse result memeory
>  lib/cmdline: add echo support in batch loading from file
>  app/testpmd: support command echo in CLI batch loading
>  test: update batch loading test
>  lib/python: add embedded python lib
>  app/testpmd: add python command
>  app/testpmd: add pktgen forwarding engine
>  app/testpmd: add pktgen engine scapy commands
>  test/expect: add expect test scripts
>  doc/scapy: add scapy how-to guide
> 

Not to be a pain, but using the name pktgen is going to cause a bit of confusion with my Pktgen-DPDK application. Could you change the name to something else like trafficgen or whatever you like? I believe the naming of this feature is going to cause a lot of people to think this ‘pktgen’ is mine and I already have some confusion with the linux kernel traffic generator called ‘pktgen’ which is why I try to make sure everyone uses Pktgen-DPDK for the name of mine.

It would be very helpful if you would change the name from pktgen to something else, thanks.

> app/test-pmd/Makefile                    |    6 +
> app/test-pmd/cmdline.c                   |   80 ++-
> app/test-pmd/pktgen.c                    | 1092 ++++++++++++++++++++++++++++++
> app/test-pmd/testpmd.c                   |    1 +
> app/test-pmd/testpmd.h                   |    5 +
> config/common_base                       |    6 +
> doc/guides/howto/scapy.rst               |  300 ++++++++
> lib/Makefile                             |    2 +
> lib/librte_cmdline/cmdline_parse.c       |    2 +
> lib/librte_cmdline/cmdline_rdline.c      |    1 +
> lib/librte_cmdline/cmdline_socket.c      |    5 +-
> lib/librte_cmdline/cmdline_socket.h      |    3 +-
> lib/librte_cmdline/cmdline_vt100.c       |    1 +
> lib/librte_cmdline/cmdline_vt100.h       |    1 +
> lib/librte_eal/common/include/rte_log.h  |    1 +
> lib/librte_python/Makefile               |   60 ++
> lib/librte_python/rte_python.c           |  387 +++++++++++
> lib/librte_python/rte_python.h           |   71 ++
> lib/librte_python/rte_python_version.map |   12 +
> mk/rte.app.mk                            |    1 +
> test/expect/init.exp                     |   28 +
> test/expect/rx.exp                       |  134 ++++
> test/test/test_cmdline_lib.c             |   10 +-
> 23 files changed, 2199 insertions(+), 10 deletions(-)
> create mode 100644 app/test-pmd/pktgen.c
> create mode 100644 doc/guides/howto/scapy.rst
> create mode 100644 lib/librte_python/Makefile
> create mode 100644 lib/librte_python/rte_python.c
> create mode 100644 lib/librte_python/rte_python.h
> create mode 100644 lib/librte_python/rte_python_version.map
> create mode 100644 test/expect/init.exp
> create mode 100644 test/expect/rx.exp
> 
> -- 
> 2.13.3
> 

Regards,
Keith