Re: [dpdk-dev] [PATCH 0/5] clean up snprintf use for string copying

["Wiles, Keith" <keith.wiles@intel.com>]

> On Apr 3, 2019, at 9:45 AM, Bruce Richardson <bruce.richardson@intel.com> wrote:
> 
> There are quite a few instances remaining in DPDK where snprintf is being
> used for string copying. These were not being picked up by our existing
> coccinelle script, but that can be fixed by editing the script and running
> it against our code. In the process a bug was found and fixed in the
> bonding pmd, where we were incorrectly specifiying the buffer length
> parameter to snprintf.
> 
> The actual replacement was done in two phases - first replacing all
> instances where only the snprintf line in question needed changing, then
> fixing the other instances where we also needed to add in the header
> include. [Using two stages allowed the header addition to be automated too,
> since we had a list of files where every one needed the header inclusion]
> 
> 
> Bruce Richardson (5):
>  net/bonding: fix buffer length when printing strings
>  devtools/cocci: make strlcpy replacement smarter
>  devtools/cocci: create safer version of strlcpy script
>  replace snprintf with strlcpy without adding extra include
>  replace snprintf with strlcpy
> 

Should we not be testing the return values from strlcpy and snprintf, which means we need to create a macro or inline function. We could use a macro and only enable with DEBUG support if we think performance or code size if a problem.

I am surprised none of the tools are catching these types of problems.

Not to make Bruce do that change for this patch, but we need to look at it for a later patch IMO.

Regards,
Keith