From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 56A2841E34;
Thu, 9 Mar 2023 02:44:04 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3CF3C40ED7;
Thu, 9 Mar 2023 02:44:04 +0100 (CET)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
by mails.dpdk.org (Postfix) with ESMTP id D805340A7E
for <dev@dpdk.org>; Thu, 9 Mar 2023 02:44:01 +0100 (CET)
Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.56])
by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4PXBmR6k3kzKmTj;
Thu, 9 Mar 2023 09:43:51 +0800 (CST)
Received: from [10.67.100.224] (10.67.100.224) by
dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.21; Thu, 9 Mar 2023 09:43:59 +0800
Subject: Re: [PATCH v2 1/2] build: clarify configuration without IOVA field in
mbuf
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
CC: David Marchand <david.marchand@redhat.com>, Bruce Richardson
<bruce.richardson@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
=?UTF-8?Q?Morten_Br=c3=b8rup?= <mb@smartsharesystems.com>, Shijith Thotton
<sthotton@marvell.com>, Olivier Matz <olivier.matz@6wind.com>, Ruifeng Wang
<ruifeng.wang@arm.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran
Kumar K <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, Jingjing Wu <jingjing.wu@intel.com>,
Beilei Xing <beilei.xing@intel.com>, Ankur Dwivedi <adwivedi@marvell.com>,
Anoob Joseph <anoobj@marvell.com>, Tejasree Kondoj <ktejasree@marvell.com>,
Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Radha Mohan Chintakuntla <radhac@marvell.com>, Veerasenareddy Burru
<vburru@marvell.com>, Kevin Laatz <kevin.laatz@intel.com>, Pavan Nikhilesh
<pbhagavatula@marvell.com>, =?UTF-8?Q?Mattias_R=c3=b6nnblom?=
<mattias.ronnblom@ericsson.com>, Liang Ma <liangma@liangbit.com>, Peter
Mccarthy <peter.mccarthy@intel.com>, Jerin Jacob <jerinj@marvell.com>, Harry
van Haaren <harry.van.haaren@intel.com>, "Artem V. Andreev"
<artem.andreev@oktetlabs.ru>, Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru>, Ashwin Sekhar T K <asekhar@marvell.com>,
"John W. Linville" <linville@tuxdriver.com>, Ciara Loftus
<ciara.loftus@intel.com>, Chas Williams <chas3@att.com>, "Min Hu (Connor)"
<humin29@huawei.com>, Gaetan Rivet <grive@u256.net>, Dongdong Liu
<liudongdong3@huawei.com>, Yisen Zhuang <yisen.zhuang@huawei.com>, Konstantin
Ananyev <konstantin.v.ananyev@yandex.ru>, Qiming Yang
<qiming.yang@intel.com>, Jakub Grajciar <jgrajcia@cisco.com>, Tetsuya Mukawa
<mtetsuyah@gmail.com>, Jakub Palider <jpalider@marvell.com>, Tomasz Duszynski
<tduszynski@marvell.com>, Sachin Saxena <sachin.saxena@nxp.com>, Hemant
Agrawal <hemant.agrawal@nxp.com>
References: <20230219115529.3260580-1-thomas@monjalon.net>
<20230306161328.3802696-1-thomas@monjalon.net>
<20230306161328.3802696-2-thomas@monjalon.net>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <5a0d4a65-d0d4-ed81-9f44-35ef9fd29d48@huawei.com>
Date: Thu, 9 Mar 2023 09:43:59 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20230306161328.3802696-2-thomas@monjalon.net>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.100.224]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
dggpeml500024.china.huawei.com (7.185.36.10)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On 2023/3/7 0:13, Thomas Monjalon wrote:
> The impact of the option "enable_iova_as_pa" is explained for users.
>
> Also the code flag "RTE_IOVA_AS_PA" is renamed as "RTE_IOVA_IN_MBUF"
> in order to be more accurate (IOVA mode is decided at runtime),
> and more readable in the code.
>
> Similarly the drivers are using the variable "require_iova_in_mbuf"
> instead of "pmd_supports_disable_iova_as_pa" with an opposite meaning.
> By default, it is assumed that drivers require the IOVA field in mbuf.
> The drivers which support removing this field have to declare themselves.
>
> If the option "enable_iova_as_pa" is disabled, the unsupported drivers
> will be listed with the new reason text "requires IOVA in mbuf".
>
> Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
...
> compile_time_cpuflags = []
> subdir(arch_subdir)
> diff --git a/doc/guides/rel_notes/release_22_11.rst b/doc/guides/rel_notes/release_22_11.rst
> index 91414573bd..c67c2823a2 100644
> --- a/doc/guides/rel_notes/release_22_11.rst
> +++ b/doc/guides/rel_notes/release_22_11.rst
> @@ -504,7 +504,7 @@ ABI Changes
> ``rte-worker-<lcore_id>`` so that DPDK can accommodate lcores higher than 99.
>
> * mbuf: Replaced ``buf_iova`` field with ``next`` field and added a new field
> - ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_AS_PA`` is 0.
> + ``dynfield2`` at its place in second cacheline if ``RTE_IOVA_IN_MBUF`` is 0.
Should add to release 23.03 rst.
The original 22.11 still have RTE_IOVA_AS_PA definition.
...
> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build
> index e1a5afa2ec..743fae9db7 100644
> --- a/drivers/net/hns3/meson.build
> +++ b/drivers/net/hns3/meson.build
> @@ -13,9 +13,7 @@ if arch_subdir != 'x86' and arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_
> subdir_done()
> endif
>
> -if dpdk_conf.get('RTE_IOVA_AS_PA') == 0
> - build = false
> - reason = 'driver does not support disabling IOVA as PA mode'
> +if not get_option('enable_iova_as_pa')
> subdir_done()
> endif
Suggest keep original, and replace RTE_IOVA_AS_PA with RTE_IOVA_IN_MBUF:
if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0
subdir_done()
endif
Meson build 0.63.0 already support deprecated a option by a new option.
When update to the new meson verion, the drivers' meson.build will not be modified.
>
> diff --git a/drivers/net/ice/ice_rxtx_common_avx.h b/drivers/net/ice/ice_rxtx_common_avx.h
> index e69e23997f..dacb87dcb0 100644
...