From: Ferruh Yigit <ferruh.yigit@intel.com> To: Ophir Munk <ophirmu@nvidia.com>, "dev@dpdk.org" <dev@dpdk.org>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>, Bernard Iremonger <bernard.iremonger@intel.com>, Olivier Matz <olivier.matz@6wind.com> Cc: Ophir Munk <ophirmu@mellanox.com> Subject: Re: [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing Date: Thu, 8 Oct 2020 14:37:30 +0100 Message-ID: <5a0e3254-4bce-59ac-5d07-15fb5c8720bd@intel.com> (raw) In-Reply-To: <DM5PR12MB1161897A06A7D54ECF10E27DDC0B0@DM5PR12MB1161.namprd12.prod.outlook.com> On 10/8/2020 9:44 AM, Ophir Munk wrote: > > >> -----Original Message----- >> From: Ferruh Yigit <ferruh.yigit@intel.com> >> Sent: Wednesday, October 7, 2020 7:25 PM >> To: Ophir Munk <ophirmu@nvidia.com>; dev@dpdk.org; Wenzhuo Lu > <...> >> Only when user set via "--geneve-port=N", it is the port for testpmd to parse >> (same for 'geneve_udp_port' global variable), but when user give command >> "port config N add geneve X" it is to configure the NIC to offload the parsing. >> This is too confusing, user can't know (or remember) this without checking >> the source code. >> >> Can we rename the command and variable to highlight that it is for testpmd >> to parse, I think that will be enough, instead of trying to merge them, which >> is hard as you described above. >> >> What do you think for "--testpmd-geneve-port=N" parameter and >> 'testpmd_geneve_udp_port' variable name? > > I am suggesting two options: > 1. "--geneve-port-identifier=N" and "geneve_udp_port_identifier" as variable name. > 2. "--geneve-parsed-port=N" and "geneve_udp_port" as variable name. > Can you select one of them? > I think 'identifier' doesn't add any more clarification, lets go with (2). Thanks. >> We can also update the documentation to say this is only the port testpmd >> uses for parsing, HW may be configured to use another port. >> > > Will update documentation. > > <...> >>> Done in v6. I added other missing tunnel protocols (in alphabetical order) >> such as "gtp". Since it is more than geneve I added it to the 3rd (cleanup) >> commit. >>> >> >> Would you mind adding the 'geneve' with the patch adding 'geneve' support >> (1/3), and add the other missing ones in the patch 3/3 ? > > Will update accordingly >
next prev parent reply other threads:[~2020-10-08 13:37 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-29 8:29 [dpdk-dev] [PATCH v1 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-07-29 8:29 ` [dpdk-dev] [PATCH v1 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-14 17:27 ` Ferruh Yigit 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-09-15 13:56 ` Ophir Munk 2020-09-17 12:23 ` Olivier Matz 2020-09-18 14:21 ` Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-06 14:30 ` Ferruh Yigit 2020-10-07 14:52 ` Ophir Munk 2020-10-07 16:25 ` Ferruh Yigit 2020-10-08 8:44 ` Ophir Munk 2020-10-08 13:37 ` Ferruh Yigit [this message] 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 1/3] app/testpmd: add GENEVE parsing Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-10-08 20:16 ` [dpdk-dev] [PATCH v7 3/3] app/testpmd: tunnel parsing protocols cleanup Ophir Munk 2020-10-09 12:49 ` [dpdk-dev] [PATCH v7 0/3] Add GENEVE protocol parsing to testpmd Ferruh Yigit 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-10-07 15:30 ` [dpdk-dev] [PATCH v6 3/3] app/testpmd: tunnel parsing protocols cleanup Ophir Munk 2020-10-07 16:05 ` Ferruh Yigit 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-18 14:17 ` [dpdk-dev] [PATCH v5 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-10-06 14:30 ` Ferruh Yigit 2020-10-07 10:56 ` Ophir Munk 2020-10-06 14:58 ` [dpdk-dev] [PATCH v5 0/3] Add GENEVE protocol parsing to testpmd Ferruh Yigit 2020-10-07 15:43 ` Ophir Munk 2020-10-07 16:00 ` Ferruh Yigit 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-15 13:17 ` [dpdk-dev] [PATCH v4 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-15 12:53 ` [dpdk-dev] [PATCH v3 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 2/3] app/testpmd: enable configuring GENEVE port Ophir Munk 2020-09-14 17:31 ` Ferruh Yigit 2020-09-15 8:46 ` Ophir Munk 2020-09-15 11:07 ` Ferruh Yigit 2020-09-15 12:59 ` Ophir Munk 2020-09-15 13:19 ` Ophir Munk 2020-08-27 7:02 ` [dpdk-dev] [PATCH v2 3/3] app/testpmd: reduce tunnel parsing code duplication Ophir Munk 2020-08-31 6:40 ` [dpdk-dev] [PATCH v2 0/3] Add GENEVE protocol parsing to testpmd Ophir Munk
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5a0e3254-4bce-59ac-5d07-15fb5c8720bd@intel.com \ --to=ferruh.yigit@intel.com \ --cc=beilei.xing@intel.com \ --cc=bernard.iremonger@intel.com \ --cc=dev@dpdk.org \ --cc=olivier.matz@6wind.com \ --cc=ophirmu@mellanox.com \ --cc=ophirmu@nvidia.com \ --cc=wenzhuo.lu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git