From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C4C64A0524;
Tue, 13 Apr 2021 13:30:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7CB1B160E4A;
Tue, 13 Apr 2021 13:30:42 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 755A5160E2D
for <dev@dpdk.org>; Tue, 13 Apr 2021 13:30:40 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1618313439;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=wUTHqv0kQdD2YmSxTNl5jEHyn4vkekAulyPlKhup+zw=;
b=Oi/buY48upICIr/LssqVHtkE0krZofju3y/OOwbFODKRQxBqvI7OI1fC1DcitaZHHloFuQ
qn7MPmh5r84slONX5QpnsMJRo9slrjHv1MmUYGd1WSOVW8SRJJF8GaeK0nWeQ4hDq7HsJd
yc8BAqkVPhRqqblNG9qR3B/8U/0+OaM=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
[209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-104-r4WXeIyMPViBjSNK6eBrLA-1; Tue, 13 Apr 2021 07:30:36 -0400
X-MC-Unique: r4WXeIyMPViBjSNK6eBrLA-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com
[10.5.11.22])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DAA5C1007B30;
Tue, 13 Apr 2021 11:30:34 +0000 (UTC)
Received: from [10.36.110.28] (unknown [10.36.110.28])
by smtp.corp.redhat.com (Postfix) with ESMTPS id 4793010023AB;
Tue, 13 Apr 2021 11:30:33 +0000 (UTC)
To: Jiayu Hu <jiayu.hu@intel.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, yinan.wang@intel.com, sunil.pai.g@intel.com,
cheng1.jiang@intel.com, stable@dpdk.org
References: <1615985773-406787-1-git-send-email-jiayu.hu@intel.com>
<1617368642-131298-1-git-send-email-jiayu.hu@intel.com>
<1617368642-131298-2-git-send-email-jiayu.hu@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <5a15a9af-4159-568f-e825-5b5800c9b824@redhat.com>
Date: Tue, 13 Apr 2021 13:30:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <1617368642-131298-2-git-send-email-jiayu.hu@intel.com>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 1/4] vhost: fix uninitialized vhost queue
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 4/2/21 3:03 PM, Jiayu Hu wrote:
> This patch allocates vhost queue by rte_zmalloc() to avoid
> undefined values.
>
> Fixes: a277c7159876 ("vhost: refactor code structure")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> ---
> lib/librte_vhost/vhost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
> index c9d1371..8657bbe 100644
> --- a/lib/librte_vhost/vhost.c
> +++ b/lib/librte_vhost/vhost.c
> @@ -609,7 +609,7 @@ alloc_vring_queue(struct virtio_net *dev, uint32_t vring_idx)
> if (dev->virtqueue[i])
> continue;
>
> - vq = rte_malloc(NULL, sizeof(struct vhost_virtqueue), 0);
> + vq = rte_zmalloc(NULL, sizeof(struct vhost_virtqueue), 0);
> if (vq == NULL) {
> VHOST_LOG_CONFIG(ERR,
> "Failed to allocate memory for vring:%u.\n", i);
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime