* [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide
@ 2019-01-04 9:10 Rami Rosen
2019-01-04 9:57 ` Iremonger, Bernard
0 siblings, 1 reply; 4+ messages in thread
From: Rami Rosen @ 2019-01-04 9:10 UTC (permalink / raw)
To: dev; +Cc: stable, bernard.iremonger, Rami Rosen
There is no parameter called "eth-peer-configfile" in testpmd. It should
be "eth-peers-configfile". See the usage() method in
app/test-pmd/parameters.c.
v2: Fix line too long in the patch commit log.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..1ceb000da 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -304,7 +304,7 @@ The available information categories are:
* ``mac``: Changes the source and the destination Ethernet addresses of packets before forwarding them.
Default application behaviour is to set source Ethernet address to that of the transmitting interface, and destination
address to a dummy value (set during init). The user may specify a target destination Ethernet address via the 'eth-peer' or
- 'eth-peer-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
+ 'eth-peers-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
* ``macswap``: MAC swap forwarding mode.
Swaps the source and the destination Ethernet addresses of packets before forwarding them.
--
2.19.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide
2019-01-04 9:10 [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide Rami Rosen
@ 2019-01-04 9:57 ` Iremonger, Bernard
2019-01-09 11:00 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Iremonger, Bernard @ 2019-01-04 9:57 UTC (permalink / raw)
To: Rami Rosen, dev; +Cc: stable
> -----Original Message-----
> From: Rami Rosen [mailto:ramirose@gmail.com]
> Sent: Friday, January 4, 2019 9:11 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
> Rami Rosen <ramirose@gmail.com>
> Subject: [PATCH v2] doc: fix a parameter name in testpmd guide
>
> There is no parameter called "eth-peer-configfile" in testpmd. It should be "eth-
> peers-configfile". See the usage() method in app/test-pmd/parameters.c.
>
> v2: Fix line too long in the patch commit log.
>
> Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rami Rosen <ramirose@gmail.com>
Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide
2019-01-04 9:57 ` Iremonger, Bernard
@ 2019-01-09 11:00 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-01-09 11:00 UTC (permalink / raw)
To: Iremonger, Bernard, Rami Rosen, dev; +Cc: stable
On 1/4/2019 9:57 AM, Iremonger, Bernard wrote:
>> -----Original Message-----
>> From: Rami Rosen [mailto:ramirose@gmail.com]
>> Sent: Friday, January 4, 2019 9:11 AM
>> To: dev@dpdk.org
>> Cc: stable@dpdk.org; Iremonger, Bernard <bernard.iremonger@intel.com>;
>> Rami Rosen <ramirose@gmail.com>
>> Subject: [PATCH v2] doc: fix a parameter name in testpmd guide
>>
>> There is no parameter called "eth-peer-configfile" in testpmd. It should be "eth-
>> peers-configfile". See the usage() method in app/test-pmd/parameters.c.
>>
>> v2: Fix line too long in the patch commit log.
>>
>> Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide
@ 2019-01-04 9:10 Rami Rosen
0 siblings, 0 replies; 4+ messages in thread
From: Rami Rosen @ 2019-01-04 9:10 UTC (permalink / raw)
To: dev; +Cc: stable, bernard.iremonger, Rami Rosen
There is no parameter called "eth-peer-configfile" in testpmd. It should
be "eth-peers-configfile". See the usage() method in
app/test-pmd/parameters.c.
v2: Fix line too long in the patch commit log.
Fixes: a67857e97ba8 ("doc: clarify usage of testpmd MAC forward mode")
Cc: stable@dpdk.org
Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index cbf23e928..1ceb000da 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -304,7 +304,7 @@ The available information categories are:
* ``mac``: Changes the source and the destination Ethernet addresses of packets before forwarding them.
Default application behaviour is to set source Ethernet address to that of the transmitting interface, and destination
address to a dummy value (set during init). The user may specify a target destination Ethernet address via the 'eth-peer' or
- 'eth-peer-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
+ 'eth-peers-configfile' command-line options. It is not currently possible to specify a specific source Ethernet address.
* ``macswap``: MAC swap forwarding mode.
Swaps the source and the destination Ethernet addresses of packets before forwarding them.
--
2.19.2
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-09 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 9:10 [dpdk-dev] [PATCH v2] doc: fix a parameter name in testpmd guide Rami Rosen
2019-01-04 9:57 ` Iremonger, Bernard
2019-01-09 11:00 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 9:10 Rami Rosen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).