From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 931E0A0C43; Fri, 22 Oct 2021 10:59:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7899141103; Fri, 22 Oct 2021 10:59:57 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 408B14069D for ; Fri, 22 Oct 2021 10:59:55 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229128754" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="229128754" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 01:59:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="568989860" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by FMSMGA003.fm.intel.com with ESMTP; 22 Oct 2021 01:59:52 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 01:59:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 01:59:52 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 01:59:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OTBZavveyCXIjTyFkd9jbuOuOMDDDigOWBCEJwIOOLJ25ZXFi5Ftq2+mgPth7Ung73aC6Z+pLvLO6ojGoqEHVYpUfa69JJDPQuexgKDtKg3F61dRTn2T42wJP6SSC+WWZFbJ+fbVzvtLuyb7sn0y750z/RZmAINQDMx+MG9XgrsVWhp8Gs/SWHF+qKcHhxlCwjrzXbbdeLzWHlfQQGorSahjElFHbO3YJmfwsmG2nLkb8OW4Eb4H7exBQH5KprU7rA2u8Bu2YFh2cBxWDilM+TWac5jChCciZTeolHJIV39gDGeBelYq11QCeuHKI71k76Lz0VwGad0jy/M8945xOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AGTwldFKgTlvkTB3v2Y2lVFBTnp9V1diPwWyZS11hVc=; b=grJPoZZpG1K999Nv8QC5RwdOcWd2bkppHye4rIYlGODymL4OZCowkHOl/m7K6K9UEyq65d2rydVTfk9DyubCkZwbPh01fMpigaD2XTE7A/dTPSDHFOMcLHYh5T/36JzaeQaM54m6ZwuMdhg4FqFxKSDOIZyWbBYn16jAc1AKe5n070MBluPqMAFTfDQY3XsT3CP1pT27L6+YOPlrGiP1fYKpc8mlQf9h2rt92o7P2N/hPMR8g8AKMeiqZQWIkEu0MVq0id2n6H9CUJeT37XseafuZuJlucYoPH32D5eRnRTUtStp91qvI/DqQflU6GWj0FOtd6dlOw9Yhw+sw69yxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AGTwldFKgTlvkTB3v2Y2lVFBTnp9V1diPwWyZS11hVc=; b=MaEIKQbSxhTxg+vEBNsHjHVF7WK31OrdeYvlT7QE8lrn92reLjglaTXdNmKt+nH9ldPW35FxzqrHIm42YH3qSXRHBL9cWBQV1eeKFNYR8GT5aqSqURi9V8GqhLchZoGqhRQE70NPNNELw+CEQLzmCDf6lVmjFhV7X1GWrJTmkPw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4854.namprd11.prod.outlook.com (2603:10b6:510:35::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 08:59:51 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 08:59:51 +0000 Message-ID: <5a2f25db-dd26-de68-e0a1-39cb9ddf882c@intel.com> Date: Fri, 22 Oct 2021 09:59:45 +0100 Content-Language: en-US To: "Li, Miao" , "dev@dpdk.org" CC: "Xia, Chenbo" , "maxime.coquelin@redhat.com" References: <20211015170911.478394-1-miao.li@intel.com> <20211018141638.5916-1-miao.li@intel.com> <20211018141638.5916-2-miao.li@intel.com> <47ad3cc9-bfe9-f8e5-83c7-626edbcee3c0@intel.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR1001CA0034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR1001CA0034.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:4:55::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.16 via Frontend Transport; Fri, 22 Oct 2021 08:59:50 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d32578b4-d145-4fe5-f55c-08d9953a4ece X-MS-TrafficTypeDiagnostic: PH0PR11MB4854: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7691; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: De/oQVRHRUF33cnCyU8XlJBpvZOeccDgQjc4br8y2fmebjK77pVFNB2B5K/Fd12i0cqzu3V26YYuOYs6j7fDHOBkHxZgdWhbhSQ6N0irMZpyo6SLyCsC9GUqlOO3aY6irftiTVqzNubvTmxF3VbylDqg5mE9G3ez4TclHmLHLHESbfBC0q/zRFijXe02y8d/vPeccUzCnapFjqZ4mzgdZO9JDf6YvqXRJnu+GB1jWNs+IcGK/ts2FhkJmkMamY8CBA9YbuzC+9LhSWn0nUQ8K/xtIt8C64mkx/PMg9PIFx6tCWxqszJSvzVBApzCaWz4vGhIC5bcUnYHVS9REutskxziMQLRlJ1MuW2PHbBeIt8luR6kuPkczgkvO/QPL4qZZP+PvQnlI94tP3udK3C01nYc9Fw/z76KUMF2xE1ykqQjFDwuDjgdZGpCu++H6yqCdrx7hveBpUtDguaav08Uzckozr46H7O7XvNMXyV4jd1HXYXREyeUJWVGPEUjGEHw7ScAL8SALHQurokmUIXPQwF1hDe28o/qMeWlV/7D1GG+PMxYWfxBTOJ4A/21R7OgtKlljwiUxV+8fAdZgvzN1pmXoLsiSqH9ul51Z2PmwoXUj62HvysoZRp+qhVDJLviKaY5LE2x/3QSSt1/43x3JWGXG1VXyzSZghiWJftSUJdHO1jT40NwwRqhg+S3zFO/1qAL3N8lD3Eq2hwr1N1Eng== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(4326008)(83380400001)(16576012)(54906003)(508600001)(5660300002)(186003)(44832011)(38100700002)(6666004)(2616005)(82960400001)(110136005)(53546011)(31686004)(66946007)(66556008)(26005)(8676002)(66476007)(86362001)(6486002)(36756003)(31696002)(956004)(316002)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Nk54cE43aTg4WXJHMlpPY0tyT1RIUnZjbFZkZExKWXQ3NS9jYUd1aS9LMmZl?= =?utf-8?B?T1k2NTFFNE43bk5yUlhGS2ZzNkhtZkRPWXY1ZXEzTzhGZ00rZWtvOEZHYXJv?= =?utf-8?B?VE43d29aRVYzUnUvUTcvV2tsM1lieW1DNmFZRUxhUCtxbEFOVUxTb0Z5U2pC?= =?utf-8?B?K3loeE9LeUp4WkU4UWgyTno5Z3pEbURibnZlTGxqdEd4Z0Y4dDRiMm1hZmRB?= =?utf-8?B?VS9OZ3E0MGxubnI1dnFFYVRlcEgwQnVnTHA3dE9TbkJsU2d4dDFFK2RpdWxF?= =?utf-8?B?Wlg5eUhqSDNuU2pyTnZDdE02NGdzMWNwRzZtdDBPc3Urbmc1K0NHUDJkUkxT?= =?utf-8?B?RmwycnI5aHJWWFFlYU9lZzJmTzVwdWJiNWtlZlFlNkpMUHp5K3ZwQ09rY2NO?= =?utf-8?B?aFEybXh0a1EzTnNMV2t1ZklxZk5henVHYTI3YmJVbGdqZzJxMG1VbE9tdXhZ?= =?utf-8?B?SnArdHVQYmNKZ0VydUZWanloblhQQ1pRbnNWdkFBbExYNXp2UnprOE9oN3A1?= =?utf-8?B?b1hwNU1tTCtadWhHcEIxR2JRWkg0dlNXU3RhOG1QeEZjbXBDWWhLY2RFUDZD?= =?utf-8?B?bEJ2WmRuSGlEM2VESk0ways2MnBUNnZGWHhkcjNQNWZXb25TSzhvbWUvRThF?= =?utf-8?B?WGRBMStnRFNUT0JqMTdpM0p0L1ZmZlFoNkVCYjgvWWlGY3VtaVFXV29lUmcy?= =?utf-8?B?dWpkV0QydEtweFdIVXJRcEdxVnUrOTN5UEI2cGFFR1RiS0tydVp6bjhBbkdF?= =?utf-8?B?WEZ0Z2FNbm52a3p6RDgrZGlDZFlEUit1eVU2R3gvUWx6eXVaOW5YRGJDa2Z1?= =?utf-8?B?c2NjSENHNXE1TGZoaElQRjhHNXRubWZneWk1R2kvWTdIK2dyQ0Y1eGNPNCtI?= =?utf-8?B?VmJweFM2azgrYUZITERlQTJydUVxUFU1OEJMcEViYTEraG9xL3NoU1V0djls?= =?utf-8?B?QkhlcGtsVS9CSDBjWldJdXdvU2F4c21COUNrZ0tRZWZKQlhEc0NiSTV0WnZF?= =?utf-8?B?dVZRQS9PWmw0OHBTOFBrUDJ5RjBwczhjSitxMkNsWDRKaS8wSk9KT01WWUwz?= =?utf-8?B?L3RDbjlHMmJNU0NLRWFUeHJ3d0VFRUJMOFJVYVJLK0daT0JOVkFDTjNPdE93?= =?utf-8?B?eXRQclRvN0JmUGk1QWNDZGpMWFg3bU83OW1PNDNjd2Nxa2wrc1BCT3MzeXBr?= =?utf-8?B?cmhlZ3ZuZDhZb3VvWGEzZ2xUT3lRcHcwRm82NExQbThIRDVDOFgwQ1FBcTRZ?= =?utf-8?B?YU1NVUNKRFdaWVJKbFQ3L3Zqa1duQTd1RytnZ2pWTW5WTkNUZnpMaHFJUFpP?= =?utf-8?B?TXdLcFg0ZG9rQXlZbXNlVG5YUzRFbVBHRXdlVnJJY2F0VlZ2V0wvb3BMNTVW?= =?utf-8?B?dVhrVFNXSTFYQnd5RUgvNU1mTW9SYlpFTEFpTXpSby84Y0RQREdMdEJRUW51?= =?utf-8?B?Vzg0WFlON0wvV29XOE1DU0d1U3lrZU5TaTl2amxkWEx2WDRNeUxRUHJaNHZJ?= =?utf-8?B?NVVFdk9GNEsxeUtkZHcvSUdRMjFvQjRLY1JnYUNlVmVWSDcvc1hXa0hqbGYw?= =?utf-8?B?WjFjd0x4Rnp2OHpzY1pZM2YwS2hpaWF6VlZrUUkyN245WHdvR243dG5ydDNO?= =?utf-8?B?UmJBcWQrUG93K0pNOVRvMDBDYlNvUThiSVZySTdld1RuaGlrWFFDeE0vanBL?= =?utf-8?B?Rk96aExack1xbmdTU2pwM3E1blR1ekhYczZ1ZXhoTlZTNk1vU2dicEorRG5l?= =?utf-8?B?N2lkZjc2M3IvOElYWkJqczYyWTM4TWt2WHFXOXE2aUNzRWJ1bTlqTjAycXdr?= =?utf-8?B?dTVOcmM0U2VtWUpXbi9pZldHR2Mva2ZoZndwYmFrVFlnMnlMNHFzSjRmVkRs?= =?utf-8?B?Z1NYOXlMR3JPOFdOaUZITzVEZFN3bEtLL1hhSEJBY05WUmI0OXhIZ1FhRFVy?= =?utf-8?Q?mu38ZauC5vQ55r0Kr//vwXataN0It2fy?= X-MS-Exchange-CrossTenant-Network-Message-Id: d32578b4-d145-4fe5-f55c-08d9953a4ece X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 08:59:51.4893 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4854 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 9:51 AM, Li, Miao wrote: > Hi, > >> -----Original Message----- >> From: Li, Miao >> Sent: Friday, October 22, 2021 4:28 PM >> To: Yigit, Ferruh ; dev@dpdk.org >> Cc: Xia, Chenbo ; maxime.coquelin@redhat.com >> Subject: RE: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement >> rte_power_monitor API >> >> Hi, >> >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Friday, October 22, 2021 12:59 AM >>> To: Li, Miao ; dev@dpdk.org >>> Cc: Xia, Chenbo ; maxime.coquelin@redhat.com >>> Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement >>> rte_power_monitor API >>> >>> On 10/18/2021 3:16 PM, Miao Li wrote: >>>> This patch implements rte_power_monitor API in virtio PMD to reduce >>>> power consumption when no packet come in. According to current >> semantics >>>> of power monitor, this commit adds a callback function to decide whether >>>> aborts the sleep by checking current value against the expected value and >>>> virtio_get_monitor_addr to provide address to monitor. When no packet >>> come >>>> in, the value of address will not be changed and the running core will >>>> sleep. Once packets arrive, the value of address will be changed and the >>>> running core will wakeup. >>>> >>> >>> A minor comment but instead of patch title mentioning what is implemented, >>> better to describe what feature is added, like: >>> net/virtio: support power monitor >> >> I will modify it in the next version. >> >>> >>>> Signed-off-by: Miao Li >>>> Reviewed-by: Chenbo Xia >>>> --- >>>> doc/guides/rel_notes/release_21_11.rst | 4 ++ >>>> drivers/net/virtio/virtio_ethdev.c | 56 ++++++++++++++++++++++++++ >>>> 2 files changed, 60 insertions(+) >>>> >>>> diff --git a/doc/guides/rel_notes/release_21_11.rst >>> b/doc/guides/rel_notes/release_21_11.rst >>>> index d5435a64aa..c298844898 100644 >>>> --- a/doc/guides/rel_notes/release_21_11.rst >>>> +++ b/doc/guides/rel_notes/release_21_11.rst >>>> @@ -80,6 +80,10 @@ New Features >>>> Added macros ETH_RSS_IPV4_CHKSUM and ETH_RSS_L4_CHKSUM, now >>> IPv4 and >>>> TCP/UDP/SCTP header checksum field can be used as input set for RSS. >>>> >>>> +* **Updated virtio PMD.** >>>> + >>>> + Implement rte_power_monitor API in virtio PMD. >>>> + >>> >>> The release note updates are grouped as described in the documents section >>> comment, and in a group it is sorted alphabetically, can you please re-arrange >>> the update accordingly. And similar comment, instead of documenting what >> API >>> implemented, you can mention what support is added. >> >> I will re-arrange the update and modify the description in the next version. > > The updates are requested to be ordered alphabetically by vendor name. But > Vhost/virtio do not have a vendor name. So should I order virtio/vhost by 'v'? > I think sort it by 'v' is good, unless Maxime & Chenbo has better idea.