From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 9D8461B685 for ; Mon, 23 Oct 2017 20:08:45 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2017 11:08:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.43,424,1503385200"; d="scan'208";a="1234235305" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.136]) ([10.241.225.136]) by fmsmga002.fm.intel.com with ESMTP; 23 Oct 2017 11:08:43 -0700 To: Andrew Rybchenko , dev@dpdk.org Cc: Ivan Malov References: <1508319597-21039-1-git-send-email-arybchenko@solarflare.com> From: Ferruh Yigit Message-ID: <5a35c104-6c8c-6b08-3a71-aa02a6142282@intel.com> Date: Mon, 23 Oct 2017 11:08:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508319597-21039-1-git-send-email-arybchenko@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/sfc: fix Tx reap behaviour on port stop on EF10 datapath X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Oct 2017 18:08:46 -0000 On 10/18/2017 2:39 AM, Andrew Rybchenko wrote: > From: Ivan Malov > > Tx reap mechanism on EF10 native datapath was altered by one > of the recent patches to introduce performance optimisations > using the common technique of freeing mbuf segments in bulks. > > From this perspective, the way of associating SW descriptors > with individual mbuf segments rather than with whole packets > was adopted as a key requirement for the entire optimisation. > > However, only the fast path reap function was amended to fit > the new scheme whilst the corresponding function on the port > stop path was left intact by mistake. This implies incorrect > usage of rte_pktmbuf_free() with regard to separate segments > rather than calling rte_pktmbuf_free_seg() and must be fixed. Good to know you are OK Ivan, I was worried when previous a few commit logs were not perfectly aligned :) > > Fixes: d321954343c8 ("net/sfc: free mbufs in bulks on EF10 native Tx reap") > > Signed-off-by: Ivan Malov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton Applied to dpdk-next-net/master, thanks.