From: Remy Horton <remy.horton@intel.com>
To: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>, dev@dpdk.org
Cc: Qi Zhang <qi.z.zhang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missing Port Representor data-path callbacks
Date: Fri, 11 May 2018 13:29:04 +0100 [thread overview]
Message-ID: <5a4dea92-18db-2e4a-7ae5-3fadd0720137@intel.com> (raw)
In-Reply-To: <91b7ee64-fbd0-0b6a-28ad-41906f414733@intel.com>
On 11/05/2018 11:48, Mohammad Abdul Awal wrote:
[..]
>> +static uint16_t
>> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
>> + struct rte_mbuf **tx_pkts,
>> + uint16_t nb_pkts)
>> +{
>> + uint16_t idx_pkt;
>> +
>> + for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
>> + rte_pktmbuf_free(tx_pkts[idx_pkt]);
> We should not free them in the driver silently whereas the application
> will think that it has been sent successfully.
> Please use the same rule for rx_burst, and return 0.
Ok, v2 coming.
I'll also combine this and the ixgbe patch into the same patchset.
next prev parent reply other threads:[~2018-05-11 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 15:00 Remy Horton
2018-05-11 10:48 ` Mohammad Abdul Awal
2018-05-11 12:29 ` Remy Horton [this message]
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 0/2] " Remy Horton
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix missing Port Representor data-path Remy Horton
2018-05-11 14:04 ` Mohammad Abdul Awal
2018-05-11 16:08 ` Ferruh Yigit
2018-05-11 12:28 ` [dpdk-dev] [PATCH v2 2/2] net/ixgbe: " Remy Horton
2018-05-11 14:04 ` Mohammad Abdul Awal
2018-05-11 16:08 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5a4dea92-18db-2e4a-7ae5-3fadd0720137@intel.com \
--to=remy.horton@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).