From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <remy.horton@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by dpdk.org (Postfix) with ESMTP id CACF31C4A9
 for <dev@dpdk.org>; Fri, 11 May 2018 14:29:07 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 11 May 2018 05:29:06 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.49,388,1520924400"; d="scan'208";a="198537673"
Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.68])
 ([163.33.230.68])
 by orsmga004.jf.intel.com with ESMTP; 11 May 2018 05:29:05 -0700
To: Mohammad Abdul Awal <mohammad.abdul.awal@intel.com>, dev@dpdk.org
References: <20180509150005.2531-1-remy.horton@intel.com>
 <91b7ee64-fbd0-0b6a-28ad-41906f414733@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Ferruh Yigit <ferruh.yigit@intel.com>
From: Remy Horton <remy.horton@intel.com>
Organization: Intel Shannon Limited
Message-ID: <5a4dea92-18db-2e4a-7ae5-3fadd0720137@intel.com>
Date: Fri, 11 May 2018 13:29:04 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.1
MIME-Version: 1.0
In-Reply-To: <91b7ee64-fbd0-0b6a-28ad-41906f414733@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix missing Port Representor
 data-path callbacks
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 11 May 2018 12:29:08 -0000


On 11/05/2018 11:48, Mohammad Abdul Awal wrote:
[..]
>> +static uint16_t
>> +i40e_vf_representor_tx_burst(__rte_unused void *tx_queue,
>> +    struct rte_mbuf **tx_pkts,
>> +    uint16_t nb_pkts)
>> +{
>> +    uint16_t idx_pkt;
>> +
>> +    for (idx_pkt = 0; idx_pkt < nb_pkts; idx_pkt++)
>> +        rte_pktmbuf_free(tx_pkts[idx_pkt]);
> We should not free them in the driver silently whereas the application
> will think that it has been sent successfully.
> Please use the same rule for rx_burst, and return 0.

Ok, v2 coming.

I'll also combine this and the ixgbe patch into the same patchset.