DPDK patches and discussions
 help / color / mirror / Atom feed
From: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
To: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
	dev@dpdk.org, david.marchand@redhat.com, aconole@redhat.com
Cc: nd@arm.com
Subject: Re: [dpdk-dev] [PATCH] eal: change the log level for test assert macro
Date: Thu, 16 Jul 2020 17:16:13 +0200	[thread overview]
Message-ID: <5a5beb8e-91b6-0c66-4e0f-3238e8655cb7@partner.samsung.com> (raw)
In-Reply-To: <20200715202006.19781-1-honnappa.nagarahalli@arm.com>


W dniu 15.07.2020 o 22:20, Honnappa Nagarahalli pisze:
> Change the log level for RTE_TEST_ASSERT macro to error to help
> log errors while running test cases.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> ---
>   lib/librte_eal/include/rte_test.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/include/rte_test.h b/lib/librte_eal/include/rte_test.h
> index 89e47f47a..62c8f165a 100644
> --- a/lib/librte_eal/include/rte_test.h
> +++ b/lib/librte_eal/include/rte_test.h
> @@ -18,7 +18,7 @@
>   
>   #define RTE_TEST_ASSERT(cond, msg, ...) do {                                  \
>   	if (!(cond)) {                                                        \
> -		RTE_LOG(DEBUG, EAL, "Test assert %s line %d failed: "         \
> +		RTE_LOG(ERR, EAL, "Test assert %s line %d failed: "           \
>   				msg "\n", __func__, __LINE__, ##__VA_ARGS__); \
>   		RTE_TEST_TRACE_FAILURE(__FILE__, __LINE__, __func__);         \
>   		return -1;                                                    \
Acked-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>

-- 
Lukasz Wojciechowski
Principal Software Engineer

Samsung R&D Institute Poland
Samsung Electronics
Office +48 22 377 88 25
l.wojciechow@partner.samsung.com


  parent reply	other threads:[~2020-07-16 15:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200715202024eucas1p2d1ddce75f7e5b1181d7a8f29b50fc4b5@eucas1p2.samsung.com>
2020-07-15 20:20 ` Honnappa Nagarahalli
2020-07-16 13:00   ` Aaron Conole
2020-07-16 18:40     ` Honnappa Nagarahalli
2020-07-16 15:06   ` David Marchand
2020-07-16 18:41     ` Honnappa Nagarahalli
2020-07-16 15:16   ` Lukasz Wojciechowski [this message]
2020-07-16 18:39   ` [dpdk-dev] [PATCH v2] " Honnappa Nagarahalli
2020-07-17  8:54     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a5beb8e-91b6-0c66-4e0f-3238e8655cb7@partner.samsung.com \
    --to=l.wojciechow@partner.samsung.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).