DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: use correct RFC addresses for tx-only
Date: Mon, 27 Jan 2020 16:44:49 +0000
Message-ID: <5a62ff93-78e6-2b14-8888-55c105407b1a@intel.com> (raw)
In-Reply-To: <20200127033458.30275-1-stephen@networkplumber.org>

On 1/27/2020 3:34 AM, Stephen Hemminger wrote:
> The previous patch to change default IP addresses for tx only
> mode got the wrong values (typo).
> 
> Fixes: bf5b2126bf44 ("app/testpmd: add ability to set Tx IP and UDP parameters")
> Cc: stable@dpdk.org
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test-pmd/txonly.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c
> index 871cf6c1547f..4b5bec443b44 100644
> --- a/app/test-pmd/txonly.c
> +++ b/app/test-pmd/txonly.c
> @@ -45,8 +45,8 @@ uint16_t tx_udp_src_port = 9;
>  uint16_t tx_udp_dst_port = 9;
>  
>  /* use RFC5735 / RFC2544 reserved network test addresses */
> -uint32_t tx_ip_src_addr = (192U << 24) | (18 << 16) | (0 << 8) | 1;
> -uint32_t tx_ip_dst_addr = (192U << 24) | (18 << 16) | (0 << 8) | 2;
> +uint32_t tx_ip_src_addr = (198U << 24) | (18 << 16) | (0 << 8) | 1;
> +uint32_t tx_ip_dst_addr = (198U << 24) | (18 << 16) | (0 << 8) | 2;
>  
>  #define IP_DEFTTL  64   /* from RFC 1340. */
>  


I confirm from rfc5735:

198.18.0.0/15 - This block has been allocated for use in benchmark
   tests of network interconnect devices.  [RFC2544] explains that this
   range was assigned to minimize the chance of conflict in case a
   testing device were to be accidentally connected to part of the
   Internet.  Packets with source addresses from this range are not
   meant to be forwarded across the Internet.

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.

      reply	other threads:[~2020-01-27 16:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  3:34 [dpdk-dev] " Stephen Hemminger
2020-01-27 16:44 ` Ferruh Yigit [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a62ff93-78e6-2b14-8888-55c105407b1a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git