DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yu, DapengX" <dapengx.yu@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Iremonger, Bernard" <bernard.iremonger@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release
Date: Fri, 25 Dec 2020 05:09:10 +0000	[thread overview]
Message-ID: <5a697c3c06324bdbbe7b2bef265df4a4@intel.com> (raw)
In-Reply-To: <20201224190317.4bac8b59@hermes.local>

Hi Stephen,

Do you mean this solution?
1. support atexit() in librte_eal, other component can use it to register a function to be called when rte_exit() is called.
2. in librte_cmdline, use atexit() to register a function to release resource 

I am looking forward to more comments from other maintainers, since this solution will modify librte_eal and librte_cmdline, but not just testpmd app.

-----Original Message-----
From: Stephen Hemminger [mailto:stephen@networkplumber.org] 
Sent: Friday, December 25, 2020 11:03 AM
To: Yu, DapengX <dapengx.yu@intel.com>
Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Iremonger, Bernard <bernard.iremonger@intel.com>; dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

On Thu, 24 Dec 2020 11:57:48 +0800
dapengx.yu@intel.com wrote:

> From: YU DAPENG <dapengx.yu@intel.com>
> In interactive mode, if testpmd exit by calling rte_exit without 
> cmdline resource release, terminal will not echo keyboard input. So 
> add code to just show error message, but not exit testpmd when 
> unexpected happens on starting packet forwarding in interactive mode. User can type "quit"
> to exit testpmd later.
> Fixes: 5a8fb55c48ab ("app/testpmd: support unidirectional 
> configuration")
> Cc: stable@dpdk.org
> Signed-off-by: YU DAPENG <dapengx.yu@intel.com>

Sounds like a more generic problem with rte_exit and librte_cmdline.
Would it better to fix it in librte_cmdline by adding an atexit() handler.

  reply	other threads:[~2020-12-25  5:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-24  3:57 dapengx.yu
2020-12-25  3:03 ` Stephen Hemminger
2020-12-25  5:09   ` Yu, DapengX [this message]
2021-01-15  3:28     ` Yu, DapengX
2021-01-15  5:50       ` Xing, Beilei
2021-01-15  6:05         ` Yu, DapengX
2021-01-15  9:21         ` Li, Xiaoyun
2021-01-18 11:47           ` Yu, DapengX
2021-01-25  3:29 ` [dpdk-dev] [PATCH v2] app/testpmd: avoid exit without terminal restore dapengx.yu
2021-01-26  6:33   ` Li, Xiaoyun
2021-01-26  7:13     ` Yu, DapengX
2021-01-26  7:44     ` Yu, DapengX
2021-01-26  8:24       ` Li, Xiaoyun
2021-01-29 10:46         ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a697c3c06324bdbbe7b2bef265df4a4@intel.com \
    --to=dapengx.yu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dev@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=wenzhuo.lu@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).