From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A9C5A04E7; Wed, 4 Nov 2020 09:30:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5971CC83C; Wed, 4 Nov 2020 09:30:00 +0100 (CET) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by dpdk.org (Postfix) with ESMTP id EFD63BE6F; Wed, 4 Nov 2020 02:59:50 +0100 (CET) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CQqbQ1pwlz15Qp0; Wed, 4 Nov 2020 09:59:46 +0800 (CST) Received: from tester.localdomain (10.175.119.39) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 4 Nov 2020 09:59:40 +0800 From: Guoyang Zhou To: CC: , , , , , , , , Date: Wed, 4 Nov 2020 10:03:20 +0800 Message-ID: <5aa52b57f1b950a911dbd4f500d1534725024d38.1604454739.git.zhouguoyang@huawei.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.119.39] X-CFilter-Loop: Reflected X-Mailman-Approved-At: Wed, 04 Nov 2020 09:29:57 +0100 Subject: [dpdk-dev] [PATCH v1 2/2] net/hinic/base: fix log info for PF command channel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When PF command channel is error, the variables in the log has been cleared, which is not printed yet. Fixes: 214164a6bf7f ("net/hinic/base: remove unused function parameters") Cc: stable@dpdk.org Signed-off-by: Guoyang Zhou --- drivers/net/hinic/base/hinic_pmd_mgmt.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c index babb93a..fb31bc8 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.c +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c @@ -614,16 +614,18 @@ static int recv_mgmt_msg_handler(struct hinic_msg_pf_to_mgmt *pf_to_mgmt, u8 *dest_msg; u8 seq_id, seq_len; u32 msg_buf_max = MAX_PF_MGMT_BUF_SIZE; + u8 front_id; seq_id = HINIC_MSG_HEADER_GET(msg_header, SEQID); seq_len = HINIC_MSG_HEADER_GET(msg_header, SEG_LEN); + front_id = recv_msg->sed_id; if (!check_mgmt_seq_id_and_seg_len(recv_msg, seq_id, seq_len)) { PMD_DRV_LOG(ERR, "Mgmt msg sequence and segment check failed, " "func id: 0x%x, front id: 0x%x, current id: 0x%x, seg len: 0x%x", hinic_global_func_id(pf_to_mgmt->hwdev), - recv_msg->sed_id, seq_id, seq_len); + front_id, seq_id, seq_len); return HINIC_ERROR; } -- 1.8.3.1