From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 23381D2C4
 for <dev@dpdk.org>; Thu, 30 Mar 2017 16:06:51 +0200 (CEST)
Received: from fmsmga006.fm.intel.com ([10.253.24.20])
 by fmsmga105.fm.intel.com with ESMTP; 30 Mar 2017 07:06:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.36,246,1486454400"; d="scan'208";a="82726209"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122])
 ([10.237.220.122])
 by fmsmga006.fm.intel.com with ESMTP; 30 Mar 2017 07:06:50 -0700
To: Beilei Xing <beilei.xing@intel.com>, jingjing.wu@intel.com
References: <1490798651-116457-1-git-send-email-beilei.xing@intel.com>
 <1490842311-96705-1-git-send-email-beilei.xing@intel.com>
 <1490842311-96705-3-git-send-email-beilei.xing@intel.com>
Cc: helin.zhang@intel.com, dev@dpdk.org
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <5aaa1fbb-0388-cbe3-3025-027983d31ad6@intel.com>
Date: Thu, 30 Mar 2017 15:06:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.8.0
MIME-Version: 1.0
In-Reply-To: <1490842311-96705-3-git-send-email-beilei.xing@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v8 2/6] net/i40e: add dynamic device
 personalization processing
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 30 Mar 2017 14:06:52 -0000

On 3/30/2017 3:51 AM, Beilei Xing wrote:
> Add support for loading a dynamic device personalization
> profile.
> 
> Signed-off-by: Beilei Xing <beilei.xing@intel.com>

<...>

> +/**
> + * Load/Unload a ddp package
> + *
> + * @param port
> + *    The port identifier of the Ethernet device.
> + * @param buff
> + *    buffer of package.
> + * @param size
> + *    size of buffer.
> + * @param op
> + *   Operation of package processing
> + * @return
> + *   - (0) if successful.
> + *   - (-ENODEV) if *port* invalid.
> + *   - (-EINVAL) if bad parameter.
> + *   - (1) if profile exists.
> + */
> +int rte_pmd_i40e_process_ddp_package(uint8_t port, uint8_t *buff,
> +				     uint32_t size,
> +				     enum rte_pmd_i40e_package_op op);

Doxygen warnings [1] fixed while applying.

[1]
.../net/i40e/rte_pmd_i40e.h:481: warning: Found unknown command `\port'
.../net/i40e/rte_pmd_i40e.h:482: warning: Found unknown command `\buff'
.../net/i40e/rte_pmd_i40e.h:483: warning: Found unknown command `\size'