From: Ferruh Yigit <ferruh.yigit@intel.com> To: Xiaoyun wang <cloud.wangxiaoyun@huawei.com>, dev@dpdk.org Cc: bluca@debian.org, luoxianjun@huawei.com, luoxingyu@huawei.com, zhouguoyang@huawei.com, yin.yinshi@huawei.com, david.yangxiaoliang@huawei.com, zhaohui8@huawei.com, zhengjingzhou@huawei.com Subject: Re: [dpdk-dev] [PATCH v1 5/5] net/hinic/base: modify return errors Date: Tue, 7 Jul 2020 20:42:08 +0100 Message-ID: <5aad84e2-b14d-c6da-0716-2452db54ad1f@intel.com> (raw) In-Reply-To: <fe8c40d266837ffc8a145afc476115c89ad167a1.1593228634.git.cloud.wangxiaoyun@huawei.com> On 6/27/2020 4:55 AM, Xiaoyun wang wrote: > Modify return errors with linux system errors when > system requests fail. > > Signed-off-by: Xiaoyun wang <cloud.wangxiaoyun@huawei.com> <...> > @@ -475,7 +475,7 @@ static int wait_for_flr_finish(struct hinic_hwif *hwif) > rte_delay_ms(10); > } while (time_before(jiffies, end)); > > - return -EFAULT; > + return -ETIME; > } Hi Xiaoyun, 'ETIME' is not defined in FreeBSD and was causing build error [1]. I have reverted the 'ETIME' changes in this patch (3 occurances) back. Can you please do an incremental patch if 'EFAULT' errors needs to be replaced? Thanks, ferruh [1] http://mails.dpdk.org/archives/test-report/2020-July/142068.html
next prev parent reply other threads:[~2020-07-07 19:42 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-27 3:55 [dpdk-dev] [PATCH v1 0/5] fix promisc and tcam problem Xiaoyun wang 2020-06-27 3:55 ` [dpdk-dev] [PATCH v1 1/5] net/hinic/base: add out parameter for mgmt sync channel Xiaoyun wang 2020-06-27 3:55 ` [dpdk-dev] [PATCH v1 2/5] net/hinic/base: remove unused parameter Xiaoyun wang 2020-06-27 3:55 ` [dpdk-dev] [PATCH v1 3/5] net/hinic: fix setting promiscuous mode problem Xiaoyun wang 2020-06-27 3:55 ` [dpdk-dev] [PATCH v1 4/5] net/hinic: add tcam filter switch for FDIR Xiaoyun wang 2020-06-27 3:55 ` [dpdk-dev] [PATCH v1 5/5] net/hinic/base: modify return errors Xiaoyun wang 2020-07-07 19:42 ` Ferruh Yigit [this message] 2020-07-03 16:22 ` [dpdk-dev] [PATCH v1 0/5] fix promisc and tcam problem Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5aad84e2-b14d-c6da-0716-2452db54ad1f@intel.com \ --to=ferruh.yigit@intel.com \ --cc=bluca@debian.org \ --cc=cloud.wangxiaoyun@huawei.com \ --cc=david.yangxiaoliang@huawei.com \ --cc=dev@dpdk.org \ --cc=luoxianjun@huawei.com \ --cc=luoxingyu@huawei.com \ --cc=yin.yinshi@huawei.com \ --cc=zhaohui8@huawei.com \ --cc=zhengjingzhou@huawei.com \ --cc=zhouguoyang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git