From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BBE745B03; Thu, 10 Oct 2024 13:19:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC7874029C; Thu, 10 Oct 2024 13:19:47 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 5BEAE40279 for ; Thu, 10 Oct 2024 13:19:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1728559186; x=1760095186; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=ITha63yUmEvUH5/+yMdG7jRx3GDaY4mKqRXYuDarMvE=; b=GPDJtmERAwi9XbDVNLfKG9lvDqlZiwWFMNgI2TI6x1IdwH6HePvi4nd7 JtmrWo2uy2rdMwveJ8hiepLZdUUvELDl40Q/tNGFx/7gJbAR48CrP1iN7 NA86nqf9aOAceb6b1zDbJkVH4y0lRbiwDJS14l8JepvvLcKWVGmOJM3aM +Hcm6/9gNURB/uU/lR68yFrOZC4FNY0gO+6uxrUDeaKSrh2hTLmvhlOiW ETLyVpjb0M/dp99hkswA6KsutrJHwwnII3/jP9ieX6wne8EnfJ/HvCVac 92qQ2HJB3yI693cFpkC6Q8JcDNnPYTAaTYCnJX//u5LxgCW0/8Mo6L0Ru g==; X-CSE-ConnectionGUID: ZSxylT/6R02W0ZXy9BMHGQ== X-CSE-MsgGUID: XSFZYmBSS4utvadoHwzLIQ== X-IronPort-AV: E=McAfee;i="6700,10204,11220"; a="27995751" X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="27995751" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Oct 2024 04:19:45 -0700 X-CSE-ConnectionGUID: BpxQNu/ZSMOhLxYculYZQw== X-CSE-MsgGUID: Z6hMGyoUSYmOXU/SjfWBKw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,192,1725346800"; d="scan'208";a="81563102" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orviesa004.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Oct 2024 04:19:46 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 04:19:44 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Thu, 10 Oct 2024 04:19:44 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Thu, 10 Oct 2024 04:19:44 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 10 Oct 2024 04:19:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vAxHILh8FHkezB77AIYt0+oMb2kylimAh/VBQ7ThRYmK2vy6BdUHKnjiEGtvoz5PrYJGq/U36i9Q6cngYvLYEC7KLhRgZdowtBQvnRbVa4KT/jnDDNKzljNVzpwuI0Ze4ooJQVzaDC4jk7GNnc2FljWfmF/IFsIynoObVdN72CPzt2pliU8iPENokHw4+JYjCLsbtHI61aLiXQ1WRUGmzyjWdv3NPUKNIbeopquCVz/vVAlOcwaO5u+3I5Y52vk0cc0PkNPxH8nojxTR+9kinhz9zvSo1g1yYjA1cys2lAhuAxOGNypApr1MF+3wzQPt+8vgidg6rM8dSzFf+F8EzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tVguVl/Fzv2ubldqKvtVTjixI0uPWZHtWz6OMNU5e7c=; b=icrHMJX5FaVrhpeFPRUF4LO6EXaMFyJ81GEOpHAPxINsppaIqmpZ7xz8PF/335fBEzGYJ+p72ktdNgI593lhFs9Zsk6WFwrYxOLRQffYpwf5z9eOyMGEh48pUsF8lT9Xp3vujYKHMVuWRm+d4gmeDOnVhVd0XoGYkHVYaxtDUKnqw5MkRrPG/4LumGrJ2DH0fkYMa01FqyqvlcSXcXPw9EEN8sbCwkj2eDxBCul19q80LoSt76LMEp9+G0tHh+1AN8EcducblLKkW9x9Zf+KJUtUKG1TgELnmDJIbVB3SRUPnT60nfWNI1ehimlLmMqb1vtRYzyj3z3DoN5kbBFfww== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH7PR11MB5765.namprd11.prod.outlook.com (2603:10b6:510:139::7) by CYYPR11MB8432.namprd11.prod.outlook.com (2603:10b6:930:be::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.24; Thu, 10 Oct 2024 11:19:36 +0000 Received: from PH7PR11MB5765.namprd11.prod.outlook.com ([fe80::fcf5:d65c:4fdd:4a2a]) by PH7PR11MB5765.namprd11.prod.outlook.com ([fe80::fcf5:d65c:4fdd:4a2a%3]) with mapi id 15.20.8005.026; Thu, 10 Oct 2024 11:19:36 +0000 Message-ID: <5aae76fd-ac22-4ed0-9728-e898e8295517@intel.com> Date: Thu, 10 Oct 2024 12:19:32 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] fib: network byte order IPv4 lookup To: David Marchand CC: , , , "Stephen Hemminger" References: <20241008171605.378069-1-vladimir.medvedkin@intel.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DU7P250CA0012.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:54f::25) To PH7PR11MB5765.namprd11.prod.outlook.com (2603:10b6:510:139::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH7PR11MB5765:EE_|CYYPR11MB8432:EE_ X-MS-Office365-Filtering-Correlation-Id: dd41bc1a-5f5a-44e6-86c7-08dce91d6c28 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Sk50TUtiYnZLd0hXRk82KzdmcHFKUEpzUzI0cllpSHNGUWd2dTZ2WC9ySFlu?= =?utf-8?B?ZE1LazQ5VVMzaElYdlhFNmlJeEcwcnpPMFV3R2txZTJOQ05WanFySFk3VitV?= =?utf-8?B?eUU4dzJGb29FdGRvSmZ0M3lSQnBYeVRiWS80SVM5LzI3bWtGRXlEQ3FzdE1O?= =?utf-8?B?WngySEt4TTFYc1VXeFA0bGgrNzRVL0JoQ3o4MERFbnVkWE5JZFdnOGlhWk9E?= =?utf-8?B?MGM1aDNJNUMxby80aE5sUG4xYjFlMXVodElhYzM5NzNuVXBuV0ZNTW5GTllM?= =?utf-8?B?M0luMEZGd1lSZUIrS0QyMUE4RVlYZ2w0WjBCa3JTengya3FxTjdjNjNqMVJ2?= =?utf-8?B?Y2NSRk5VWkcxNStsZ1d3UkxOMDBsRWVIZHRKbHY3dENCRWNSWWJ6UEh1ajFp?= =?utf-8?B?RlYxeXhPTlJxM1VkZmZMM3hNeFFOclZZeUdUbTM0cEJIMHlRbVZMM2V2bUxX?= =?utf-8?B?ZGQvRGRheWJjWk8xL2htYytiZHkrRWtDRUhvckhGQm1kZ1RHYWtCZmpXaWU2?= =?utf-8?B?WjdlYURUaW12dnAyc1ZwZ1B2R2dUZlFuZWs3OFRNRlk0azgxSFpOMWhvc212?= =?utf-8?B?Um00SHI5dUlGV0dDTXdER2crMm9aY1hvenZBc1U3WkorZ3UwY2o2NWpKS3pX?= =?utf-8?B?QUgrcXpOZmJEU2k2RGI3QXFZb1N6V1FoeEI3TTJ0OTdSQUs0WXhnZExhUHBu?= =?utf-8?B?NDB1REdRbGVtMm9ZY091SFJYamdRaERUVFJvYWFyY215UzFJMkZpYXBSaUJy?= =?utf-8?B?SVJsV0xqc3UveXdjR0phTzBtQUQ2WWY4VFROWk04ZUFabVFOcW1kMUlpZDNt?= =?utf-8?B?am1Xb2Nib0FqOU8rQzN0Q2U2VXl4M2hKNGN5Tkl6cmpkTkJ2djdTbW9NL2Vz?= =?utf-8?B?WU9ITm5qV20wbW02ZFVZQmxGV0w5M2t4R1hnNnRnbHVCRDNJVVNMK3FCdXlt?= =?utf-8?B?SGgxaDh0eExNQW5oRmxQMXA0Q0hnSjZuYmVMU3JLOHAwWmk3dkVIS3VOWTg2?= =?utf-8?B?TFl2OGdJQTN1RlgvaFdwU1AwdFY2R05XRThMTjI4R0gwVlN2YS9kMWFPeVdi?= =?utf-8?B?NGg5a3V4UDNNQ2FvcDlhdi8rSWlFTUp3TytJMmNNZk1kcUw2NDhRR1JMaXR0?= =?utf-8?B?dEFtcnhXazA3b3RiM29HL2duWENXQWZLdVBONHJycS9yMERyY0R0dnZzaDRO?= =?utf-8?B?M3EvWW04ZUlVMnFtZUpEbWdkSGVWdmd6MW56UEtLYXVnSWxacDBOaVNjTDdl?= =?utf-8?B?NU5hMTlKanYxSTF6TEdoSzdYVXJaVWxiSHVaUWdjZC90cFdjNTE1OUhtMkdo?= =?utf-8?B?dnZEamFNcTV1U1dDNXBDK3dCK1JacWkyNVhPN3hWUkp1YmdhNlMyNUptZ2dY?= =?utf-8?B?cjZXN2F6c0lTVWF4THJGSlNOTDJOSmhBZHdGbE9mUlBvR1FFUnJuSVYwVlhs?= =?utf-8?B?d1lYa0loRmIxTVVBUVdFbGw0a05OdWQrOTFTNExtaWM2WHlsdGRObFozMlNH?= =?utf-8?B?RjhEWm5jTmx0ZmZWVXRHbzJxNElQcXJDNmlGcUdxcmRlK3RaMCtjZk5pWDY5?= =?utf-8?B?bHJaT3drcEEvY1RTRnVKTDdpYXEweCtWbGUwY1RnRm55NWxHbU42V3IyRkNH?= =?utf-8?B?U3BCZ0Vqcm5QRSsxMDBJMnNVVlFTNGl6NkV1bFFaWHV2dnFISmFSVnFjSU81?= =?utf-8?B?b3RYUWR3KzBZOC9OVGFsMXdlYjM3NElRZ3ZSaExjdDI3SUxpTmZWWHRBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH7PR11MB5765.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YjkxNXpRekJoNGI3d1ZNV0Iva0tVSm9hMmlWbnowTXA5Zy8zQlR0NWVDY3Z5?= =?utf-8?B?Vjd6ZTdBMVNML3huYzRZcldaZmRJdTVlZ3dqWjZBNVhoalNOalJuRTVNOHEz?= =?utf-8?B?d3g2NTAyaFpzQUpsOGxxSnYwTXlvU1Z5VllUZzV6bVkxQzJKN2JwK1FhQlFU?= =?utf-8?B?elFpK3RoaG5QSWI3ODFvVGtSQXUvU1dVMjIrV2ZGSkZDSHIrbmd1K1doRlpp?= =?utf-8?B?YVE4bEFWanJFWHR3ME1BZjltWThOd1FadlZ1dk5jRGRGQVB2cFdWdTgxVDQ4?= =?utf-8?B?TFBybklCcmtVWG5QV3dsNUxJbFZVaVMzZTYzUU9Kb1RxQjRVL254VEpFSlAx?= =?utf-8?B?WWZ0VWl5WDR1ZmlrTVlpRWMrNDd2YWF2cFgvc1o0QWNhRlBwa3ZwRjBTSlkw?= =?utf-8?B?OXBYUmRXUmxBM3RZSlRtRHNERUtMOUlER3Z4SFkwa2ZaRjRzZmo2TGphRy9n?= =?utf-8?B?WFJrU2xCWEdjMFVKVjlGRkNLTW1GMXRMU2E2YWYwdmxKNHJkWkJUY1NIazJU?= =?utf-8?B?RnF2Z0cyYnVPdVZWbEFicmJLUHhkU092MHYzOXZNbGJRM2ozV0VYQ3dOdVMr?= =?utf-8?B?cWYra0tTVUJXcWQ1QVNkdDNQQzMzZWtEWVpsNkdBRU5VcSs2YjVabkFmdFM3?= =?utf-8?B?N0lLRE9IUW1pRVkxcVZrUmtPM08zUC9VR1VRK1Z5WGJVZXNpUVYzQ1IzbitO?= =?utf-8?B?aXZJd1k4SGhNaWZaR3lpVVBkelViallVaW5xdjQ5MHV6N3QvWkpWMmlLUWhH?= =?utf-8?B?cFZoQyttSUpMOC9GdGJ0dVhNUTFZOFhobzJVQkdybThpWnVoOWdRUDRmL0lW?= =?utf-8?B?djJHMk51QWlTQ0FmTEZUbHcxNlFMZFhQclF0cGRiZHB5TzFTcmpoaG85a2hO?= =?utf-8?B?ODJXYXRrdkw0YjFFZnBvdVlDRVowaXRZbXpMSGVhNVQ0Q1hzcVM1bTRJUWhR?= =?utf-8?B?S2puVHFVU1lGVG8rNDNvNzliZU8vemJjQ2lVOXVBZUZtaU83dzN2ejlXdEp3?= =?utf-8?B?aFpKVFZYb1ZiVjJRczk2R3YrREhFVTRZbXoxTDc5dk0vc0dzYzV4bERTUlNm?= =?utf-8?B?NW9ldE9pMTJKVndlU0lJT1ZGenlZV1FvYXJiT1ZoTkVNNjlPVmF6RWRmRmpr?= =?utf-8?B?UHB2NkdKa29SWWZxV0pKRnZDS3VKYTJNVlRINFNiUFpKSllsaVk2RC93T1Zq?= =?utf-8?B?Y3VseEdTSGQ5bzVBdElQL09oUmpHTlhmQ1RmaGFwOGR5RGY3Y2hJRkxpYVNt?= =?utf-8?B?bXJ2K0NJQ1RVYjFmN0M4YU4xR1g2dW14b1AwcVMrcTBPN0JzaCt3RWlmTUhj?= =?utf-8?B?QldyeFcyT0lhQlhwQ1Bpdnl3cGtZS3RxSWJJMCs0M203K2Q5VjF3cHNOeGJP?= =?utf-8?B?Zm5GS0xzcWFzblJIS01zaUZKRDhpdGViL0RrOG9SSTJaY3dXQ1FaOGREZjFo?= =?utf-8?B?Vk5BMlJicWlGa0xIbllxNzNyeWcwOFlZeWdMNTFvb1VlU0ZRQkFiSUhWdjh3?= =?utf-8?B?RVFWWkY2S2k4WnMrTDB5UkpOTEJIekdNRVFPcnZMOG5qVnBMQzN4MGRFWUkz?= =?utf-8?B?ZW5ubDlIMm9lcUVTZWRVTHVialpLcmo1K1Y5UVk2MXg3dVl3eDE3MzlrbHpH?= =?utf-8?B?UEJHWGdJQktqV0s3MlplemhkWFVwV0RURTExQ3VWUFJUNXZtM2hMY0h5WjhO?= =?utf-8?B?bE83RzlydTl2ckNTYmtVZis0a2ljTEIwd3R4NUVOWkdvOWMxVGkvN1BjdGhE?= =?utf-8?B?UExVd1I0UGN2WXgrRW9ubDh0QlBLU2VDcy95TUhBRllGRUl2dHJ1S1czcVhm?= =?utf-8?B?dkZhM1gzQ2h2WlRtUUUxdDZFSlArUXZiTFFzUUNuVGpCM1hsQW0zdlhKSjhX?= =?utf-8?B?V084UTluMkg2YkNZL203b2p3enRnckM5cmRnbHBNdlZQeTB3Q0ZsMkpYNXhQ?= =?utf-8?B?TGw4dUFMckQvbXRJaEk0SVpZaitidWJBcWhGTGlQcmZRaUxvQzd3RVoxZFRD?= =?utf-8?B?UXMvdFdEckxVRVU1bVlxZDk2amdlam0wVmYzazB1dUlpTjRqK0xSTUtxYUJM?= =?utf-8?B?Mm5XSTZwZzl4djRLQktUQTFkSHpIWU44Z05vQ0o4eFAvU2ZVVzZ3NGUrU1lG?= =?utf-8?B?WUlVZC9wTldGTkcrcGdSYnFZM05qSDhnME5YZTErSzFIbHBZWEFuVEJXS3g1?= =?utf-8?B?UGc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: dd41bc1a-5f5a-44e6-86c7-08dce91d6c28 X-MS-Exchange-CrossTenant-AuthSource: PH7PR11MB5765.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Oct 2024 11:19:36.0171 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ue/7hS4scXtFQ01Wi3HpZSOAe+Y33uYBkppVYD4Uga5WQNRjNqCppcUP9WOeww7OWH9ip7QewZMB/RY4SOW6kWg+V7P9QNwD2qO8Wk2xYr0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR11MB8432 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, On 09/10/2024 11:56, David Marchand wrote: > On Wed, Oct 9, 2024 at 11:51 AM David Marchand > wrote: >> Hi Vladimir, >> >> On Tue, Oct 8, 2024 at 7:16 PM Vladimir Medvedkin >> wrote: >>> diff --git a/lib/fib/dir24_8_avx512.c b/lib/fib/dir24_8_avx512.c >>> index 43dba28cfb..edd802abe4 100644 >>> --- a/lib/fib/dir24_8_avx512.c >>> +++ b/lib/fib/dir24_8_avx512.c >>> @@ -10,7 +10,7 @@ >>> >>> static __rte_always_inline void >>> dir24_8_vec_lookup_x16(void *p, const uint32_t *ips, >>> - uint64_t *next_hops, int size) >>> + uint64_t *next_hops, int size, bool be_addr) >>> { >>> struct dir24_8_tbl *dp = (struct dir24_8_tbl *)p; >>> __mmask16 msk_ext; >>> @@ -28,6 +28,16 @@ dir24_8_vec_lookup_x16(void *p, const uint32_t *ips, >>> res_msk = _mm512_set1_epi32(UINT16_MAX); >>> >>> ip_vec = _mm512_loadu_si512(ips); >>> + if (be_addr) { >>> + const __m512i bswap32 = _mm512_set_epi8( >> Some toolchains do not like _mm512_set_epi8 (reported by the CI). > Probably related to gcc commit 4e6a811fad69 ("avx512fintrin.h > (_mm512_set_epi16, [...]): New intrinsics.") introduced in gcc 9. > Some distributions in the CI come with a gcc < 9. > > We had a similar situation in the hash library in the past, > fba335b4b204 ("hash: fix Toeplitz hash implementation"). > Thanks, I'll change it with _mm512_set_epi32(), afaik it should be supported by an old gcc -- Regards, Vladimir