From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 619EA5F2E; Fri, 1 Jun 2018 17:06:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Jun 2018 08:06:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,467,1520924400"; d="scan'208";a="60460390" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.101]) ([10.237.220.101]) by fmsmga001.fm.intel.com with ESMTP; 01 Jun 2018 08:06:51 -0700 To: Dariusz Stojaczyk , dev@dpdk.org Cc: stable@dpdk.org References: <1527860361-162114-1-git-send-email-dariuszx.stojaczyk@intel.com> <1527857960-109306-1-git-send-email-dariuszx.stojaczyk@intel.com> From: "Burakov, Anatoly" Message-ID: <5ab83fb6-47d0-d8ca-9efe-b6ac93f3217f@intel.com> Date: Fri, 1 Jun 2018 16:06:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1527857960-109306-1-git-send-email-dariuszx.stojaczyk@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 1/2] memalloc: do not leave unmapped holes in EAL virtual memory area X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:06:55 -0000 On 01-Jun-18 1:59 PM, Dariusz Stojaczyk wrote: > EAL reserves a huge area in virtual address space > to provide virtual address contiguity for e.g. > future memory extensions (memory hotplug). During > memory hotplug, if the hugepage mmap succeeds but > doesn't suffice EAL's requiriments, the EAL would > unmap this mapping straight away, leaving a hole in > its virtual memory area and making it available > to everyone. As EAL still thinks it owns the entire > region, it may try to mmap it later with MAP_FIXED, > possibly overriding a user's mapping that was made > in the meantime. > > This patch ensures each hole is mapped back by EAL, > so that it won't be available to anyone else. > > Changes from v2: > * replaced rte_panic() with a CRIT log. > * added "git fixline" tags > > Changes from v1: > * checkpatch fixes > > Fixes: 582bed1e1d1d ("mem: support mapping hugepages at runtime") > Cc: anatoly.burakov@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Dariusz Stojaczyk > --- Acked-by: Anatoly Burakov Thomas, could you please fix the commit message on apply? -- Thanks, Anatoly