* [dpdk-dev] [PATCH] doc: update features for hns3
@ 2020-11-23 14:32 Lijun Ou
2020-11-23 16:41 ` Ferruh Yigit
2020-11-24 13:56 ` [dpdk-dev] [PATCH v2] " Lijun Ou
0 siblings, 2 replies; 6+ messages in thread
From: Lijun Ou @ 2020-11-23 14:32 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, linuxarm
Since the hns3 NIC hardware features are not counted
and it is supported in fact. Besides, the flow director
is not supported and need to delete it.
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
doc/guides/nics/features/hns3.ini | 8 ++++++++
doc/guides/nics/hns3.rst | 3 ++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index fc61dde..f897a14 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -7,8 +7,12 @@
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
+Runtime Rx queue setup = Y
+Runtime Tx queue setup = Y
+Burst mode info = Y
MTU update = Y
Jumbo frame = Y
+Fast mbuf free = Y
Scattered Rx = Y
TSO = Y
LRO = Y
@@ -20,19 +24,23 @@ RSS hash = Y
RSS key update = Y
RSS reta update = Y
DCB = Y
+SR-IOV = Y
VLAN filter = Y
Flow control = Y
Flow API = Y
CRC offload = Y
VLAN offload = Y
+QinQ offload = P
L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
Inner L4 checksum = Y
+Packet type parsing = Y
Basic stats = Y
Extended stats = Y
Stats per queue = Y
FW version = Y
+Registers dump = Y
Multiprocess aware = Y
Linux UIO = Y
Linux VFIO = Y
diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index cc0a8e4..8db8867 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -29,13 +29,14 @@ Features of the HNS3 PMD are:
- QinQ inserting
- DCB
- Scattered and gather for TX and RX
-- Flow director
+- Vector Poll mode driver
- Dump register
- SR-IOV VF
- Multi-process
- MAC/VLAN filter
- MTU update
- NUMA support
+- Generic flow API
Prerequisites
-------------
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update features for hns3
2020-11-23 14:32 [dpdk-dev] [PATCH] doc: update features for hns3 Lijun Ou
@ 2020-11-23 16:41 ` Ferruh Yigit
2020-11-24 1:47 ` oulijun
2020-11-24 13:56 ` [dpdk-dev] [PATCH v2] " Lijun Ou
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-11-23 16:41 UTC (permalink / raw)
To: Lijun Ou; +Cc: dev, linuxarm
On 11/23/2020 2:32 PM, Lijun Ou wrote:
> Since the hns3 NIC hardware features are not counted
> and it is supported in fact. Besides, the flow director
> is not supported and need to delete it.
>
Hi Lijun,
Normally these should be updated when the feature is added but it seems we have
missed them.
Can you please add the commits that introduces the features as "Fixes: " line,
to have them as reference?
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> doc/guides/nics/features/hns3.ini | 8 ++++++++
> doc/guides/nics/hns3.rst | 3 ++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
> index fc61dde..f897a14 100644
> --- a/doc/guides/nics/features/hns3.ini
> +++ b/doc/guides/nics/features/hns3.ini
> @@ -7,8 +7,12 @@
> Link status = Y
> Rx interrupt = Y
> Queue start/stop = Y
> +Runtime Rx queue setup = Y
> +Runtime Tx queue setup = Y
> +Burst mode info = Y
> MTU update = Y
> Jumbo frame = Y
> +Fast mbuf free = Y
> Scattered Rx = Y
> TSO = Y
> LRO = Y
> @@ -20,19 +24,23 @@ RSS hash = Y
> RSS key update = Y
> RSS reta update = Y
> DCB = Y
> +SR-IOV = Y
> VLAN filter = Y
> Flow control = Y
> Flow API = Y
> CRC offload = Y
> VLAN offload = Y
> +QinQ offload = P
Is "QinQ offload" supported? I don't see the driver setting neither
'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags.
Can you please describe in the commit log why it is supported partially (P)?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update features for hns3
2020-11-23 16:41 ` Ferruh Yigit
@ 2020-11-24 1:47 ` oulijun
0 siblings, 0 replies; 6+ messages in thread
From: oulijun @ 2020-11-24 1:47 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, linuxarm
在 2020/11/24 0:41, Ferruh Yigit 写道:
> On 11/23/2020 2:32 PM, Lijun Ou wrote:
>> Since the hns3 NIC hardware features are not counted
>> and it is supported in fact. Besides, the flow director
>> is not supported and need to delete it.
>>
>
> Hi Lijun,
>
> Normally these should be updated when the feature is added but it seems
> we have missed them.
>
Yes. Maybe it is ignoranted. As a result，it needs to add.
> Can you please add the commits that introduces the features as "Fixes: "
> line, to have them as reference?
>
Yes, I can. I will add it in next patch.
>> Signed-off-by: Lijun Ou <oulijun@huawei.com>
>> ---
>> doc/guides/nics/features/hns3.ini | 8 ++++++++
>> doc/guides/nics/hns3.rst | 3 ++-
>> 2 files changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/doc/guides/nics/features/hns3.ini
>> b/doc/guides/nics/features/hns3.ini
>> index fc61dde..f897a14 100644
>> --- a/doc/guides/nics/features/hns3.ini
>> +++ b/doc/guides/nics/features/hns3.ini
>> @@ -7,8 +7,12 @@
>> Link status = Y
>> Rx interrupt = Y
>> Queue start/stop = Y
>> +Runtime Rx queue setup = Y
>> +Runtime Tx queue setup = Y
>> +Burst mode info = Y
>> MTU update = Y
>> Jumbo frame = Y
>> +Fast mbuf free = Y
>> Scattered Rx = Y
>> TSO = Y
>> LRO = Y
>> @@ -20,19 +24,23 @@ RSS hash = Y
>> RSS key update = Y
>> RSS reta update = Y
>> DCB = Y
>> +SR-IOV = Y
>> VLAN filter = Y
>> Flow control = Y
>> Flow API = Y
>> CRC offload = Y
>> VLAN offload = Y
>> +QinQ offload = P
>
> Is "QinQ offload" supported? I don't see the driver setting neither
> 'PKT_RX_QINQ_STRIPPED' nor 'PKT_RX_QINQ' to mbuf.ol_flags.
> Can you please describe in the commit log why it is supported partially
> (P)?
> .
Sorry. hns3 support to QinQ insert in the Tx direction and the QinQ
stripped in Rx direction is not supported. QinQ offloading is considered
as the former. I will fix it.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] doc: update features for hns3
2020-11-23 14:32 [dpdk-dev] [PATCH] doc: update features for hns3 Lijun Ou
2020-11-23 16:41 ` Ferruh Yigit
@ 2020-11-24 13:56 ` Lijun Ou
2020-11-24 16:31 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Lijun Ou @ 2020-11-24 13:56 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, linuxarm
Since the hns3 NIC hardware features are not counted
and it is supported in fact. Besides, the flow director
is not supported and need to delete it.
Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
Fixes: 521ab3e93361 ("net/hns3: add simple Rx path")
Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
Fixes: 936eda25e8da ("net/hns3: support dump register")
Fixes: 53b9f2b9a560 ("doc: update feature list in hns3 guide")
Cc: stable@dpdk.org
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V1->V2:
- delete the wrong counter for QinQ offload
- delete the SR-IOV features
- add hns3_vf.ini updates
---
doc/guides/nics/features/hns3.ini | 5 +++++
doc/guides/nics/features/hns3_vf.ini | 5 +++++
doc/guides/nics/hns3.rst | 3 ++-
3 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/doc/guides/nics/features/hns3.ini b/doc/guides/nics/features/hns3.ini
index fc61dde..f0747e3 100644
--- a/doc/guides/nics/features/hns3.ini
+++ b/doc/guides/nics/features/hns3.ini
@@ -7,6 +7,9 @@
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
+Runtime Rx queue setup = Y
+Runtime Tx queue setup = Y
+Burst mode info = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -29,10 +32,12 @@ L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
Inner L4 checksum = Y
+Packet type parsing = Y
Basic stats = Y
Extended stats = Y
Stats per queue = Y
FW version = Y
+Registers dump = Y
Multiprocess aware = Y
Linux UIO = Y
Linux VFIO = Y
diff --git a/doc/guides/nics/features/hns3_vf.ini b/doc/guides/nics/features/hns3_vf.ini
index b7a383c..3128b63 100644
--- a/doc/guides/nics/features/hns3_vf.ini
+++ b/doc/guides/nics/features/hns3_vf.ini
@@ -7,6 +7,9 @@
Link status = Y
Rx interrupt = Y
Queue start/stop = Y
+Runtime Rx queue setup = Y
+Runtime Tx queue setup = Y
+Burst mode info = Y
MTU update = Y
Jumbo frame = Y
Scattered Rx = Y
@@ -27,9 +30,11 @@ L3 checksum offload = Y
L4 checksum offload = Y
Inner L3 checksum = Y
Inner L4 checksum = Y
+Packet type parsing = Y
Basic stats = Y
Extended stats = Y
Stats per queue = Y
+Registers dump = Y
Multiprocess aware = Y
Linux UIO = Y
Linux VFIO = Y
diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index cc0a8e4..8db8867 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -29,13 +29,14 @@ Features of the HNS3 PMD are:
- QinQ inserting
- DCB
- Scattered and gather for TX and RX
-- Flow director
+- Vector Poll mode driver
- Dump register
- SR-IOV VF
- Multi-process
- MAC/VLAN filter
- MTU update
- NUMA support
+- Generic flow API
Prerequisites
-------------
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: update features for hns3
2020-11-24 13:56 ` [dpdk-dev] [PATCH v2] " Lijun Ou
@ 2020-11-24 16:31 ` Ferruh Yigit
2020-11-26 16:58 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2020-11-24 16:31 UTC (permalink / raw)
To: Lijun Ou; +Cc: dev, linuxarm
On 11/24/2020 1:56 PM, Lijun Ou wrote:
> Since the hns3 NIC hardware features are not counted
> and it is supported in fact. Besides, the flow director
> is not supported and need to delete it.
>
> Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
> Fixes: 521ab3e93361 ("net/hns3: add simple Rx path")
> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
> Fixes: 936eda25e8da ("net/hns3: support dump register")
> Fixes: 53b9f2b9a560 ("doc: update feature list in hns3 guide")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: update features for hns3
2020-11-24 16:31 ` Ferruh Yigit
@ 2020-11-26 16:58 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2020-11-26 16:58 UTC (permalink / raw)
To: Lijun Ou; +Cc: dev, linuxarm, Ferruh Yigit
24/11/2020 17:31, Ferruh Yigit:
> On 11/24/2020 1:56 PM, Lijun Ou wrote:
> > Since the hns3 NIC hardware features are not counted
> > and it is supported in fact. Besides, the flow director
> > is not supported and need to delete it.
> >
> > Fixes: fa29fe45a7b4 ("net/hns3: support queue start and stop")
> > Fixes: 521ab3e93361 ("net/hns3: add simple Rx path")
> > Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
> > Fixes: 936eda25e8da ("net/hns3: support dump register")
> > Fixes: 53b9f2b9a560 ("doc: update feature list in hns3 guide")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Lijun Ou <oulijun@huawei.com>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-26 16:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-23 14:32 [dpdk-dev] [PATCH] doc: update features for hns3 Lijun Ou
2020-11-23 16:41 ` Ferruh Yigit
2020-11-24 1:47 ` oulijun
2020-11-24 13:56 ` [dpdk-dev] [PATCH v2] " Lijun Ou
2020-11-24 16:31 ` Ferruh Yigit
2020-11-26 16:58 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).