From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C4B6A00C3; Tue, 14 Dec 2021 11:13:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17EF140041; Tue, 14 Dec 2021 11:13:56 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 4C3324003C; Tue, 14 Dec 2021 11:13:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1639476833; x=1671012833; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=1qkQ+9zCqZu9PxDNt+Rewhec9t5PgeHNJkgX4yz/wrk=; b=Yg6nC6Hbfmx01JHNjazptyxMtnuOa6ivErHWIZJwPAlhQb3aqPIH3k8/ hMfelJCe+4+CGsH06a/s3ZfY+44VgeuU6/bLkyjtSsU9s9xdhKHtDuIJo KBqxtif9rE6nJhqjr4OAFcEjpXAC+Ds9LcYpp35SD2Ujsu4odxfZYOkhl b/GBkp22a322MrV4j00wcxqSyaFNSwDvK/kAeiqwzAThO8D0sDAAd3yrn i+gU5VS8b91E6bFqa+IfIYePkth67cUNUAvgUQafOaVXQKTiJvG3pKGLG LZntUJKrNbYGMmTOU9A8ju2lXHD+uDNC9JKz/5To9ISr9+iXzkQyO4A0n g==; X-IronPort-AV: E=McAfee;i="6200,9189,10197"; a="263085253" X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="263085253" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2021 02:13:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,205,1635231600"; d="scan'208";a="519179877" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga007.fm.intel.com with ESMTP; 14 Dec 2021 02:13:51 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 14 Dec 2021 02:13:50 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 14 Dec 2021 02:13:50 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 14 Dec 2021 02:13:50 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RK7UN5vx8GoSBzPNCmRkBJs5VFtTyViQgXdn0SWLJx7yocIRLNqVcsyLGhIAnj60C8IvT95sj457wZiztVlh+heVZvLCKj/RrOnXMZh2xQ51wN6ru/LjRLPeYOouX0yAGd3u9R4Fg5XQyb8KU5VqBUrdDxCrpKHgnyO7jBGGuv1X2iGhM+UmDNLi2LSQO3FetejP8h/pT9hhXZjJcNMDSBeL7YR8qiHHpequgNcbAjd+g3Jv9zfU4tyJPmsGbkjeyWGcvSVHpmR3LoCwzzPS3pBgHzYQ69UCVHoSdWCCpLa2O3phdYqqrPBBpftoWyvACvPvyOZ/304eyLolXt2/Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EIRALVcZWWDOQtsSl2VqUuk7I7q+4FoR1MMIiccev8Y=; b=PpPhR2PGnefNExaCTqgGyS0c+RWQYVlMm8nEheDbi0+G/d4ec/8MPPi+qNKiyNIR4G0ZEBGGgeI9/6HaFCPmCinFFxjShVRpglbT/Byn8BD6IcXTBk/cpzQ8gnDp2cEH1o0R8FlugKARpTsqIeHySCoo+zKGvy/DFnRsg6gIZeHkoaSnmQRG2E+a29+Aw92naIug1Z+ErqDTe7GOHRF4h1qLvD+Ul36+TK29NqvuF67xLdh7lIStM1986loX7WQLEfhlnpg1AB9GtGMyBpxQ+H6EXJdYl4Txbvz9oLr906i6owK7lYPA8Xcy1Wy63LgwO30PKoz0Ao+E04QYNQE3bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EIRALVcZWWDOQtsSl2VqUuk7I7q+4FoR1MMIiccev8Y=; b=ZFbyDq3FUTmXwfQzb0FVICDyZwN+Kyf/zh9hVueDJkXSrzQqdNR1siri2mqVaJ5d6NSGTXFMkyJpgs4OLf3IEsp3+VDz7IacGV0xgLnGBJNX2EUjdw7PqGAiz8EA72qMwYIESVi9HscgRdy0HdFUaxeproeNW5IsGWgou0tw3wg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4901.namprd11.prod.outlook.com (2603:10b6:510:3a::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4778.17; Tue, 14 Dec 2021 10:13:48 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4778.018; Tue, 14 Dec 2021 10:13:48 +0000 Message-ID: <5ac74587-4a18-3e0b-f674-73f927a11f95@intel.com> Date: Tue, 14 Dec 2021 10:13:38 +0000 Content-Language: en-US To: Christian Ehrhardt , "Kalesh Anakkur Purayil" CC: Abhishek Marathe , Akhil Goyal , Ali Alnubani , David Christensen , Hariprasad Govindharajan , Hemant Agrawal , Ian Stokes , Jerin Jacob , John McNamara , Ju-Hyoung Lee , Kevin Traynor , Luca Boccassi , Pei Zhang , Raslan Darawsheh , Thomas Monjalon , , dpdk stable , dpdk-dev , , , , References: <20211209144315.3424225-1-christian.ehrhardt@canonical.com> <7bf4583f-c2de-0aa7-fb00-bf3e9ff8d99b@intel.com> <34e0a9a8-327e-0150-b18a-dc3bfdca7d11@intel.com> <43d82514-b3e0-1bbd-1351-f1221bfc53db@intel.com> From: Ferruh Yigit Subject: Re: 19.11.11 patches review and test X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0115.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:c::31) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a0198083-f503-4583-6664-08d9beea6b29 X-MS-TrafficTypeDiagnostic: PH0PR11MB4901:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3044; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: juO9EN6eevQMesT0dXUN1aMmI2oH9NcaaFlrc3i/iR5IC7DOAiX05zGHoHW/dk85S12xueBaTDkR5Nf41waDy9MHoqXmKJ4X3NAddofiYMh/TuDt0DrGtfmzy3lI0QHmoBbqwqVwis7eF82QDzOukcAgZjscyqGWvxvKlMlHTSQ46TAlISw6A1qFPlRVqtCekHMEXLIYFWy+VcK+RcFKtNoY/pW7jL0nNr18R2ZG0Qin6WspfhuqZ69GKKQ3RokJqR6jF9bO7GYnvzgWk5mQ2AvTPg8X9TEzmjPvGE25CPLlMEwEJEIE52PA61+mzeYKy9Dzd6hdWaw/NbVq+Tj4YIAnXI0Vv8j0ZMPpEF5W2mJ3zlhOQQDjkU+ZuedE6g6Yrfn8wSPEL97Y+IwUkxuYmjoYLX8U4fgVuyo47lvxQ40/Spa5re5SAyNSf136amPjo1JQXMJt002mQ0P9tJH0VkSFUbyB7UOQP2QPKeLLTzT7dZqrh9aNae88AodfIFvzI/YY+8TCNCcSmFmiGaIUYGgZKlGdaV3Rt7E9tDsr6JP2Z9gVICbKPCYTSNKdsxgmR76bvwrZGq74HwYFOYZ7qTdK7wyf9Xih5unxPw2cmNAY2rSeYaRV58sS19GQZSvFBhrR1LT6qp/iUa4vwJoD54Z4bldAqGdK+TdWoNFaGj6LY26RVa3zn5gBlaaNBjSdZ8k3/PiOtssOhRv1FkTGYQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(6512007)(83380400001)(44832011)(38100700002)(26005)(2616005)(107886003)(6486002)(7416002)(8676002)(82960400001)(2906002)(54906003)(6666004)(8936002)(5660300002)(66556008)(66476007)(110136005)(508600001)(4326008)(316002)(66946007)(53546011)(86362001)(36756003)(6506007)(31696002)(31686004)(186003)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U2lNbFVBd0pUSXRoMUYwUkdqRzlIMjh5aWtwa1NKU2tnOC9pVXVLNVNZREx0?= =?utf-8?B?akpwMUtBZnZURlh5YW1JT0Q4NUN6MlprQUFaejRXR0w1b2g2R1Q5RWo5MjhZ?= =?utf-8?B?T3J0MDhzdFhCVDVaL2JBM3BCRFA0aVJPdzFzZlNvU3dhajhyNFZSRkZWaGdo?= =?utf-8?B?eWNVWGJXMHV5N2FxODZsb1BIakZCTHkyd1Ewd2FPdjZGQlpZMkEzbUp0d1NX?= =?utf-8?B?Wm5oNzdwS1JuSERjOGFtWWhFZmUwc3ZKWEo3S1dDS1BXT2RoYjV0cXBoaits?= =?utf-8?B?dU5INWRiL0t4Z2NyL1FCdjVsTlA3czNpdFBLQU5RWUFvREEwc0gvT1R5WjRr?= =?utf-8?B?a2IxNnNXVE1xSG5jYzVrOU1SRStpQ2M0Zm53bzlOd2I3STRkVTQ2ZUk2eG1W?= =?utf-8?B?czlEQlVrV0wvUEREeDEyVXdSNGpYTlNEc0JnM0txZ0RZbDRwRlhwWU5GR1J4?= =?utf-8?B?R09BQ2M3enVVMmgxZi9NbktBOTl0dFBsUElFaS80eGE0SS85Y2tjREN4NmxS?= =?utf-8?B?VENjd1Z2WHk3MHJ0OTdIendFV3Ixb1BsbkVCSmttbW5MSEJIUzBaM0JBUGdm?= =?utf-8?B?dGJydjR6V1Q1VEtKbHp6RGtJaWl0UDBrVUFKYXdvMlgzRjhJOUJvOHRDT2Rx?= =?utf-8?B?a3dLZGE0YnJOcjNyWUcxb3NIQVArQ3NnUS8zTmk1YjRaR0JnUHZzc3hUZjlm?= =?utf-8?B?QW9LajdocW1lK3dGUUZWK2ZQcUlKL3MxNDFEU3VBNTJjZXFFYTVwOGFUcFcx?= =?utf-8?B?MlluVnVST3lLRHRsMi9ZOXFSWE5PM00xNzhQWnZyNUpaaHFhb05YTXlzL3ph?= =?utf-8?B?NFBOTnh3Nm05UHBJdVlQd3pWQ3cybUthVVpoS0pUU01MMkM4YU1BRGttZU5J?= =?utf-8?B?S01lS3R2V0QzZVhjWFFSYndGUWliSEp4TjBQdERLcS9YS3RuUG1IUy83YS9w?= =?utf-8?B?OXNqREtVbUtoMVhFNE5jUzZKMUM0K1Vwd0FsWWExYlNTempMbGlScmdpUUgr?= =?utf-8?B?NktOQ0lSUnFvSWMwZFFnY0JVa21HVnJqK1Qrbm5xSXB0c2R1Y2tmd1NQWDBB?= =?utf-8?B?ak9ud3U2UHA0ZW9rcWFmZXhrdWJsenZuL1ZORUhKTllsdFVCWnY3bjJqODRG?= =?utf-8?B?R1Q0UmpkSTlZM3FlY0ZuZTRldm9uc1lnWmxMbk13YnY3SXZQWFloNzVwOEdB?= =?utf-8?B?RUxDYzlkQUtRRlJFbTM1ajdRUHVITm10Qzg0MFpSa2wxQ3BHaDNWQWlOK3gv?= =?utf-8?B?UnZlSENzUGx5MDVqVUFvQ2MyUWp1V0JZV040T3dIc0grN3BzUXJXZFhZMjBB?= =?utf-8?B?WVhqQnA2TUhIMXpacjhia09YaFNoR1ZzZDRuY3Z3aCsvMDczRHdvRzRudTU1?= =?utf-8?B?eTNpaEpiNmpwVDZKZy9DK1ZuT1d0b2g3MVd1QVN4K2NBMElNcjQvM0pDMW5J?= =?utf-8?B?VTh3cFp4cUJ2aGFFOGJwRzdKWGl4c0N1dTRad2xrTE5JR2hnelRzcHN2eHB5?= =?utf-8?B?N3ZTc2xKdmFJcjJWMXErRHI1Tjlkb0F1K0IwUkJMTktSTUdFWVZlY3R2eTRh?= =?utf-8?B?bXJTd0MxSEVyQ2tjSEFrLzNjREJ1UHRTUDlFeVEySFR1czd2K3ZkZjZ4WE5s?= =?utf-8?B?eFpBTjl2WTNtdmwvRys4SWJmaFp5REs2WW1TOGNpR3BQcURMRG42QTlWdzhW?= =?utf-8?B?Q1F5ZFB2d2hvMm5wVWx2b2hQMnExMks5T0JMTFJkTW9UdS9TQVVTYVZwcE5t?= =?utf-8?B?eWV0ZnRkemVuRURHMmxOS0ZJdUUrbjVSUGdRcHZiL1BaMHE5SUhueklSUGF0?= =?utf-8?B?U0Q3bnR6Y3hWV0QzVm5DOXd0dys0TytkVnArU3pVSUxtL2RNQ2U4TTkxVnlz?= =?utf-8?B?TlgzcFFJVHhST0ErMkt1djVPWVM5cVZZYVBDeGROejE0NXA3cjJoVDFtaG5Y?= =?utf-8?B?ZDR3SE0vYTlyOE9vc0hqYTBOaTF0WnpnTFBxNEtyMG5nMmR0d3ZYelJ0cEpU?= =?utf-8?B?NGlvYjJEeng4UlM5Y3pmakxESFRtWk93K1FmMXFIV0YyUmF0bTFHRCtaK1pk?= =?utf-8?B?SWpRVWJZNjZLcm1najREaTFrQnMwZ25yRG5Bd0d3ckQ5VDZvZEQzNGJKblZS?= =?utf-8?B?VCtuNklhUHo1bDZ4RXV4YWpPNXZXaGRxQVhNSUVOMUhXa3ZwVURwY0JSUFVF?= =?utf-8?Q?lQIoDCM9masi4upFP4UemNA=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: a0198083-f503-4583-6664-08d9beea6b29 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2021 10:13:48.3197 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IqgLFE+q1DLSq3/sAl8uHJssDC9i1K+vXj2OSr7hvFHJM+6z56SNztg4ZIBV5mjToUyojhnqMVwpT6PKObOzXA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4901 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/14/2021 7:44 AM, Christian Ehrhardt wrote: > On Tue, Dec 14, 2021 at 6:49 AM Kalesh Anakkur Purayil > wrote: > > [snip] > >>>> [Kalesh] Yes, i am seeing the same error. I used make command to build dpdk, not meson. >>>> The back ported commit you mentioned takes care of meson build only I think. >>>> >>> >>> I see, make build is failing, and yes the fix is only for the meson. >>> I will check the make build and will send a fix for it. >> >> [Kalesh]: looks like the below changes fixes the issue. I tried only on SLES15 SP3 and not on other SLES flavors. >> >> diff --git a/kernel/linux/kni/Makefile b/kernel/linux/kni/Makefile >> index 595bac2..bf0efab 100644 >> --- a/kernel/linux/kni/Makefile >> +++ b/kernel/linux/kni/Makefile >> @@ -16,6 +16,16 @@ MODULE_CFLAGS += -I$(RTE_OUTPUT)/include >> MODULE_CFLAGS += -include $(RTE_OUTPUT)/include/rte_config.h >> MODULE_CFLAGS += -Wall -Werror >> >> +# >> +# Use explicit 'source' folder for header path. In SUSE 'source' is not linked to 'build' folder. >> +# >> +ifdef CONFIG_SUSE_KERNEL >> + KSRC = /lib/modules/$(shell uname -r)/source >> + ifneq ($(shell grep -A 1 "ndo_tx_timeout" $(KSRC)/include/linux/netdevice.h | grep -o txqueue),) >> + MODULE_CFLAGS += -DHAVE_TX_TIMEOUT_TXQUEUE >> + endif >> +endif > > Back in the day we tried various "is Suse and kernel version x.y" > approaches, but they failed as there was no clear version throughout > all of the Suse streams (leap, tumbleweed, sles) that worked well for > all. > This change here follows the upstream approach of "just check if it is there". > > I've applied this to 19.11 and did test builds across various distributions: > 1. no non-suse build changed > 2. suse builds stayed as-is or improved > Formerly failing: > openSUSE_Factory_ARM aarch64 > SLE_15 x86_64 -> now working > openSUSE_Leap_15.3 x86_64 -> now working > openSUSE_Tumbleweed x86_64 -> still failing > Formerly working: > SLE_12_SP4 x86_64 ppc64le -> still fine > openSUSE_Factory_ARM armv7l -> still fine > openSUSE_Leap_15.2 x86_64 -> still fine > Thanks Kalesh for the fix, and thanks Christian for testing. I was expecting this approach will fix all builds, after patch only 'openSUSE_Tumbleweed' is failing, right? I will check it. And I think you need the fix as a patch anyway, @Kalesh are you planning to send the patch? > Past fixes always "inverted" the result, by fixing some but breaking others. > This new patch works in "not breaking any formerly working build" but > at the same time fixing a few builds. > Therefore -> applied & thanks! > > I'll likely tag -rc2 before the end of the week. > The good thing is that (so far) we have: > 1. a non functional change > 2. a change fixing clang-13 builds (TBH only one of many needed clang13 issues) > 3. a change fixing sles15SP3 builds > > Due to those, no current ongoing tests will have to be restarted. > Whoever was able to build, can continue the current tests. > Whoever was blocked by SLES15SP3 or clang-13 had no tests other than a > failing build and can work with -rc2 then. > I'll explain the same in the mail about -rc2. > >> -include /etc/lsb-release >> >> ifeq ($(DISTRIB_ID),Ubuntu) >> >> Regards, >> Kalesh > > [snip] >