From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ADDB0A0093; Mon, 18 May 2020 16:52:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 94DFF1D404; Mon, 18 May 2020 16:52:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 26F201D404 for ; Mon, 18 May 2020 16:52:35 +0200 (CEST) IronPort-SDR: 71aMkWe0q0RYbo0DTLp6sUSxzCvvN3qTqI97DtLffDUH3KeyktF1ycyV2Ro3fqcDwzCSGpIys4 KuLzrY2qRVKg== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2020 07:52:34 -0700 IronPort-SDR: pQ6LBv9okkILbCHE6i5KvSltLodOaaj4MNWhO8+dx2sLhsICQHmVdG8fkW3LdAjbVOYex5O5kO bw4IVdTWQuEg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,407,1583222400"; d="scan'208";a="465602563" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.252.4.195]) ([10.252.4.195]) by fmsmga005.fm.intel.com with ESMTP; 18 May 2020 07:52:33 -0700 To: Ciara Power , bruce.richardson@intel.com Cc: dev@dpdk.org References: <20200512152902.70211-1-ciara.power@intel.com> <20200512152902.70211-3-ciara.power@intel.com> From: "Laatz, Kevin" Message-ID: <5ad4dc93-77c5-7534-a179-c0fdfd347fba@intel.com> Date: Mon, 18 May 2020 15:52:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <20200512152902.70211-3-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH 2/5] telemetry: fix error checking for strchr function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/05/2020 16:28, Ciara Power wrote: > The strchr function return was not being checked which could lead to > NULL deferencing later in the function. > > Coverity issue: 358438 > Coverity issue: 358445 > Fixes: b80fe1805eee ("telemetry: introduce backward compatibility") > Cc: ciara.power@intel.com > > Signed-off-by: Ciara Power > --- > lib/librte_telemetry/telemetry_legacy.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > Acked-by: Kevin Laatz