From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30BC1A0540; Mon, 13 Jul 2020 10:14:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC2D91D52B; Mon, 13 Jul 2020 10:14:19 +0200 (CEST) Received: from qrelay39.mxroute.com (qrelay39.mxroute.com [172.82.139.39]) by dpdk.org (Postfix) with ESMTP id 751A91D524 for ; Mon, 13 Jul 2020 10:14:18 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] 149.28.56.236.vultr.com) (Authenticated sender: mN4UYu2MZsgR) by qrelay39.mxroute.com (ZoneMTA) with ESMTPA id 173473d2529000de81.001 for ; Mon, 13 Jul 2020 08:14:16 +0000 X-Zone-Loop: ad4c733ead9ddbf8d1da954a81b9df85668c412f7b5a X-Originating-IP: [149.28.56.236] Received: from echo.mxrouting.net (echo.mxrouting.net [116.202.222.109]) by filter004.mxroute.com (Postfix) with ESMTPS id B92473F581; Mon, 13 Jul 2020 08:06:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OkG5Kh8YXEBCXZHQbbrGRkJ5J2RSJF9aig/pcN5EACs=; b=DZCfeu+yCkULhlDHFfrJoVigGB 7/TvuLM9+Uk3CKd/yNvlJWLj+xU/MYtsDnBDNEOp2XKJHBz8GDmb7647uXoMqXER3lezjRLn65urK brMhhAZX1X/5nVRt+lSIdlDEkI9K7boRYMlmOsKL5cbOR0Asxqd7vDN/G70GVuDx/XGBQMngKYUUz IQsb23zS1J7KNCxtCpqpfyzRezVB4TzhtLu8OS398zz6kFkr2uc1bjtlNHC4Fvh5zhdkumrlzMhEZ zhBI0EywDXdvOli+8SSSiz/zcmvzlgeHpNCFx0WILpCRjbMBzMHeY2JyDagejChPVWngN6DZkEQCo vYhBUr8Q==; To: Andrey Vesnovaty , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Neil Horman Cc: dev@dpdk.org, jerinjacobk@gmail.com, thomas@monjalon.net, ferruh.yigit@intel.com, stephen@networkplumber.org, bruce.richardson@intel.com, orika@mellanox.com, andrey.vesnovaty@gmail.com References: <20200708204015.24429-3-andreyv@mellanox.com> From: "Kinsella, Ray" Autocrypt: addr=mdr@ashroe.eu; keydata= mQINBFv8B3wBEAC+5ImcgbIvadt3axrTnt7Sxch3FsmWTTomXfB8YiuHT8KL8L/bFRQSL1f6 ASCHu3M89EjYazlY+vJUWLr0BhK5t/YI7bQzrOuYrl9K94vlLwzD19s/zB/g5YGGR5plJr0s JtJsFGEvF9LL3e+FKMRXveQxBB8A51nAHfwG0WSyx53d61DYz7lp4/Y4RagxaJoHp9lakn8j HV2N6rrnF+qt5ukj5SbbKWSzGg5HQF2t0QQ5tzWhCAKTfcPlnP0GymTBfNMGOReWivi3Qqzr S51Xo7hoGujUgNAM41sxpxmhx8xSwcQ5WzmxgAhJ/StNV9cb3HWIoE5StCwQ4uXOLplZNGnS uxNdegvKB95NHZjRVRChg/uMTGpg9PqYbTIFoPXjuk27sxZLRJRrueg4tLbb3HM39CJwSB++ YICcqf2N+GVD48STfcIlpp12/HI+EcDSThzfWFhaHDC0hyirHxJyHXjnZ8bUexI/5zATn/ux TpMbc/vicJxeN+qfaVqPkCbkS71cHKuPluM3jE8aNCIBNQY1/j87k5ELzg3qaesLo2n1krBH bKvFfAmQuUuJT84/IqfdVtrSCTabvDuNBDpYBV0dGbTwaRfE7i+LiJJclUr8lOvHUpJ4Y6a5 0cxEPxm498G12Z3NoY/mP5soItPIPtLR0rA0fage44zSPwp6cQARAQABtBxSYXkgS2luc2Vs bGEgPG1kckBhc2hyb2UuZXU+iQJUBBMBCAA+FiEEcDUDlKDJaDuJlfZfdJdaH/sCCpsFAlv8 B3wCGyMFCQlmAYAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQdJdaH/sCCptdtRAAl0oE msa+djBVYLIsax+0f8acidtWg2l9f7kc2hEjp9h9aZCpPchQvhhemtew/nKavik3RSnLTAyn B3C/0GNlmvI1l5PFROOgPZwz4xhJKGN7jOsRrbkJa23a8ly5UXwF3Vqnlny7D3z+7cu1qq/f VRK8qFyWkAb+xgqeZ/hTcbJUWtW+l5Zb+68WGEp8hB7TuJLEWb4+VKgHTpQ4vElYj8H3Z94a 04s2PJMbLIZSgmKDASnyrKY0CzTpPXx5rSJ1q+B1FCsfepHLqt3vKSALa3ld6bJ8fSJtDUJ7 JLiU8dFZrywgDIVme01jPbjJtUScW6jONLvhI8Z2sheR71UoKqGomMHNQpZ03ViVWBEALzEt TcjWgJFn8yAmxqM4nBnZ+hE3LbMo34KCHJD4eg18ojDt3s9VrDLa+V9fNxUHPSib9FD9UX/1 +nGfU/ZABmiTuUDM7WZdXri7HaMpzDRJUKI6b+/uunF8xH/h/MHW16VuMzgI5dkOKKv1LejD dT5mA4R+2zBS+GsM0oa2hUeX9E5WwjaDzXtVDg6kYq8YvEd+m0z3M4e6diFeLS77/sAOgaYL 92UcoKD+Beym/fVuC6/55a0e12ksTmgk5/ZoEdoNQLlVgd2INtvnO+0k5BJcn66ZjKn3GbEC VqFbrnv1GnA58nEInRCTzR1k26h9nmS5Ag0EW/wHfAEQAMth1vHr3fOZkVOPfod3M6DkQir5 xJvUW5EHgYUjYCPIa2qzgIVVuLDqZgSCCinyooG5dUJONVHj3nCbITCpJp4eB3PI84RPfDcC hf/V34N/Gx5mTeoymSZDBmXT8YtvV/uJvn+LvHLO4ZJdvq5ZxmDyxfXFmkm3/lLw0+rrNdK5 pt6OnVlCqEU9tcDBezjUwDtOahyV20XqxtUttN4kQWbDRkhT+HrA9WN9l2HX91yEYC+zmF1S OhBqRoTPLrR6g4sCWgFywqztpvZWhyIicJipnjac7qL/wRS+wrWfsYy6qWLIV80beN7yoa6v ccnuy4pu2uiuhk9/edtlmFE4dNdoRf7843CV9k1yRASTlmPkU59n0TJbw+okTa9fbbQgbIb1 pWsAuicRHyLUIUz4f6kPgdgty2FgTKuPuIzJd1s8s6p2aC1qo+Obm2gnBTduB+/n1Jw+vKpt 07d+CKEKu4CWwvZZ8ktJJLeofi4hMupTYiq+oMzqH+V1k6QgNm0Da489gXllU+3EFC6W1qKj tkvQzg2rYoWeYD1Qn8iXcO4Fpk6wzylclvatBMddVlQ6qrYeTmSbCsk+m2KVrz5vIyja0o5Y yfeN29s9emXnikmNfv/dA5fpi8XCANNnz3zOfA93DOB9DBf0TQ2/OrSPGjB3op7RCfoPBZ7u AjJ9dM7VABEBAAGJAjwEGAEIACYWIQRwNQOUoMloO4mV9l90l1of+wIKmwUCW/wHfAIbDAUJ CWYBgAAKCRB0l1of+wIKm3KlD/9w/LOG5rtgtCUWPl4B3pZvGpNym6XdK8cop9saOnE85zWf u+sKWCrxNgYkYP7aZrYMPwqDvilxhbTsIJl5HhPgpTO1b0i+c0n1Tij3EElj5UCg3q8mEc17 c+5jRrY3oz77g7E3oPftAjaq1ybbXjY4K32o3JHFR6I8wX3m9wJZJe1+Y+UVrrjY65gZFxcA thNVnWKErarVQGjeNgHV4N1uF3pIx3kT1N4GSnxhoz4Bki91kvkbBhUgYfNflGURfZT3wIKK +d50jd7kqRouXUCzTdzmDh7jnYrcEFM4nvyaYu0JjSS5R672d9SK5LVIfWmoUGzqD4AVmUW8 pcv461+PXchuS8+zpltR9zajl72Q3ymlT4BTAQOlCWkD0snBoKNUB5d2EXPNV13nA0qlm4U2 GpROfJMQXjV6fyYRvttKYfM5xYKgRgtP0z5lTAbsjg9WFKq0Fndh7kUlmHjuAIwKIV4Tzo75 QO2zC0/NTaTjmrtiXhP+vkC4pcrOGNsbHuaqvsc/ZZ0siXyYsqbctj/sCd8ka2r94u+c7o4l BGaAm+FtwAfEAkXHu4y5Phuv2IRR+x1wTey1U1RaEPgN8xq0LQ1OitX4t2mQwjdPihZQBCnZ wzOrkbzlJMNrMKJpEgulmxAHmYJKgvZHXZXtLJSejFjR0GdHJcL5rwVOMWB8cg== Message-ID: <5adbda0a-44c5-0d08-d2c0-afacacc1f57d@ashroe.eu> Date: Mon, 13 Jul 2020 09:06:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200708204015.24429-3-andreyv@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 08/07/2020 21:40, Andrey Vesnovaty wrote: > Implement mlx5_devx_cmd_modify_tir() to modify TIR object using DevX > API. > Add related structs in mlx5_prm.h. > > Signed-off-by: Andrey Vesnovaty > --- > drivers/common/mlx5/mlx5_devx_cmds.c | 84 +++++++++++++++++++ > drivers/common/mlx5/mlx5_devx_cmds.h | 10 +++ > drivers/common/mlx5/mlx5_prm.h | 29 +++++++ > .../common/mlx5/rte_common_mlx5_version.map | 1 + > 4 files changed, 124 insertions(+) > > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c > index 2179a83983..2a7098ec6d 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.c > +++ b/drivers/common/mlx5/mlx5_devx_cmds.c > @@ -825,6 +825,90 @@ mlx5_devx_cmd_create_tir(void *ctx, > return tir; > } > > +/** > + * Modify TIR using DevX API. > + * > + * @param[in] tir > + * Pointer to TIR DevX object structure. > + * @param [in] modify_tir_attr > + * Pointer to TIR modification attributes structure. > + * > + * @return > + * 0 on success, a negative errno value otherwise and rte_errno is set. > + */ > +int > +mlx5_devx_cmd_modify_tir(struct mlx5_devx_obj *tir, > + struct mlx5_devx_modify_tir_attr *modify_tir_attr) > +{ > + struct mlx5_devx_tir_attr *tir_attr = &modify_tir_attr->tir; > + uint32_t in[MLX5_ST_SZ_DW(modify_tir_in)] = {0}; > + uint32_t out[MLX5_ST_SZ_DW(modify_tir_out)] = {0}; > + void *tir_ctx; > + int ret; > + > + MLX5_SET(modify_tir_in, in, opcode, MLX5_CMD_OP_MODIFY_TIR); > + MLX5_SET(modify_tir_in, in, tirn, modify_tir_attr->tirn); > + MLX5_SET64(modify_tir_in, in, modify_bitmask, > + modify_tir_attr->modify_bitmask); > + > + tir_ctx = MLX5_ADDR_OF(modify_rq_in, in, ctx); > + if (modify_tir_attr->modify_bitmask & > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_LRO) { > + MLX5_SET(tirc, tir_ctx, lro_timeout_period_usecs, > + tir_attr->lro_timeout_period_usecs); > + MLX5_SET(tirc, tir_ctx, lro_enable_mask, > + tir_attr->lro_enable_mask); > + MLX5_SET(tirc, tir_ctx, lro_max_msg_sz, > + tir_attr->lro_max_msg_sz); > + } > + if (modify_tir_attr->modify_bitmask & > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_INDIRECT_TABLE) > + MLX5_SET(tirc, tir_ctx, indirect_table, > + tir_attr->indirect_table); > + if (modify_tir_attr->modify_bitmask & > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_HASH) { > + int i; > + void *outer, *inner; > + MLX5_SET(tirc, tir_ctx, rx_hash_symmetric, > + tir_attr->rx_hash_symmetric); > + MLX5_SET(tirc, tir_ctx, rx_hash_fn, tir_attr->rx_hash_fn); > + for (i = 0; i < 10; i++) { > + MLX5_SET(tirc, tir_ctx, rx_hash_toeplitz_key[i], > + tir_attr->rx_hash_toeplitz_key[i]); > + } > + outer = MLX5_ADDR_OF(tirc, tir_ctx, > + rx_hash_field_selector_outer); > + MLX5_SET(rx_hash_field_select, outer, l3_prot_type, > + tir_attr->rx_hash_field_selector_outer.l3_prot_type); > + MLX5_SET(rx_hash_field_select, outer, l4_prot_type, > + tir_attr->rx_hash_field_selector_outer.l4_prot_type); > + MLX5_SET > + (rx_hash_field_select, outer, selected_fields, > + tir_attr->rx_hash_field_selector_outer.selected_fields); > + inner = MLX5_ADDR_OF(tirc, tir_ctx, > + rx_hash_field_selector_inner); > + MLX5_SET(rx_hash_field_select, inner, l3_prot_type, > + tir_attr->rx_hash_field_selector_inner.l3_prot_type); > + MLX5_SET(rx_hash_field_select, inner, l4_prot_type, > + tir_attr->rx_hash_field_selector_inner.l4_prot_type); > + MLX5_SET > + (rx_hash_field_select, inner, selected_fields, > + tir_attr->rx_hash_field_selector_inner.selected_fields); > + } > + if (modify_tir_attr->modify_bitmask & > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_SELF_LB_EN) { > + MLX5_SET(tirc, tir_ctx, self_lb_block, tir_attr->self_lb_block); > + } > + ret = mlx5_glue->devx_obj_modify(tir->obj, in, sizeof(in), > + out, sizeof(out)); > + if (ret) { > + DRV_LOG(ERR, "Failed to modify TIR using DevX"); > + rte_errno = errno; > + return -errno; > + } > + return ret; > +} > + > /** > * Create RQT using DevX API. > * > diff --git a/drivers/common/mlx5/mlx5_devx_cmds.h b/drivers/common/mlx5/mlx5_devx_cmds.h > index 25704efc1f..9b07b39e66 100644 > --- a/drivers/common/mlx5/mlx5_devx_cmds.h > +++ b/drivers/common/mlx5/mlx5_devx_cmds.h > @@ -178,6 +178,13 @@ struct mlx5_devx_tir_attr { > struct mlx5_rx_hash_field_select rx_hash_field_selector_inner; > }; > > +/* TIR attributes structure, used by TIR modify */ > +struct mlx5_devx_modify_tir_attr { > + uint32_t tirn:24; > + uint64_t modify_bitmask; > + struct mlx5_devx_tir_attr tir; > +}; > + > /* RQT attributes structure, used by RQT operations. */ > struct mlx5_devx_rqt_attr { > uint8_t rq_type; > @@ -372,6 +379,9 @@ int mlx5_devx_cmd_modify_qp_state(struct mlx5_devx_obj *qp, > __rte_internal > int mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, > struct mlx5_devx_rqt_attr *rqt_attr); > +__rte_internal > +int mlx5_devx_cmd_modify_tir(struct mlx5_devx_obj *tir, > + struct mlx5_devx_modify_tir_attr *tir_attr); > > /** > * Create virtio queue counters object DevX API. > diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h > index c63795fc84..029767ea34 100644 > --- a/drivers/common/mlx5/mlx5_prm.h > +++ b/drivers/common/mlx5/mlx5_prm.h > @@ -746,6 +746,7 @@ enum { > MLX5_CMD_OP_QUERY_NIC_VPORT_CONTEXT = 0x754, > MLX5_CMD_OP_ALLOC_TRANSPORT_DOMAIN = 0x816, > MLX5_CMD_OP_CREATE_TIR = 0x900, > + MLX5_CMD_OP_MODIFY_TIR = 0x901, > MLX5_CMD_OP_CREATE_SQ = 0X904, > MLX5_CMD_OP_MODIFY_SQ = 0X905, > MLX5_CMD_OP_CREATE_RQ = 0x908, > @@ -1753,6 +1754,34 @@ struct mlx5_ifc_create_tir_in_bits { > struct mlx5_ifc_tirc_bits ctx; > }; > > +enum { > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_LRO = 1ULL << 0, > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_INDIRECT_TABLE = 1ULL << 1, > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_HASH = 1ULL << 2, > + /* bit 3 - tunneled_offload_en modify not supported */ > + MLX5_MODIFY_TIR_IN_MODIFY_BITMASK_SELF_LB_EN = 1ULL << 4, > +}; > + > +struct mlx5_ifc_modify_tir_out_bits { > + u8 status[0x8]; > + u8 reserved_at_8[0x18]; > + u8 syndrome[0x20]; > + u8 reserved_at_40[0x40]; > +}; > + > +struct mlx5_ifc_modify_tir_in_bits { > + u8 opcode[0x10]; > + u8 uid[0x10]; > + u8 reserved_at_20[0x10]; > + u8 op_mod[0x10]; > + u8 reserved_at_40[0x8]; > + u8 tirn[0x18]; > + u8 reserved_at_60[0x20]; > + u8 modify_bitmask[0x40]; > + u8 reserved_at_c0[0x40]; > + struct mlx5_ifc_tirc_bits ctx; > +}; > + > enum { > MLX5_INLINE_Q_TYPE_RQ = 0x0, > MLX5_INLINE_Q_TYPE_VIRTQ = 0x1, > diff --git a/drivers/common/mlx5/rte_common_mlx5_version.map b/drivers/common/mlx5/rte_common_mlx5_version.map > index ae57ebdba5..0bfedab32f 100644 > --- a/drivers/common/mlx5/rte_common_mlx5_version.map > +++ b/drivers/common/mlx5/rte_common_mlx5_version.map > @@ -29,6 +29,7 @@ INTERNAL { > mlx5_devx_cmd_modify_rq; > mlx5_devx_cmd_modify_rqt; > mlx5_devx_cmd_modify_sq; > + mlx5_devx_cmd_modify_tir; > mlx5_devx_cmd_modify_virtq; > mlx5_devx_cmd_qp_query_tis_td; > mlx5_devx_cmd_query_hca_attr; Acked-by: Ray Kinsella