From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7E9E75F11 for ; Wed, 3 Apr 2019 01:01:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 16:01:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="333206780" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga006.fm.intel.com with ESMTP; 02 Apr 2019 16:01:47 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-11-anand.rawat@intel.com> <8636883.cOhKqkjfg7@xps> From: Anand Rawat Message-ID: <5ae45b30-ff5e-792c-794d-c64e415dbb15@intel.com> Date: Tue, 2 Apr 2019 16:01:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8636883.cOhKqkjfg7@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Apr 2019 23:01:48 -0000 On 4/2/2019 3:51 PM, Thomas Monjalon wrote: > 02/04/2019 05:54, Anand Rawat: >> Added meson workarounds to build helloworld on Windows. >> Windows currently only supports kvargs and eal libraries. >> This change restricts the build flow to supported libraries >> only. >> >> Signed-off-by: Anand Rawat >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Jeff Shaw >> Reviewed-by: Ranjit Menon >> --- >> --- a/examples/meson.build >> +++ b/examples/meson.build >> @@ -35,7 +35,9 @@ foreach example: examples >> >> ext_deps = [execinfo] >> includes = [include_directories(example)] >> - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] >> + if host_machine.system() == 'windows' >> + deps = ['eal'] # only supported lib on Windows currently >> + endif >> subdir(example) > > This is not what I call keeping build intact for Linux/BSD :) > > I did not catch it before because test-meson-builds.sh is not testing > compilation of the examples with meson. Bruce, may we add it? > > I will add back the original deps line in master branch. > > That is correct, deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] should have not been removed from this file. Please add the line back. -- Anand Rawat From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 61D2BA0679 for ; Wed, 3 Apr 2019 01:01:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3233A5F14; Wed, 3 Apr 2019 01:01:50 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7E9E75F11 for ; Wed, 3 Apr 2019 01:01:48 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Apr 2019 16:01:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,302,1549958400"; d="scan'208";a="333206780" Received: from anandraw-mobl.amr.corp.intel.com (HELO [10.121.163.141]) ([10.121.163.141]) by fmsmga006.fm.intel.com with ESMTP; 02 Apr 2019 16:01:47 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com, jeffrey.b.shaw@intel.com, bruce.richardson@intel.com References: <20190306041634.12976-1-anand.rawat@intel.com> <20190402035458.14664-1-anand.rawat@intel.com> <20190402035458.14664-11-anand.rawat@intel.com> <8636883.cOhKqkjfg7@xps> From: Anand Rawat Message-ID: <5ae45b30-ff5e-792c-794d-c64e415dbb15@intel.com> Date: Tue, 2 Apr 2019 16:01:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <8636883.cOhKqkjfg7@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v8 10/10] build: meson changes to build on windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190402230147.JAY1AHZnsDzCNVrLMMJ3AZ4MEcXeXBLGYA2Rnj4XTIQ@z> On 4/2/2019 3:51 PM, Thomas Monjalon wrote: > 02/04/2019 05:54, Anand Rawat: >> Added meson workarounds to build helloworld on Windows. >> Windows currently only supports kvargs and eal libraries. >> This change restricts the build flow to supported libraries >> only. >> >> Signed-off-by: Anand Rawat >> Signed-off-by: Pallavi Kadam >> Reviewed-by: Jeff Shaw >> Reviewed-by: Ranjit Menon >> --- >> --- a/examples/meson.build >> +++ b/examples/meson.build >> @@ -35,7 +35,9 @@ foreach example: examples >> >> ext_deps = [execinfo] >> includes = [include_directories(example)] >> - deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] >> + if host_machine.system() == 'windows' >> + deps = ['eal'] # only supported lib on Windows currently >> + endif >> subdir(example) > > This is not what I call keeping build intact for Linux/BSD :) > > I did not catch it before because test-meson-builds.sh is not testing > compilation of the examples with meson. Bruce, may we add it? > > I will add back the original deps line in master branch. > > That is correct, deps = ['eal', 'mempool', 'net', 'mbuf', 'ethdev', 'cmdline'] should have not been removed from this file. Please add the line back. -- Anand Rawat