* [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access
@ 2021-10-12 7:36 skori
2021-10-12 7:50 ` Li, Xiaoyun
2021-10-12 8:33 ` [dpdk-dev] [PATCH v2 1/1] " skori
0 siblings, 2 replies; 5+ messages in thread
From: skori @ 2021-10-12 7:36 UTC (permalink / raw)
To: Xiaoyun Li; +Cc: dev, Sunil Kumar Kori, stable
From: Sunil Kumar Kori <skori@marvell.com>
During parsing of DSCP entries, memory is allocated and assgined
to *dscp_table. Later on, same memory is accessed using
*dscp_table[i++].
Due to higher precedence for array subscript, dscp_table[i++] will
be executed first which actually does not point to the same memory
which was allocated previously for DSCP table entries.
Cc: stable@dpdk.org
Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
app/test-pmd/cmdline_mtr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index b5dcfdadcf..ad7ef6ad98 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -101,13 +101,13 @@ parse_dscp_table_entries(char *str, enum rte_color **dscp_table)
while (1) {
if (strcmp(token, "G") == 0 ||
strcmp(token, "g") == 0)
- *dscp_table[i++] = RTE_COLOR_GREEN;
+ (*dscp_table)[i++] = RTE_COLOR_GREEN;
else if (strcmp(token, "Y") == 0 ||
strcmp(token, "y") == 0)
- *dscp_table[i++] = RTE_COLOR_YELLOW;
+ (*dscp_table)[i++] = RTE_COLOR_YELLOW;
else if (strcmp(token, "R") == 0 ||
strcmp(token, "r") == 0)
- *dscp_table[i++] = RTE_COLOR_RED;
+ (*dscp_table)[i++] = RTE_COLOR_RED;
else {
free(*dscp_table);
return -1;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access
2021-10-12 7:36 [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access skori
@ 2021-10-12 7:50 ` Li, Xiaoyun
2021-10-12 8:21 ` Sunil Kumar Kori
2021-10-12 8:33 ` [dpdk-dev] [PATCH v2 1/1] " skori
1 sibling, 1 reply; 5+ messages in thread
From: Li, Xiaoyun @ 2021-10-12 7:50 UTC (permalink / raw)
To: skori; +Cc: dev, stable, Dumitrescu, Cristian
Hi
> -----Original Message-----
> From: skori@marvell.com <skori@marvell.com>
> Sent: Tuesday, October 12, 2021 15:36
> To: Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>; stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix invalid memory access
>
> From: Sunil Kumar Kori <skori@marvell.com>
>
> During parsing of DSCP entries, memory is allocated and assgined to *dscp_table.
> Later on, same memory is accessed using *dscp_table[i++].
>
> Due to higher precedence for array subscript, dscp_table[i++] will be executed
> first which actually does not point to the same memory which was allocated
> previously for DSCP table entries.
>
> Cc: stable@dpdk.org
>
> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands")
I think the fix should be for patch 459463ae6c26 ("app/testpmd: fix memory allocation for DSCP table")
Also, added metering maintainer.
BRs
Xiaoyun
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
> ---
> app/test-pmd/cmdline_mtr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index
> b5dcfdadcf..ad7ef6ad98 100644
> --- a/app/test-pmd/cmdline_mtr.c
> +++ b/app/test-pmd/cmdline_mtr.c
> @@ -101,13 +101,13 @@ parse_dscp_table_entries(char *str, enum rte_color
> **dscp_table)
> while (1) {
> if (strcmp(token, "G") == 0 ||
> strcmp(token, "g") == 0)
> - *dscp_table[i++] = RTE_COLOR_GREEN;
> + (*dscp_table)[i++] = RTE_COLOR_GREEN;
> else if (strcmp(token, "Y") == 0 ||
> strcmp(token, "y") == 0)
> - *dscp_table[i++] = RTE_COLOR_YELLOW;
> + (*dscp_table)[i++] = RTE_COLOR_YELLOW;
> else if (strcmp(token, "R") == 0 ||
> strcmp(token, "r") == 0)
> - *dscp_table[i++] = RTE_COLOR_RED;
> + (*dscp_table)[i++] = RTE_COLOR_RED;
> else {
> free(*dscp_table);
> return -1;
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access
2021-10-12 7:50 ` Li, Xiaoyun
@ 2021-10-12 8:21 ` Sunil Kumar Kori
0 siblings, 0 replies; 5+ messages in thread
From: Sunil Kumar Kori @ 2021-10-12 8:21 UTC (permalink / raw)
To: Li, Xiaoyun; +Cc: dev, stable, Dumitrescu, Cristian
Regards
Sunil Kumar Kori
>-----Original Message-----
>From: Li, Xiaoyun <xiaoyun.li@intel.com>
>Sent: Tuesday, October 12, 2021 1:21 PM
>To: Sunil Kumar Kori <skori@marvell.com>
>Cc: dev@dpdk.org; stable@dpdk.org; Dumitrescu, Cristian
><cristian.dumitrescu@intel.com>
>Subject: [EXT] RE: [PATCH] app/testpmd: fix invalid memory access
>
>External Email
>
>----------------------------------------------------------------------
>Hi
>
>> -----Original Message-----
>> From: skori@marvell.com <skori@marvell.com>
>> Sent: Tuesday, October 12, 2021 15:36
>> To: Li, Xiaoyun <xiaoyun.li@intel.com>
>> Cc: dev@dpdk.org; Sunil Kumar Kori <skori@marvell.com>;
>> stable@dpdk.org
>> Subject: [PATCH] app/testpmd: fix invalid memory access
>>
>> From: Sunil Kumar Kori <skori@marvell.com>
>>
>> During parsing of DSCP entries, memory is allocated and assgined to
>*dscp_table.
>> Later on, same memory is accessed using *dscp_table[i++].
>>
>> Due to higher precedence for array subscript, dscp_table[i++] will be
>> executed first which actually does not point to the same memory which
>> was allocated previously for DSCP table entries.
>>
>> Cc: stable@dpdk.org
>>
>> Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing
>> commands")
>
>I think the fix should be for patch 459463ae6c26 ("app/testpmd: fix memory
>allocation for DSCP table") Also, added metering maintainer.
>
Ack. I will update and share v2.
>BRs
>Xiaoyun
>
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>> ---
>> app/test-pmd/cmdline_mtr.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
>> index
>> b5dcfdadcf..ad7ef6ad98 100644
>> --- a/app/test-pmd/cmdline_mtr.c
>> +++ b/app/test-pmd/cmdline_mtr.c
>> @@ -101,13 +101,13 @@ parse_dscp_table_entries(char *str, enum
>> rte_color
>> **dscp_table)
>> while (1) {
>> if (strcmp(token, "G") == 0 ||
>> strcmp(token, "g") == 0)
>> - *dscp_table[i++] = RTE_COLOR_GREEN;
>> + (*dscp_table)[i++] = RTE_COLOR_GREEN;
>> else if (strcmp(token, "Y") == 0 ||
>> strcmp(token, "y") == 0)
>> - *dscp_table[i++] = RTE_COLOR_YELLOW;
>> + (*dscp_table)[i++] = RTE_COLOR_YELLOW;
>> else if (strcmp(token, "R") == 0 ||
>> strcmp(token, "r") == 0)
>> - *dscp_table[i++] = RTE_COLOR_RED;
>> + (*dscp_table)[i++] = RTE_COLOR_RED;
>> else {
>> free(*dscp_table);
>> return -1;
>> --
>> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] app/testpmd: fix invalid memory access
2021-10-12 7:36 [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access skori
2021-10-12 7:50 ` Li, Xiaoyun
@ 2021-10-12 8:33 ` skori
2021-10-19 16:11 ` Ferruh Yigit
1 sibling, 1 reply; 5+ messages in thread
From: skori @ 2021-10-12 8:33 UTC (permalink / raw)
To: Xiaoyun Li; +Cc: dev, Sunil Kumar Kori, stable
From: Sunil Kumar Kori <skori@marvell.com>
During parsing of DSCP entries, memory is allocated and assigned
to *dscp_table. Later on, same memory is accessed using
*dscp_table[i++].
Due to higher precedence for array subscript, dscp_table[i++] will
be executed first which actually does not point to the same memory
which was allocated previously for DSCP table entries.
Cc: stable@dpdk.org
Fixes: 459463ae6c26 ("app/testpmd: fix memory allocation for DSCP table")
Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
---
v2:
- Correct spelling mistakes
- Correct fixes tag
app/test-pmd/cmdline_mtr.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c
index b5dcfdadcf..ad7ef6ad98 100644
--- a/app/test-pmd/cmdline_mtr.c
+++ b/app/test-pmd/cmdline_mtr.c
@@ -101,13 +101,13 @@ parse_dscp_table_entries(char *str, enum rte_color **dscp_table)
while (1) {
if (strcmp(token, "G") == 0 ||
strcmp(token, "g") == 0)
- *dscp_table[i++] = RTE_COLOR_GREEN;
+ (*dscp_table)[i++] = RTE_COLOR_GREEN;
else if (strcmp(token, "Y") == 0 ||
strcmp(token, "y") == 0)
- *dscp_table[i++] = RTE_COLOR_YELLOW;
+ (*dscp_table)[i++] = RTE_COLOR_YELLOW;
else if (strcmp(token, "R") == 0 ||
strcmp(token, "r") == 0)
- *dscp_table[i++] = RTE_COLOR_RED;
+ (*dscp_table)[i++] = RTE_COLOR_RED;
else {
free(*dscp_table);
return -1;
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] app/testpmd: fix invalid memory access
2021-10-12 8:33 ` [dpdk-dev] [PATCH v2 1/1] " skori
@ 2021-10-19 16:11 ` Ferruh Yigit
0 siblings, 0 replies; 5+ messages in thread
From: Ferruh Yigit @ 2021-10-19 16:11 UTC (permalink / raw)
To: skori, Xiaoyun Li; +Cc: dev, stable, Singh, Jasvinder, Dumitrescu, Cristian
On 10/12/2021 9:33 AM, skori@marvell.com wrote:
> From: Sunil Kumar Kori <skori@marvell.com>
>
> During parsing of DSCP entries, memory is allocated and assigned
> to *dscp_table. Later on, same memory is accessed using
> *dscp_table[i++].
>
> Due to higher precedence for array subscript, dscp_table[i++] will
> be executed first which actually does not point to the same memory
> which was allocated previously for DSCP table entries.
>
Of course, thanks for the fix.
> Cc: stable@dpdk.org
>
> Fixes: 459463ae6c26 ("app/testpmd: fix memory allocation for DSCP table")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-19 16:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-12 7:36 [dpdk-dev] [PATCH] app/testpmd: fix invalid memory access skori
2021-10-12 7:50 ` Li, Xiaoyun
2021-10-12 8:21 ` Sunil Kumar Kori
2021-10-12 8:33 ` [dpdk-dev] [PATCH v2 1/1] " skori
2021-10-19 16:11 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).