From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id AD78B1B1CD for ; Wed, 10 Jan 2018 10:30:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 01:29:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,339,1511856000"; d="scan'208";a="22864113" Received: from jguo15x-mobl3.ccr.corp.intel.com (HELO [10.67.68.70]) ([10.67.68.70]) by orsmga001.jf.intel.com with ESMTP; 10 Jan 2018 01:29:56 -0800 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= References: <1509567405-27439-3-git-send-email-jia.guo@intel.com> <2803089.mJXnisXhBj@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D13F4@shsmsx102.ccr.corp.intel.com> <3539603.0DoXzmkF5E@xps> <01BA8470C017D6468C8290E4B9C5E1E83B2D1493@shsmsx102.ccr.corp.intel.com> <20180109124204.xltndt76khsrgmpe@bidouze.vm.6wind.com> Cc: Thomas Monjalon , Mordechay Haimovsky , "dev@dpdk.org" , "stephen@networkplumber.org" , "Richardson, Bruce" , "Yigit, Ferruh" , "Ananyev, Konstantin" , "shreyansh.jain@nxp.com" , "Wu, Jingjing" , "Zhang, Helin" , "Van Haaren, Harry" From: "Guo, Jia" Message-ID: <5b3def36-dcae-11e8-34ee-00adc81df9d3@intel.com> Date: Wed, 10 Jan 2018 17:29:55 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20180109124204.xltndt76khsrgmpe@bidouze.vm.6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jan 2018 09:30:01 -0000 On 1/9/2018 8:42 PM, Gaëtan Rivet wrote: > Hi Jeff, > > On Tue, Jan 09, 2018 at 12:08:52PM +0000, Guo, Jia wrote: >> Your comments about split it totally make sense ,no doubt that, but my question is that if split api with the funcational , so the function part should be set null implement or stake. Any other good idea or tip for that. >> > Please avoid top-posting on the mailing list, it is confusing when > reading a thread intertwined with inner-posted mails. > > Regarding your issue, it is fine to propose a first skeleton API with > bare implementations, then progressively use your new functions where > relevant. > > It is only necessary to ensure compilation is always possible between > each patch. The API itself need not be usable, as long as the patch > order remains coherent and meaningful for review. > > Otherwise, sorry about not doing a review earlier, I didn't think I knew > enough about uevent to provide useful comments. However after a quick > reading I may be able to provide a few remarks. > > I will wait for your split before doing so. make sense, new patch set version have been sent, for you reference. >> Best regards, >> Jeff Guo >> >> >> -----Original Message----- >> From: Thomas Monjalon [mailto:thomas@monjalon.net] >> Sent: Tuesday, January 9, 2018 7:45 PM >> To: Guo, Jia >> Cc: Mordechay Haimovsky ; dev@dpdk.org; stephen@networkplumber.org; Richardson, Bruce ; Yigit, Ferruh ; gaetan.rivet@6wind.com; Ananyev, Konstantin ; shreyansh.jain@nxp.com; Wu, Jingjing ; Zhang, Helin ; Van Haaren, Harry >> Subject: Re: [dpdk-dev] [PATCH v7 1/2] eal: add uevent monitor for hot plug >> >> 09/01/2018 12:39, Guo, Jia: >>> So, how can separate the patch into more small patch, use stake or null implement in function. I think we should consider if it is a economic way now, if I could explain more detail in code for you all not very familiar the background? I have sent v8, please check, thanks all. >> The v8 is not split enough. >> Please try to address all my comments.