DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Joyce Kong <joyce.kong@arm.com>,
	jerinj@marvell.com, zhihong.wang@intel.com,
	xiaolong.ye@intel.com, ruifeng.wang@arm.com,
	honnappa.nagarahalli@arm.com, phil.yang@arm.com
Cc: dev@dpdk.org, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH v1] net/virtio: simplify variable name
Date: Tue, 30 Jun 2020 09:27:45 +0200
Message-ID: <5b72cb51-33bb-9673-c533-c3d7ce1d3cdf@redhat.com> (raw)
In-Reply-To: <20200624084510.35277-1-joyce.kong@arm.com>



On 6/24/20 10:45 AM, Joyce Kong wrote:
> Virtio_hw *hw has been pointed to vq->hw, it is better to use
> hw instead of vq->hw in later code.
> 
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
> ---
>  drivers/net/virtio/virtio_rxtx_simple_neon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/virtio/virtio_rxtx_simple_neon.c b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> index 363e2b330..8e6fa1fd7 100644
> --- a/drivers/net/virtio/virtio_rxtx_simple_neon.c
> +++ b/drivers/net/virtio/virtio_rxtx_simple_neon.c
> @@ -71,8 +71,8 @@ virtio_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
>  	 */
>  	uint16x8_t len_adjust = {
>  		0, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size, 0,
> -		(uint16_t)vq->hw->vtnet_hdr_size,
> +		(uint16_t)hw->vtnet_hdr_size, 0,
> +		(uint16_t)hw->vtnet_hdr_size,
>  		0,
>  		0, 0
>  	};
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime


  parent reply	other threads:[~2020-06-30  7:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-24  8:45 Joyce Kong
2020-06-24 19:45 ` Honnappa Nagarahalli
2020-06-28  4:57 ` Xia, Chenbo
2020-06-30  7:27 ` Maxime Coquelin [this message]
2020-06-30  7:41   ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b72cb51-33bb-9673-c533-c3d7ce1d3cdf@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=honnappa.nagarahalli@arm.com \
    --cc=jerinj@marvell.com \
    --cc=joyce.kong@arm.com \
    --cc=nd@arm.com \
    --cc=phil.yang@arm.com \
    --cc=ruifeng.wang@arm.com \
    --cc=xiaolong.ye@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git