From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4F25BA0A02; Tue, 18 May 2021 14:09:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C15244068E; Tue, 18 May 2021 14:09:14 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 01AE040041; Tue, 18 May 2021 14:09:11 +0200 (CEST) IronPort-SDR: 8lWXQSiuGyHYWKNLygkKW9fVurRphUNtmmgJxcKpV0uP2Ov+NZpu2mpMbgeeRWZ9JlRQNiXatQ p1FmaWU7TZ5Q== X-IronPort-AV: E=McAfee;i="6200,9189,9987"; a="187820432" X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="187820432" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 05:09:08 -0700 IronPort-SDR: EDriHYg05drdi60znLgtnmSaE0HDogNkucUgxfUEThDbSmVnVkOQswteCrdIAyrw/xHdBoFGTJ pZLRX2j7pQgg== X-IronPort-AV: E=Sophos;i="5.82,310,1613462400"; d="scan'208";a="439409944" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.224.73]) ([10.213.224.73]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 May 2021 05:09:03 -0700 To: Tianyu Li , Jakub Grajciar , "Damjan Marion (damarion)" Cc: "dev@dpdk.org" , nd , "stable@dpdk.org" References: <20210412082231.1866235-1-tianyu.li@arm.com> <252a9754-9d9d-36cf-dd4e-6326e604429d@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <5bb1142c-16f1-9a1b-4408-83c2857da9f2@intel.com> Date: Tue, 18 May 2021 13:08:44 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/memif: fix missing Tx-bps stats for zero-copy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/27/2021 7:30 AM, Tianyu Li wrote: > Hi Jakub, > > Any comments about the patch? > +Damjan. Hi Damjan, Is Jakub still maintaining the net/memif? > -----Original Message----- > From: Ferruh Yigit > Sent: Wednesday, April 14, 2021 4:13 PM > To: Tianyu Li ; Jakub Grajciar > Cc: dev@dpdk.org; nd ; stable@dpdk.org > Subject: Re: [PATCH] net/memif: fix missing Tx-bps stats for zero-copy > > On 4/12/2021 9:22 AM, Tianyu Li wrote: >> Fix the missing Tx-bps counter for memif zero-copy mode Before >> Rx-pps: 6891450 Rx-bps: 3528438928 >> Tx-pps: 6891482 Tx-bps: 0 >> After >> Throughput (since last show) >> Rx-pps: 11157056 Rx-bps: 5712413016 >> Tx-pps: 11157056 Tx-bps: 5712413016 >> >> Fixes: 43b815d88188 ("net/memif: support zero-copy slave") >> Cc: stable@dpdk.org >> >> Signed-off-by: Tianyu Li >> --- >> drivers/net/memif/rte_eth_memif.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/memif/rte_eth_memif.c >> b/drivers/net/memif/rte_eth_memif.c >> index 77c95bcb7..dd2825968 100644 >> --- a/drivers/net/memif/rte_eth_memif.c >> +++ b/drivers/net/memif/rte_eth_memif.c >> @@ -706,6 +706,7 @@ memif_tx_one_zc(struct pmd_process_private *proc_private, struct memif_queue *mq >> /* populate descriptor */ >> d0 = &ring->desc[slot & mask]; >> d0->length = rte_pktmbuf_data_len(mbuf); >> + mq->n_bytes += rte_pktmbuf_data_len(mbuf); >> /* FIXME: get region index */ >> d0->region = 1; >> d0->offset = rte_pktmbuf_mtod(mbuf, uint8_t *) - >> > > Looks good to me, but let's wait Jakub's review for it. >