From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 88F922C5 for ; Mon, 10 Apr 2017 17:01:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491836495; x=1523372495; h=subject:to:cc:references:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=ONYeVtYHifR9ndluTy7pEEsNp0QDaHXnW8Kgk3D6eN8=; b=GCjmCFlDU6WxnNYnfPKnEG/xNyLKBCKxCmbZXVfDhQcyLxUWsXf0A4Mf o3e/bakPaeWccYykF8pRl7Fc1TLn6g==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2017 08:01:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,182,1488873600"; d="scan'208";a="87290727" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 10 Apr 2017 08:01:32 -0700 To: Ed Czeck , dev@dpdk.org Cc: john.miller@atomicrules.com, shepard.siegel@atomicrules.com References: <1491827199-4853-1-git-send-email-ed.czeck@atomicrules.com> <1491827199-4853-2-git-send-email-ed.czeck@atomicrules.com> From: Ferruh Yigit Message-ID: <5bb8278f-a3b1-01bc-6161-33c73e9731a4@intel.com> Date: Mon, 10 Apr 2017 16:01:31 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <1491827199-4853-2-git-send-email-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/ark: report hardware status during PMD init X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 15:01:36 -0000 On 4/10/2017 1:26 PM, Ed Czeck wrote: > Expose additional fpga status registers and report > conditions during PMD init > > Signed-off-by: Ed Czeck > --- > drivers/net/ark/ark_ethdev.c | 9 +++++++++ > drivers/net/ark/ark_rqp.c | 6 ++++++ > drivers/net/ark/ark_rqp.h | 4 +++- > 3 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ark/ark_ethdev.c b/drivers/net/ark/ark_ethdev.c > index 93721a0..1a6c71c 100644 > --- a/drivers/net/ark/ark_ethdev.c > +++ b/drivers/net/ark/ark_ethdev.c > @@ -297,6 +297,15 @@ eth_ark_dev_init(struct rte_eth_dev *dev) > ark->sysctrl.t32[4], __func__); > return -1; > } > + if (ark->sysctrl.t32[3] != 0) { > + if (ark_rqp_lasped(ark->rqpacing)) > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - " Is this should be "info" level or debug, is end user interested if timer expired or not? > + "Timer has Expired\n"); > + else > + PMD_DRV_LOG(INFO, "Arkville Evaluation System - " btw, what is the logic in pmd, when to use PMD_DRV_LOG and when to use PMD_DEBUG_LOG? > + "Timer is Running\n"); > + } > + > Extra line. > PMD_DRV_LOG(INFO, > "HW Sanity test has PASSED, expected constant" <...>