From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63AA245A9A; Thu, 3 Oct 2024 10:25:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C8E94025E; Thu, 3 Oct 2024 10:25:28 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id A6E0C400D7 for ; Thu, 3 Oct 2024 10:25:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727943926; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=T0tc2hnWATcE9N1uQ6GscKxtNiC1S6i1RA/Id5cPIxY=; b=L92X4aD9KeP4KD797CbPgMYidNpPKluHxmWEANDvJe5YwnNC7Ac5qX49HShhvVYQNv6IzJ GXFUTW3hswm7YOx+bdocfN+4HbeNKQdC+vyKSOz4vYpY32NCEyGP4G2vNSjFF+NlKOiX7g cBIEZbc4tdOvBrbEfB20S3qjWBJshfg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-600-0LL17lm6NAmeMOp422TOBw-1; Thu, 03 Oct 2024 04:25:24 -0400 X-MC-Unique: 0LL17lm6NAmeMOp422TOBw-1 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-a8711c48990so46837366b.2 for ; Thu, 03 Oct 2024 01:25:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727943923; x=1728548723; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T0tc2hnWATcE9N1uQ6GscKxtNiC1S6i1RA/Id5cPIxY=; b=ULkKbZImBcUrrN6/On0L248kZ6oH5VQqIid0AdAzhZomUFbwXUA1CnKXXfyT6xFdYW ZNPAZAzVQlU1MmKwCjB92U25iOATHtzOswBMVz8mMTm+6pka8OaWItjWlr4eBtjrJB7L swI9a8AiBLIsZ+Z1H/dexHyfIBLj9EORDHPRvqZW5OVcjKrIagacP4JaVR5rQoLqe/Iw Y4l7AID2H11OvmD99cy4g78+4wym+PPclveHbCu+gPATEZP+mkMwmzEMN4/YFz9TPhS9 t74hAWueaQ+KOXxEYDoVv/p8xbUXhYM2kWK2hw9BvBbmrFz7T1udu9mFMj0vRxZh+vSE 2iYw== X-Gm-Message-State: AOJu0YwTlT6aNlBRZzgQ8D+gTOVnKD8L1Ng4+QByhzGC6sZC+25O6+Ji 1bk90j2hexUzYJ4rxpoTgWFf4FoOXel4XzstgvJoTEBbmvE5F6Bv+WPPrEG6I3t9uWzsrJeIuTF EzS6COGVc5IYv15XHUGF7RilhtSfVWEHWU6UBb5PT X-Received: by 2002:a17:906:d551:b0:a86:79a2:ab12 with SMTP id a640c23a62f3a-a98f826edd2mr675303566b.38.1727943923582; Thu, 03 Oct 2024 01:25:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkibPyILpDlz1m4K9qjmUdQtP8HfgSoXGlF77jPPGfpi25HkBKjcpmH5nzbn7IBzhbDJnHJw== X-Received: by 2002:a17:906:d551:b0:a86:79a2:ab12 with SMTP id a640c23a62f3a-a98f826edd2mr675300266b.38.1727943923150; Thu, 03 Oct 2024 01:25:23 -0700 (PDT) Received: from [192.168.0.36] ([78.17.184.32]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a99104c6785sm50033266b.204.2024.10.03.01.25.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Oct 2024 01:25:22 -0700 (PDT) Message-ID: <5bdb19bf-7ca9-43ca-bf74-7d2c0e2763b1@redhat.com> Date: Thu, 3 Oct 2024 09:25:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] eal/linux: fix VFIO hotplug with multiprocess To: David Marchand , Maxime Coquelin , Anatoly Burakov Cc: dev@dpdk.org, Luca Boccassi , "Xueming(Steven) Li" References: <20240916123044.2692301-1-david.marchand@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= xsFNBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABzSNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPsLBjgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71zsFNBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABwsF2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 02/10/2024 14:31, David Marchand wrote: > On Tue, Sep 17, 2024 at 10:20 AM Maxime Coquelin > wrote: >> On 9/16/24 14:30, David Marchand wrote: >>> At the moment, if VFIO is not available at DPDK init, it won't be >>> available unless a subsequent rte_vfio_enable() is done. >>> >>> Yet, even if rte_vfio_enable() is called again in primary and secondary >>> processes, a secondary process will never get to know that VFIO has been >>> enabled in the primary process as the MP requests handler is only >>> registered in EAL init. >>> >>> On the other hand, moving the MP requests handler registration earlier >>> in EAL init is ok, as secondary process are supposed to be waiting on >>> eal_mcfg_wait_complete() until the primary process calls >>> eal_mcfg_complete(). >>> >>> Move vfio_mp_sync_setup() in rte_vfio_enable(). >>> >>> Besides, rte_eal_vfio_setup() is useless and its name with a rte_ prefix >>> is ambiguous as it gives the impression it is an exported/public symbol. >>> Remove it and directly call rte_vfio_enable() where needed. >>> >>> Signed-off-by: David Marchand >>> --- >>> lib/eal/linux/eal.c | 18 +----------------- >>> lib/eal/linux/eal_vfio.c | 9 ++++++--- >>> 2 files changed, 7 insertions(+), 20 deletions(-) >>> >> >> Should it be considered as a fix, and so a candidate for stable? >> Or do you think it is too risky to change the behaviour? > > Cc: stable maintainers (fyi) > > I don't think it is risky: existing applications which relied on multi > process had no choice but to make sure VFIO was properly setup before > DPDK init. > Yet, a change in behavior impact is always hard to estimate. > > (same comment for the second patch of the series) > > They seem borderline fixes for usability. I think it's a good candidate for 22.11/23.11. For 21.11, it is the last release and the behaviour has been like that for 3 years, so would probably skip that one.