From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by dpdk.org (Postfix) with ESMTP id 9E8BA5424; Tue, 9 Apr 2019 12:40:13 +0200 (CEST) Received: by mail-wr1-f41.google.com with SMTP id g3so20177049wrx.9; Tue, 09 Apr 2019 03:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=QV6bQpYWFzZfT8IamTWVAOOQQ/VK28uYVJsnbTTl12c=; b=Qa8r/Al5d7PojKgscCVFylLTLcgjDL0QdkMEsW6ytK1nD5kMohlGTmzCV6DLN3lN3i /hPd+gHYTzj0kVykQwrlQCeL0EjCWbkxTOykPkcw9UoU6yZ09cbJE79Sb5Lv2ySDwnSv 3SgHTUpg+aOV2FbKPUsnAgS46NV033D9jXAtjgoEb0D7rbKRKie3Ct028/NtsE+WTUhC 5z+NnC/ZvDPk9s11RHFfj34cpOJFc6XrLl0odf1GJ7x6fIDou7cueTS1ZrJDSE9hMKxH +ok3Z02DpFzGC+Aa415jaUyZHYlGdkZ+NZzB1siwWsbzIH/WeYkPrPJErtDM83gDgprR a6Eg== X-Gm-Message-State: APjAAAXhZPSToV6KNBaTG2n4tyNdKinJYGHLqnyVEkO96w044pkpTBM8 3R2DdS6Oz5zBJqTZF9JT4tQ= X-Google-Smtp-Source: APXvYqwYZLx8Liv+a6ZdaofrNXBhO3KJ+0IWbd4U3gnBBsh13tdB/Ta82CNsblfEAugrM1x2FRzZ3Q== X-Received: by 2002:a5d:4750:: with SMTP id o16mr19495533wrs.206.1554806412132; Tue, 09 Apr 2019 03:40:12 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id c10sm40603244wru.83.2019.04.09.03.40.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:40:11 -0700 (PDT) Message-ID: <5bea441407568aceecee73c413378470e30c3305.camel@debian.org> From: Luca Boccassi To: David Marchand , Bruce Richardson Cc: dev , dpdk stable Date: Tue, 09 Apr 2019 11:40:10 +0100 In-Reply-To: References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Apr 2019 10:40:14 -0000 On Tue, 2019-04-09 at 12:34 +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson < > bruce.richardson@intel.com > > > wrote: >=20 > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > > <[1] > > > bruce.richardson@intel.com > > > > wrote: > > >=20 > > > The definition of CPU_AND differs from Linux to BSD, so we > > > need to > > > use > > > RTE_CPU_AND instead. > > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample > > > application for > > > PQoS CAT and CDP") > > > Cc: [2] > > > stable@dpdk.org > > >=20 > > >=20 > > > This creates a dependency on backporting c3568ea37670 ("eal: > > > restrict > > > control threads to startup CPU affinity") which introduced the > > > RTE_CPU_AND macro. > > > -- > > > David Marchand > > >=20 > >=20 > > Shall I drop the stable reference from the v2, then? > >=20 >=20 > We can backport in 18.11, as I would expect c3568ea37670 to be > backported. >=20 > The question is more what we want to do with 17.11. > We could backport only the macro bits from this patch if needed. If c3568 is not destined for 17.11.x, if you are up for doing the extra work you can send the macro-only change as an individual patch to=20 stable@dpdk.org (do not cc dev) and use --subject-prefix=3D'PATCH 17.11' - alternatively, the 17.11 maintainer can simply opt to not pick up this patch. --=20 Kind regards, Luca Boccassi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 4DE89A0096 for ; Tue, 9 Apr 2019 12:40:23 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83D4C5688; Tue, 9 Apr 2019 12:40:17 +0200 (CEST) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) by dpdk.org (Postfix) with ESMTP id 9E8BA5424; Tue, 9 Apr 2019 12:40:13 +0200 (CEST) Received: by mail-wr1-f41.google.com with SMTP id g3so20177049wrx.9; Tue, 09 Apr 2019 03:40:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=QV6bQpYWFzZfT8IamTWVAOOQQ/VK28uYVJsnbTTl12c=; b=Qa8r/Al5d7PojKgscCVFylLTLcgjDL0QdkMEsW6ytK1nD5kMohlGTmzCV6DLN3lN3i /hPd+gHYTzj0kVykQwrlQCeL0EjCWbkxTOykPkcw9UoU6yZ09cbJE79Sb5Lv2ySDwnSv 3SgHTUpg+aOV2FbKPUsnAgS46NV033D9jXAtjgoEb0D7rbKRKie3Ct028/NtsE+WTUhC 5z+NnC/ZvDPk9s11RHFfj34cpOJFc6XrLl0odf1GJ7x6fIDou7cueTS1ZrJDSE9hMKxH +ok3Z02DpFzGC+Aa415jaUyZHYlGdkZ+NZzB1siwWsbzIH/WeYkPrPJErtDM83gDgprR a6Eg== X-Gm-Message-State: APjAAAXhZPSToV6KNBaTG2n4tyNdKinJYGHLqnyVEkO96w044pkpTBM8 3R2DdS6Oz5zBJqTZF9JT4tQ= X-Google-Smtp-Source: APXvYqwYZLx8Liv+a6ZdaofrNXBhO3KJ+0IWbd4U3gnBBsh13tdB/Ta82CNsblfEAugrM1x2FRzZ3Q== X-Received: by 2002:a5d:4750:: with SMTP id o16mr19495533wrs.206.1554806412132; Tue, 09 Apr 2019 03:40:12 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:250:b6ff:feb7:bd60]) by smtp.gmail.com with ESMTPSA id c10sm40603244wru.83.2019.04.09.03.40.10 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Apr 2019 03:40:11 -0700 (PDT) Message-ID: <5bea441407568aceecee73c413378470e30c3305.camel@debian.org> From: Luca Boccassi To: David Marchand , Bruce Richardson Cc: dev , dpdk stable Date: Tue, 09 Apr 2019 11:40:10 +0100 In-Reply-To: References: <20190409092933.55356-1-bruce.richardson@intel.com> <20190409092933.55356-5-bruce.richardson@intel.com> <20190409100341.GB655@bricha3-MOBL.ger.corp.intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 4/5] examples/l2fwd-cat: fix build on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190409104010.QfVFq3mbFIhLLjIVozAZOYx4Ds2wblF7JLRX3-as-II@z> On Tue, 2019-04-09 at 12:34 +0200, David Marchand wrote: > On Tue, Apr 9, 2019 at 12:03 PM Bruce Richardson < > bruce.richardson@intel.com > > > wrote: >=20 > > On Tue, Apr 09, 2019 at 11:56:04AM +0200, David Marchand wrote: > > > On Tue, Apr 9, 2019 at 11:30 AM Bruce Richardson > > > <[1] > > > bruce.richardson@intel.com > > > > wrote: > > >=20 > > > The definition of CPU_AND differs from Linux to BSD, so we > > > need to > > > use > > > RTE_CPU_AND instead. > > > Fixes: f6baccbc2b3b ("examples/l2fwd-cat: add sample > > > application for > > > PQoS CAT and CDP") > > > Cc: [2] > > > stable@dpdk.org > > >=20 > > >=20 > > > This creates a dependency on backporting c3568ea37670 ("eal: > > > restrict > > > control threads to startup CPU affinity") which introduced the > > > RTE_CPU_AND macro. > > > -- > > > David Marchand > > >=20 > >=20 > > Shall I drop the stable reference from the v2, then? > >=20 >=20 > We can backport in 18.11, as I would expect c3568ea37670 to be > backported. >=20 > The question is more what we want to do with 17.11. > We could backport only the macro bits from this patch if needed. If c3568 is not destined for 17.11.x, if you are up for doing the extra work you can send the macro-only change as an individual patch to=20 stable@dpdk.org (do not cc dev) and use --subject-prefix=3D'PATCH 17.11' - alternatively, the 17.11 maintainer can simply opt to not pick up this patch. --=20 Kind regards, Luca Boccassi