From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40077.outbound.protection.outlook.com [40.107.4.77]) by dpdk.org (Postfix) with ESMTP id 73CE96CCC; Fri, 27 Apr 2018 13:58:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=z7KoEJETvVAP55joo0eC4972CKLnTUIyjXbWT1o1tQM=; b=CHd/URAd+oDEcClfFcUP/SohBwmsf3v92R4K0STGvc1PU5sFL00zotx9dDgBB39PlmJzuMwIOgZYSEgJ6fkkFHgLU0CiEycVs6cgkx7IMhnbvp7Kz33qHOeitiv3lZREMtiep85kznUm9lzeO1RBhAcMcIM6fPyEDEvyyqF0kzs= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.49] (14.142.187.166) by AM3PR04MB1379.eurprd04.prod.outlook.com (2a01:111:e400:536a::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.715.18; Fri, 27 Apr 2018 11:58:52 +0000 To: "De Lara Guarch, Pablo" , Akhil Goyal , "Zhang, Roy Fan" References: <20180426150950.7568-1-pablo.de.lara.guarch@intel.com> <5e2f48d7-c451-c550-5ddc-70263a278e2f@nxp.com> Cc: "dev@dpdk.org" , "stable@dpdk.org" From: Akhil Goyal Organization: NXP Message-ID: <5bec1a84-d91f-26cf-1a5d-2909c0906c8f@nxp.com> Date: Fri, 27 Apr 2018 17:28:39 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: PN1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:c00::19) To AM3PR04MB1379.eurprd04.prod.outlook.com (2a01:111:e400:536a::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:AM3PR04MB1379; X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 3:iTcjcvCr8oUJAc3GyCDnjoaOmiK4A24mZ9i7koyP8XroL2Q5pCipw+O/VfnlOMY0O+mQ1QMvd7z7gMCkRVEUgbls0PY/ldIX2PWeeYHeiIrlyFVG/c1H/N4VQeFaGZ8nx2x5F/DiA1aRW3QIfGzBEcECfOgRsKIJOWOBZt6faIymelnpzhgMLpbljPDf4dIRMkdtmV80xE0JGFuWvta8mCSy1WmvvHISa+VidXLoInpNu9TLrsH7G8AbPhtK+ScV; 25:slK3LudpXJb+QpJEXKtCCaP7FokKdr5qQ9WFr8UGBN1UWnPDuUjDadYZGlXEl+qi5xL1VqxakcRW8ULPBq/53yxROFZJjak51eM0HPwdQq2VOAcNv48RYk9Hxbd2nLzDDygX9FxDftqV6VwNq+RcPgnj3J1YiLavWXPU4ZZsBbpWs6kmyT1dP6c6C68aVEXYHClq1wcyyv9Qgxvedy87iIxZCYR82+6ZzSHCgk8uMuGlyzHyUsm2z3m9IfK5FmlmLZ/bBWfoYCTiUlnJxeC/0nQywo/7klFPB/9hZp0xrs5irK7IdGn/TpVbed2GXBeF2NJh6A3rbeB9m7G0gsjpiZ2MRqNSMQGPw+4Yni2GUrk=; 31:LBt9Qd0sAmRQHsDEvbNcnOSFR7Yd4OsrSXhQWmL7Xvk50W2zlaDs+yUyjPKZOjLZx+dxWzh0gt4lpRV3b6XfEIRjZUOf/snBOUl8yG9mBMAktbvUeS0i+lI8Ap8/0jK/EX+ju1JQPJwaf3q4agYj33UAZIHJgikeWzNloXA03ExLKowSDZavu6BJPJ0VExx8vnlcBSx6k9STbH5MwtH2ptxl0oKquwieHskVMtRnnfc= X-MS-TrafficTypeDiagnostic: AM3PR04MB1379: X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 20:/LirTWoegb/voscuBfMGJy3Y1wxit1CRhfyOyyQsX00od//q+cYvdSYe0gGNnR8DQwJUcwpqiEQuUkUHEDoE6jYo+9y2Ai5AfRn1Q4Zk+KxFsqhlP9fmpVBVhj/Aj9QEWtXPShcyhUgvNt/hyf2nmkctgbKyjpEvT9q3c7x8liJIw3a0mdtHsJo5nkqWkmldYHeS7LdNBO3L+GA5bOE193F8MDrwRbCXGc+D0mkH6eLQpJeTLrBPPbpfIAoNJTTxR9Hrca4g31FLyuaarCaDFF2oIzYg9+Oyywptsn1bAiO5EEeGlESjPuDMkuR3aHp06X7KYznvzuw6ap+eSSTxatO8DU98jRiqGqDGZttmpX5Abmd83fzyOCvkDUMei2oAnfL4xvCx6G0fM+Oiag6bmV/75RQhbeaGb00r19ym90FawXB0fmGbB/Y234K0IgQ7ZJZR8AsXGzi/XGxPBIrmdX5q9zCuj3Qcu3pwN5QoZHm7mGSYMnmWm+CPpN+EzYZi; 4:k8oMfWrvyVT8srsFEdbrhu2vxXsJjDwE1V/2NMRXtuhMoagvbFRJf2NeZt3fzevqNKxUdYFDIzOsLeQ22kYMS7O/GTmmHkc2u289jD3p+DT6JVUlqrRXvOkb0Y5E+II7CPqb4uS4jVmMe3DBf5heBWNuyWa+GNfJAj6iXkofJHe6ngvzzuTDmkAXgRETNBu7vkPam6zx0wzL6iA8RC9iPzP6GwWBAEWNcAem/CMpB/f5q+3h2rcjSEh99Fn1tTH/nw7G7/ODaBj3iU+jMz8I/RvAFzxVyacu0Ug79rDcdTuXi36DZCTKp9ZcLNupIPpqli1ho5xXfTy0iWT66Y91/gjj8e6ugrtrEN1s2R/y/ns= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231232)(944501410)(52105095)(93006095)(93001095)(6055026)(6041310)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:AM3PR04MB1379; BCL:0; PCL:0; RULEID:; SRVR:AM3PR04MB1379; X-Forefront-PRVS: 0655F9F006 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(396003)(366004)(39380400002)(39860400002)(376002)(52314003)(189003)(199004)(13464003)(36916002)(64126003)(50466002)(6666003)(52116002)(8676002)(81166006)(81156014)(76176011)(229853002)(65956001)(31686004)(3260700006)(25786009)(53936002)(8936002)(3846002)(6116002)(6486002)(305945005)(7736002)(4326008)(53546011)(386003)(26005)(66066001)(97736004)(478600001)(106356001)(105586002)(5660300001)(956004)(486006)(86362001)(36756003)(16526019)(55236004)(31696002)(2616005)(67846002)(54906003)(11346002)(110136005)(58126008)(65826007)(230700001)(476003)(47776003)(446003)(2906002)(316002)(44832011)(16576012)(5009440100003)(6246003)(65806001)(68736007)(186003)(77096007)(23746002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB1379; H:[10.232.134.49]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; AM3PR04MB1379; 23:i2lezzqhvjoobwsKMPb2Qet2m/iT0RhwtFFnz?= =?Windows-1252?Q?WFmAPS9lW1RdIdE5QpCGaSD3jgpcnVdaVDoukHbtKTuZnoc5bKQT0emC?= =?Windows-1252?Q?in0CbsR8hZhQLe37QeNq47va7E2mQi0NuniVdRPHLv8etprn1mYdfH7Z?= =?Windows-1252?Q?IsyNqPIHP3/3aFNEuMGDVeppOEtwqvXdt5WrP6BSGEFyOcIfEvYHuM5U?= =?Windows-1252?Q?uivtoJXY237Ef2kBebcVBqvNbNn3dsUD5A3XA7B1pNSgXnPisgkWLKy0?= =?Windows-1252?Q?SpB0o9A7/bfzH6qxXUHasnLgnKIlNB0tQgi2ZrccZBkHaujE2ue2o+Sd?= =?Windows-1252?Q?UsNO5v+mY78SGiu86dYq7TJcNd7EOF9IVwSZ4OB+wJPX6NwbJ/w5gzjY?= =?Windows-1252?Q?XgYpqHcMrW/P4mJcj0yU/IyqkIQSAyK7majZ5gE8cjnNji3ZPK/xe0nt?= =?Windows-1252?Q?fXKkqO1U5DpVfIy8cvdT0T0O+aqi5i9pE8/wAyptKg2FdihfAEj/ouPd?= =?Windows-1252?Q?S2tMSj0fELHoYfbHBMXrq5grw3xYBfbv9EDcv5f/r1748r3yxCsBioIc?= =?Windows-1252?Q?VI8plr22ZafNKn7i1B19X3jRWTs2nS85Xul5URo8RjsLQ8u8jjEENnkq?= =?Windows-1252?Q?bT/YDeinuVHcI2Bf20VI8RcSIYjnuLsjbgiLoDBaAl/uccBX+ib/QCXY?= =?Windows-1252?Q?Du8wu/aMLg5Z+FzsywTMNwMmih+G2kP/xzauTcGKFiuayUpzk2byIJq5?= =?Windows-1252?Q?6KhKRtGKCB2POVoARzhgLqQHphiDJ7O9o64Lc1TJP+WTJaJYOwULWvRu?= =?Windows-1252?Q?M/2r6E6NSh/a2kwvrnmVi7LHA73wF1Y2h9XaJman80hxGlNpzrQXhEAQ?= =?Windows-1252?Q?TIPXBCqS6zo5PPNF9wp8OOxgrQUcsplW1LaFoQ01mgDdE6G8OILfYFyz?= =?Windows-1252?Q?RfN8jshIHja1+a8FtQO8BpUV466U1RahJ6Ius1OsraSWdjuxSLW/nZ7T?= =?Windows-1252?Q?vDaGBgUKpkuFzKNgDlrhVfZqs6QuPsvjiqo9SWo+KWogQw/gCr8i2vxF?= =?Windows-1252?Q?mCH4D4lzjF27qJSAb6gvEz45tXFWkgerHCINxVDm1uQVGtfPNRUO9f6U?= =?Windows-1252?Q?q0GVWuAwoYQylFVaiV6HhSkZy4TLVkQxOeZgJq5+m72P7HZaNHqL7Rla?= =?Windows-1252?Q?oXt7IrNj8Me7VEX2AcuLzh96U+yU9NjcxpMvrNr0azN2Vd/lwRDcJGsJ?= =?Windows-1252?Q?P++V2e9AyVG3oYAtL0VkOSywGkEt+Vq0B660HDVTNEUdaIJlT48rAmQa?= =?Windows-1252?Q?IfulsLauzGiKds8r82/fIX+1KuUyPRgKjv7E74RqGo8+gz90WDs00s/x?= =?Windows-1252?Q?Biw6dmHrbHxEldfOlDuZbwP7bJXJ13IarVJCrAWdmZAMlXORALy/ipyJ?= =?Windows-1252?Q?cdzCYSfwM4vQggyw14lG7Y+xonUFhO18noFkFg1wYwrABw7HOj2S8LKM?= =?Windows-1252?Q?ig41MsCucnVmwqMZtAaEe5hpavadkqRSoloGa5yZL6+iFrVncy52yXaq?= =?Windows-1252?Q?nGJ7lki/NSeYfTZEwPg9FwuqekAaxHbS9lKaUuw+SH+FN1am3W5ojP2k?= =?Windows-1252?Q?kuIPn3t59U2hbew4few/0xgXkXL4S3SgwI+Xn5wyjz1Sa3/6UsPcGpjs?= =?Windows-1252?Q?Dt4wJa4ISUQ/i7fWF8S5QoAiZxIHrwpRmloGFXVtbGH2YZFbTTF?= X-Microsoft-Antispam-Message-Info: 5g/zcqmbbJ7guu3XaKg4kP0ueCSKaowo17LwcMHh8Rzbx+lP60rcLjFaLvHja3NkYnR6VLzKHJC5mjG50VObueLDZRhmqkR7Af+qEa118mArH6tmwOnRKAOEAKzi88dYIYHXA8wHmVLi4NUVqVtvBc7BOJuFkN0CKxXcj4Iir0/xxNAe1OPgQPXc1QzdcItX X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 6:zcdyHjoYNpAbSQKgDcPy8tMT5TYJcKL7ZaQW9NdzBOa2ZMWiY8KA4B94aNLBmMV+of5R4Sa3cpb8aAtQ3y6ajlsENYIcDknuXkb6QY3Gt0jNuuzpvfmn1GQZRq08wi+bHl8jfX7Y65nA13Ls2Dl4gYn4FmJ4zXgt2WIrKHpEKbUKue+d93uqQG31ymkSwLXvGNQluiaFUTZb6g48RuK4RKyZp/cQV/y7slYNP9VjzQC5Q0gEsT852suG2TGxOiYLWvvW9alY/rcBffEvyBJy9YkdxcsIrGDcwQp6ExOSfsUM3nfqr5XXzgWLFIgsuID/EFfn+fTVHIapjsJ4tE0hFAHiP/iIeXOyprH0YVmCapPHDaNNWIBGGjpOiNkKK52pgiO8cDSndCW968tgPFT7STJMm0VgkAaxNMskZv5ciay8vM5+KVbmuNQMXsUsaSEze8YVZHn6p0sbJctM4CjXXA==; 5:qn+h9FbIOTkea04Fb0yX/962syh0kOGB5skU1BQjM/nbMMlryrXn2lFwLG8RnOykw/LSSflUW4Eo7L+gmg7jlINpcsOrUwt042/Opdz7wgznbRGwBmv0qrBk37IdMk9Qmhgg1mk3fxQsF6eAqbc/EQt5SZoxGiYHErUwDb60n/E=; 24:AeD7SUHsos86w+uA7LHvqKhWAyvFjEkhf4XARTLUw7fQPq3+IVI80yJtLe0CsN+swhMwtgbTQGj4bcLRJon41iSZlv88QdQfYLyjEqAMWVs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1379; 7:Z590g6PqODTtCNPCy84pw9vtRupxOAbHuGyV4/AQoGFcjkZvFESiO/fPpSGRduD6VhGHkz+9atRaEN7frDpY8ZuDObFB2296QOVl4PKp1UUk0e1SySZICbgWp071GFx+Sr4t4B3LV+Ddq5liI9T+Ix5ADzlSzkDIbDLqBQ7BqM0PNhv5c5ZrytjEOrr/BsLVTXFnJt14oo/K8pGASqjYUibEqrdsRW2gOxQvCL7IPhF6m9cc7wMNz2sI3Pxs+wZr X-MS-Office365-Filtering-Correlation-Id: 34032abf-5e99-4c5b-fe9d-08d5ac363f59 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2018 11:58:52.2827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 34032abf-5e99-4c5b-fe9d-08d5ac363f59 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1379 Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after freeing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 11:58:54 -0000 Hi Pablo, On 4/27/2018 5:06 PM, De Lara Guarch, Pablo wrote: > Hi Akhil, > >> -----Original Message----- >> From: Akhil Goyal [mailto:akhil.goyal@nxp.com] >> Sent: Friday, April 27, 2018 9:47 AM >> To: De Lara Guarch, Pablo ; Zhang, Roy Fan >> >> Cc: dev@dpdk.org; stable@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] crypto/scheduler: set null pointer after >> freeing >> >> Hi Pablo, >> >> On 4/26/2018 8:39 PM, Pablo de Lara wrote: >>> When freeing memory, pointers should be set to NULL, to avoid memory >>> corruption/segmentation faults. >> >> Shouldn't this be handled in the rte_free itself. A lot of other driver are also not >> setting null after rte_free. >> This would require change at a lot of places if this is not handled in rte_free. >> > > The glibc function "free" works the same way. Users are responsible for > setting to NULL these pointers (because sometimes, it is not necessary to do such thing). Yes it is correct but rte_free is custom free API in DPDK which can be modified or we can have a safer API rte_free_safe which can set the pointer to null. > > Anyway, in case we still wanted to change it, we would need to pass a pointer > to a pointer in rte_free, which would imply an API breakage. > I think if the community agrees, we can add this change may be in next releases. > Thanks, > Pablo > >> Thanks, >> Akhil