From: Cunming Liang <cunming.liang@intel.com> To: dev@dpdk.org Subject: [dpdk-dev] [PATCH 4/5] ixgbe: set default burst size 32 in testpmd Date: Thu, 26 Jun 2014 14:53:33 +0800 Message-ID: <5c0292936e0ba9c8748820e5c4c13914bf0e44dc.1403759017.git.cunming.liang@intel.com> (raw) In-Reply-To: <cover.1403759017.git.cunming.liang@intel.com> In-Reply-To: <cover.1403759017.git.cunming.liang@intel.com> The vpmd RX don't accept burst size less than 32. As vPMD is set =y by default, while default testpmd burst size is 16. Which will cause RX nothing if not assign burst size correctly. Signed-off-by: Cunming Liang <cunming.liang@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Yong Liu <yong.liu@intel.com> Tested-by: Zhaochen Zhan <zhaochen.zhan@intel.com> --- app/test-pmd/testpmd.h | 2 +- lib/librte_pmd_ixgbe/ixgbe_rxtx.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 5839f93..7e3beb6 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -63,7 +63,7 @@ int main(int argc, char **argv); #define RTE_MAX_SEGS_PER_PKT 255 /**< pkt.nb_segs is a 8-bit unsigned char. */ #define MAX_PKT_BURST 512 -#define DEF_PKT_BURST 16 +#define DEF_PKT_BURST 32 #define CACHE_LINE_SIZE_ROUNDUP(size) \ (CACHE_LINE_SIZE * ((size + CACHE_LINE_SIZE - 1) / CACHE_LINE_SIZE)) diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c index 7f05b26..a5c8228 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx.c @@ -2168,7 +2168,8 @@ ixgbe_dev_rx_queue_setup(struct rte_eth_dev *dev, dev->rx_pkt_burst = ixgbe_recv_pkts_bulk_alloc; #ifdef RTE_IXGBE_INC_VECTOR if (!ixgbe_rx_vec_condition_check(dev)) { - PMD_INIT_LOG(INFO, "Vector rx enabled.\n"); + PMD_INIT_LOG(INFO, "Vector rx enabled, please make " + "sure RX burst size no less than 32.\n"); ixgbe_rxq_vec_setup(rxq, socket_id); dev->rx_pkt_burst = ixgbe_recv_pkts_vec; } -- 1.8.1.4
next prev parent reply other threads:[~2014-06-26 6:53 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-26 6:53 [dpdk-dev] [PATCH 0/5] ixgbe: vPMD compiling issue and testpmd default value change Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 1/5] ixgbe: avoid compiler error when RTE_IXGBE_INC_VECTOR=y and RTE_LIBRTE_IXGBE_RX_ALLOC_BULK_ALLOC=n Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 2/5] ixgbe: fix vpmd compiling error when RTE_LIBRTE_IEEE1588=y Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 3/5] ixgbe: not 'DISABLE' may make confuse, change RTE_IXGBE_RX_OLFLAGS_DISABLE=n to RTE_IXGBE_RX_OLFLAGS_ENABLE=y Cunming Liang 2014-06-26 6:53 ` Cunming Liang [this message] 2014-06-26 6:53 ` [dpdk-dev] [PATCH 5/5] testpmd: change some of testpmd default parameter to well tuned value Cunming Liang 2014-06-26 12:33 ` [dpdk-dev] [PATCH 0/5] ixgbe: vPMD compiling issue and testpmd default value change Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5c0292936e0ba9c8748820e5c4c13914bf0e44dc.1403759017.git.cunming.liang@intel.com \ --to=cunming.liang@intel.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git