From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9912DA0503; Tue, 17 May 2022 15:22:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F42740042; Tue, 17 May 2022 15:22:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0ECCB40041 for <dev@dpdk.org>; Tue, 17 May 2022 15:22:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1652793765; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6QiinKIqo/nmxSWyykkeG740sI2eMPs5I/gpfJ+tWUU=; b=LYQRO0Zp8W/ybVfH9pkk1FF+aRfY9ienWFlwpTFUMiOqGuoK84IkziCvrt/AyK7NHhkDA6 82fquvasGA1pagTZ6c2fwqhT6RHi2ivrZP2Iw62sbCcx5awW03+6LrbRe7Ty66jgrnGLy0 3KcAP2Ej7FiOxx1xb3EtImdzkdystss= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-358-Rvtx9-JBMiaIs3r8f4jOpw-1; Tue, 17 May 2022 09:22:40 -0400 X-MC-Unique: Rvtx9-JBMiaIs3r8f4jOpw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 70FC78015BA; Tue, 17 May 2022 13:22:39 +0000 (UTC) Received: from [10.39.208.44] (unknown [10.39.208.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1D47DC28100; Tue, 17 May 2022 13:22:37 +0000 (UTC) Message-ID: <5c13b483-fdb9-22a3-dcbd-848908df1e27@redhat.com> Date: Tue, 17 May 2022 15:22:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.1.0 Subject: Re: [PATCH v8 0/5] vhost: support async dequeue data path To: xuan.ding@intel.com, chenbo.xia@intel.com Cc: dev@dpdk.org, jiayu.hu@intel.com, cheng1.jiang@intel.com, sunil.pai.g@intel.com, liangma@liangbit.com References: <20220407152546.38167-1-xuan.ding@intel.com> <20220516111041.63914-1-xuan.ding@intel.com> From: Maxime Coquelin <maxime.coquelin@redhat.com> In-Reply-To: <20220516111041.63914-1-xuan.ding@intel.com> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org On 5/16/22 13:10, xuan.ding@intel.com wrote: > From: Xuan Ding <xuan.ding@intel.com> > > The presence of asynchronous path allows applications to offload memory > copies to DMA engine, so as to save CPU cycles and improve the copy > performance. This patch set implements vhost async dequeue data path > for split ring. The code is based on latest enqueue changes [1]. > > This patch set is a new design and implementation of [2]. Since dmadev > was introduced in DPDK 21.11, to simplify application logics, this patch > integrates dmadev in vhost. With dmadev integrated, vhost supports M:N > mapping between vrings and DMA virtual channels. Specifically, one vring > can use multiple different DMA channels and one DMA channel can be > shared by multiple vrings at the same time. > > A new asynchronous dequeue function is introduced: > 1) rte_vhost_async_try_dequeue_burst(int vid, uint16_t queue_id, > struct rte_mempool *mbuf_pool, struct rte_mbuf **pkts, > uint16_t count, int *nr_inflight, > uint16_t dma_id, uint16_t vchan_id) > > Receive packets from the guest and offloads copies to DMA > virtual channel. > > [1] https://mails.dpdk.org/archives/dev/2022-February/234555.html > [2] https://mails.dpdk.org/archives/dev/2021-September/218591.html > > v7->v8: > * change dma_id to int16_t > * refine API documentation > > v6->v7: > * correct code formatting > * change some functions to inline > > v5->v6: > * adjust EXPERIMENTAL header > > v4->v5: > * rebase to latest DPDK > * add some checks > > v3->v4: > * fix CI build warnings > * adjust some indentation > * pass vq instead of queue_id > > v2->v3: > * fix mbuf not updated correctly for large packets > > v1->v2: > * fix a typo > * fix a bug in desc_to_mbuf filling > > RFC v3 -> v1: > * add sync and async path descriptor to mbuf refactoring > * add API description in docs > > RFC v2 -> RFC v3: > * rebase to latest DPDK version > > RFC v1 -> RFC v2: > * fix one bug in example > * rename vchan to vchan_id > * check if dma_id and vchan_id valid > * rework all the logs to new standard > > Xuan Ding (5): > vhost: prepare sync for descriptor to mbuf refactoring > vhost: prepare async for descriptor to mbuf refactoring > vhost: merge sync and async descriptor to mbuf filling > vhost: support async dequeue for split ring > examples/vhost: support async dequeue data path > > doc/guides/prog_guide/vhost_lib.rst | 6 + > doc/guides/rel_notes/release_22_07.rst | 5 + > doc/guides/sample_app_ug/vhost.rst | 9 +- > examples/vhost/main.c | 286 ++++++++++----- > examples/vhost/main.h | 32 +- > examples/vhost/virtio_net.c | 16 +- > lib/vhost/rte_vhost_async.h | 37 ++ > lib/vhost/version.map | 2 +- > lib/vhost/vhost.h | 1 + > lib/vhost/virtio_net.c | 473 ++++++++++++++++++++++--- > 10 files changed, 715 insertions(+), 152 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime