From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2C3952C48 for ; Wed, 5 Jul 2017 19:24:24 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jul 2017 10:24:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,312,1496127600"; d="scan'208";a="104741865" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga004.jf.intel.com with ESMTP; 05 Jul 2017 10:24:22 -0700 To: Declan Doherty , dev@dpdk.org Cc: Tomasz Kulasek References: <20170705163023.9595-1-declan.doherty@intel.com> <20170705170912.31346-1-declan.doherty@intel.com> From: Ferruh Yigit Message-ID: <5c2cb123-75b5-66f8-12c5-85a8015dd4fc@intel.com> Date: Wed, 5 Jul 2017 18:24:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170705170912.31346-1-declan.doherty@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5] net/bond: fixes for link properties management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 17:24:25 -0000 On 7/5/2017 6:09 PM, Declan Doherty wrote: > From: Tomasz Kulasek > > This patch fixes the management of link properties in the bonded device. > > In all mode except mode 4 a bonded device link will default to reporting > the link as full duplex and auto-neg. The link speed for a bond port is > calculated on it's active slaves and the particular mode it is running > in. The bonding link speed is reported based on the transmit link as in > some modes link speed between egress/ingress is not symmetrical. > > - round-robin, balance, 802.3ad, TLB and ALB modes all report the link > speed as the sum of the speed of each active slave. > - active backup link speed is reported as the speed of the current > primary slave > - broadcast is reported as the minimum of value of the active slaves > link speeds. > > In mode 4 (link aggregation 802.3ad) the properties of the first slave > added to the bonded device are slave and subsequent slaves are verified > to have the same properties. > > Finally in the bond_ethdev_lsc_event_callback function the link > properties of the device are updated after any change to the number of > active slaves. > > Signed-off-by: Declan Doherty Gcc is throwing another warning [1]. And can you please send next version as full patchset, for the sake of the traceability of merged patches in the future. [1] .../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c: In function ‘bond_ethdev_lsc_event_callback’: .../dpdk/drivers/net/bonding/rte_eth_bond_pmd.c:2472:39: error: variable ‘slave_eth_dev’ set but not used [-Werror=unused-but-set-variable] struct rte_eth_dev *bonded_eth_dev, *slave_eth_dev; ^~~~~~~~~~~~~