From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Olivier Matz <olivier.matz@6wind.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net: be more restrictive in accepted ether string formats
Date: Fri, 19 Jul 2019 18:46:43 +0100 [thread overview]
Message-ID: <5c6d22b5-2500-a64d-5038-d6e7aaa2b32a@intel.com> (raw)
In-Reply-To: <20190719134220.cub63h245m5yrehx@platinum>
On 7/19/2019 2:42 PM, Olivier Matz wrote:
> On Thu, Jul 18, 2019 at 11:35:44AM -0700, Stephen Hemminger wrote:
>> The current ether_unformat_addr code was based off of
>> BSD ether_aton. That version changed what was allowed
>> by the cmdline ether address parser.
>> For example, it allows dropping leading zeros.
>>
>> Change the code to be more restrictive and only allow the fully
>> expanded standard formats.
>>
>> Bugzilla ID: 324
>> Fixes: 596d31092d32 ("net: add function to convert string to ethernet address")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2019-07-19 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 18:49 [dpdk-dev] [RFC] net: be more restrictive in ether_unformat_addr Stephen Hemminger
2019-07-18 7:47 ` Olivier Matz
2019-07-18 18:29 ` Stephen Hemminger
2019-07-18 18:35 ` [dpdk-dev] [PATCH v2] net: be more restrictive in accepted ether string formats Stephen Hemminger
2019-07-19 13:42 ` Olivier Matz
2019-07-19 17:46 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c6d22b5-2500-a64d-5038-d6e7aaa2b32a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).