From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Bruce Richardson" <bruce.richardson@intel.com>,
"Morten Brørup" <mb@smartsharesystems.com>
Cc: thomas@monjalon.net, arybchenko@solarflare.com,
jia.guo@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements
Date: Fri, 30 Oct 2020 09:27:04 +0000 [thread overview]
Message-ID: <5c70bcf3-f596-f2e2-beca-160aa7237f11@intel.com> (raw)
In-Reply-To: <20201027102415.GB936@bricha3-MOBL.ger.corp.intel.com>
On 10/27/2020 10:24 AM, Bruce Richardson wrote:
> On Mon, Sep 14, 2020 at 01:05:11PM +0200, Morten Brørup wrote:
>> Updated description of rte_eth_rx_burst() to reflect what drivers,
>> when using vector instructions, expect from nb_pkts.
>>
>> Also discussed on the mailing list here:
>> http://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35C61257@smartserver.smartshare.dk/
>>
>> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
>> ---
>> lib/librte_ethdev/rte_ethdev.h | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
>> index 70295d7ab..41f8ba4ef 100644
>> --- a/lib/librte_ethdev/rte_ethdev.h
>> +++ b/lib/librte_ethdev/rte_ethdev.h
>> @@ -4469,6 +4469,10 @@ int rte_eth_dev_hairpin_capability_get(uint16_t port_id,
>> * burst-oriented optimizations in both synchronous and asynchronous
>> * packet processing environments with no overhead in both cases.
>> *
>> + * @note
>> + * Some drivers using vector instructions require that *nb_pkts* is
>> + * divisible by 4 or 8, depending on the driver implementation.
>> + *
>> * The rte_eth_rx_burst() function does not provide any error
>> * notification to avoid the corresponding overhead. As a hint, the
>> * upper-level application might check the status of the device link once
>> @@ -4485,6 +4489,7 @@ int rte_eth_dev_hairpin_capability_get(uint16_t port_id,
>> * must be large enough to store *nb_pkts* pointers in it.
>> * @param nb_pkts
>> * The maximum number of packets to retrieve.
>> + * The value must be divisible by 8 in order to work with any driver.
>> * @return
>> * The number of packets actually retrieved, which is the number
>> * of pointers to *rte_mbuf* structures effectively supplied to the
>> --
>
> This correctly documents the current situation, so following the discussion
> on-list:
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2020-10-30 9:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-14 11:05 Morten Brørup
2020-09-14 11:26 ` Bruce Richardson
2020-09-14 12:42 ` [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pktsrequirements Morten Brørup
2020-10-13 10:55 ` Ferruh Yigit
2020-10-14 8:26 ` [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst()nb_pktsrequirements Morten Brørup
2020-10-14 8:53 ` Thomas Monjalon
2020-10-14 9:29 ` Bruce Richardson
2020-10-14 11:14 ` Morten Brørup
2020-10-14 11:38 ` Bruce Richardson
2020-10-15 7:36 ` Morten Brørup
2020-10-26 15:06 ` [dpdk-dev] [PATCH] ethdev: rte_eth_rx_burst() nb_pkts requirements Morten Brørup
2020-10-26 15:15 ` Ajit Khaparde
2020-10-27 10:24 ` Bruce Richardson
2020-10-30 9:27 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c70bcf3-f596-f2e2-beca-160aa7237f11@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=mb@smartsharesystems.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).