From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9BB7AA0C4C;
Tue, 5 Oct 2021 17:19:10 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 6D60F413CB;
Tue, 5 Oct 2021 17:19:10 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by mails.dpdk.org (Postfix) with ESMTP id 753AA413BF
for <dev@dpdk.org>; Tue, 5 Oct 2021 17:19:08 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="289275384"
X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="289275384"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
05 Oct 2021 08:19:07 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="521868495"
Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15])
by orsmga001.jf.intel.com with ESMTP; 05 Oct 2021 08:19:07 -0700
Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by
ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Tue, 5 Oct 2021 08:19:07 -0700
Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by
ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12; Tue, 5 Oct 2021 08:19:06 -0700
Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by
orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 08:19:06 -0700
Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169)
by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.1.2242.12; Tue, 5 Oct 2021 08:19:06 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=g88nshvUnhXkOHKoUJ6YVvG82+lwSuQmMpgAAhbTf9cm704+6aK7ju8mGQuMXBRiHaIsrVvYS0wxGVE6xJkfRtJfYrtzXzl/1qZi8D8eXHinm9RsV59L/BilWX8kTGZvmbW/b/8eW6N6NjUZzIF8KsX3qZrsUXyRbv8hQ+fGVmGAKuDAyCIRDNeHZxv8nWKEZIRz/C1kVicdXokh7tB60KYqH9eVGb9FD1sk9tn47BCP1uImq+zmUehm0kafr4WspzeuDctjptBMkjhKmaJvHre/ojgPBG27+M8rDNmoSCWiKdgcjaJtMLGd6a3ijtKUeO1z3ynxeMCztmQNUrjsVg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=XC07INYSqk0/RSzw2n2MlFN/dWRS+s7tRngHqjvJ6gk=;
b=fHSTmozSiDbbcKHitYj56GLBHbAz5cp9r9qj70McV39Cplde0gZReQ4lbCHnP2VwnjfKRoy8xQWd9BUTODl7eERc6iRHa1woeRjtPLmGqn6OWn2MBaLEirtWZpT7xEx3YMbr2KxY0z0csqFFiT9+UhNLoPx7lbtyW/Hmk9JmGZITZdSHepRTpZg0EjxbdQnmhpUpVPiVmy+yKMN42dfGCYwY/8rOf+RL353mHAGgj30LZcystQUYs5j4JHTjnyNZgFCzZMGswDS4CFsvcf8wfjDmu9dGzY93+mf33Agzn9xGtFduEHFGUZDkTHscCidCGlWabSxYCNMn4d1dJzZdYg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com;
s=selector2-intel-onmicrosoft-com;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=XC07INYSqk0/RSzw2n2MlFN/dWRS+s7tRngHqjvJ6gk=;
b=JqNwlfIoJrYZGl//RKYDtNje2L8Qu+VTMKHh+jvEHWTsp8uMhSPo/AgLKVnzQGp4pcyB2aveNJQUskVurbWPrJYLpOCL66c89RV7LjtoItvH9RLTbPq4h0fprmZYjdESYJP5tYjUCjIxrQwhwja18WrD1K198ryjAFKwbPZFshY=
Authentication-Results: dpdk.org; dkim=none (message not signed)
header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com;
Received: from SA2PR11MB5210.namprd11.prod.outlook.com (2603:10b6:806:fa::23)
by SN6PR11MB2623.namprd11.prod.outlook.com (2603:10b6:805:5d::24)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.19; Tue, 5 Oct
2021 15:19:04 +0000
Received: from SA2PR11MB5210.namprd11.prod.outlook.com
([fe80::e5f6:85a1:af0d:705e]) by SA2PR11MB5210.namprd11.prod.outlook.com
([fe80::e5f6:85a1:af0d:705e%7]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021
15:19:04 +0000
To: <dev@dpdk.org>
References: <20210915141030.23514-1-bruce.richardson@intel.com>
<20211005135909.726091-1-bruce.richardson@intel.com>
<20211005135909.726091-3-bruce.richardson@intel.com>
From: Conor Walsh <conor.walsh@intel.com>
Message-ID: <5c88aa93-4905-b485-7125-0078700cc030@intel.com>
Date: Tue, 5 Oct 2021 16:18:58 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
Thunderbird/78.14.0
In-Reply-To: <20211005135909.726091-3-bruce.richardson@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-ClientProxiedBy: DB6PR0801CA0043.eurprd08.prod.outlook.com
(2603:10a6:4:2b::11) To SA2PR11MB5210.namprd11.prod.outlook.com
(2603:10b6:806:fa::23)
MIME-Version: 1.0
Received: from [192.168.1.10] (109.78.83.30) by
DB6PR0801CA0043.eurprd08.prod.outlook.com (2603:10a6:4:2b::11) with Microsoft
SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.20.4587.18 via Frontend Transport; Tue, 5 Oct 2021 15:19:04 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: b6197ec4-295e-4efd-445f-08d9881377d4
X-MS-TrafficTypeDiagnostic: SN6PR11MB2623:
X-Microsoft-Antispam-PRVS: <SN6PR11MB2623DFEDEF36906F6EE3D842FFAF9@SN6PR11MB2623.namprd11.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7691;
X-MS-Exchange-SenderADCheck: 1
X-MS-Exchange-AntiSpam-Relay: 0
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: jwCw/hO/VOpnYT+Mj7ljazZEC3yEZ0D/dEI0FpFnD32ISJcnjYBQXQzJD9x7EfkLRyVk6C94tnllztlMwNqV88VoQIDNL9SbWyI247KMwyo0hV7z0N1LSJgYCG6pKHUlObrCeRp5khh6B9RwwNoF2vz2KTbXT3Ok9uIlD1YXsYs78/H1yZHq6eZ3cGXPdp0V6bZsfgNEXF7uvdGb0RBw9eb97KaGNuFqX5TRrwgStZXBVYNX7Ix6zpQzEgCNqB/KveMx3ioFFjVF0vB8ljQ/Q6EqmsqWVYlCg0ZaArLpDpQ1uNPUPqKSDLA7Ed6LoshTiZAMMlVuIQDPnLmXM7GhInZKA0AaGfmGzEvtzLlv4npOhgiOml8sd+Pv/1w0kZ/w03D5549l1mw/p9UbeKLqtMygE0inf308j3gJTN1kts9vQJGAfdXMI9V3sByftOQU789wjCRBmBP3JT14qgvq3Lb2JMQHAUvQfXh3x9LRjwZ3s53KbsGs3C8u37IbBq6jpL0MFVSnJmq8/CJHo8Oo9zjPgzfKnn2mGscbx4IocgkJ1FL42OFoyMxwwqKoTdjnni+v9Ravg7N4XP6wNnNBclIj8JTCvl9RSyhYlQoUHoWP5QpDdxoP4WHzEGyrW6Gu72WbnZWT5xHeKt2W1fkMNMM7qQjc2Fh/HbKpTUtoy6lmWegTqE1xTU56Z3u/1CQRL/sQLKasLJ5mCPcKE5pAgwn8uzo7aXcpJPLn7gMgo00=
X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
IPV:NLI; SFV:NSPM; H:SA2PR11MB5210.namprd11.prod.outlook.com; PTR:; CAT:NONE;
SFS:(4636009)(366004)(6916009)(66946007)(53546011)(66556008)(66476007)(83380400001)(8936002)(8676002)(31686004)(6666004)(6486002)(16576012)(38100700002)(316002)(36756003)(44832011)(26005)(508600001)(186003)(31696002)(86362001)(2906002)(2616005)(956004)(5660300002)(43740500002)(45980500001);
DIR:OUT; SFP:1102;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWprNDlPZzQ0enkzdFBtSC9ud2JBZTY5Rm5MbEZ4U0crL1M0bGMxUFA5eG5s?=
=?utf-8?B?WnVWc2lyQUNTVjFzd0llMUNqb0preSs0aDdFOTlMenpiZU93L29vSGFReXdE?=
=?utf-8?B?NUN6VmdaOFV4TUt4SHZrOTZ4T2VqbzcxU3JqNVFHOTBZN2V0d1hYcDMxUms0?=
=?utf-8?B?eWFwd1UrUTZLY2xjQ3BmbStqSFA1TWsrOUFPQ2ZURFFJTXlQQlh4TzN2Q0hv?=
=?utf-8?B?Slp0dERvUnhQWDQ2OElEYlZGaklHYmVUaG4xZnpoQkNVNU1mUkFYS2k1OWEy?=
=?utf-8?B?Vlo2c3N2QlZaY29hbFczTVNuTUllbUpCaWp2NHZVQXB5czZBMmxNUGdibEE5?=
=?utf-8?B?NHpwY25kaXFWQXJnWUJPU0RjT0MxeU5MTlhuYWlHY3E3UnhLTlV4amR0THUy?=
=?utf-8?B?b1BwbmRVV2lrVUgvL05ZcThrWmdQQXFZUU55RmFhcGZQMG9UQlcrK0VaYlpl?=
=?utf-8?B?ZTUxOTVpTXJwWldpWVRFRjEzS3g3Z0lTa0UxaXlWdmpSK3FGVWo0SXpZb1Bl?=
=?utf-8?B?SVBuYm5tekhJSGJLNEVCSm84dUtsa0VrY2FpWHQ3L3NqYVVtdkorYktUL3RS?=
=?utf-8?B?eUQvZ3RWZUNlbkdrMzJkY1pBaUg4N01hdVp2aUxOVHdiR2JJRzlEY3dhbW91?=
=?utf-8?B?amEvemdkU3I4WkNpeUVHTUR2ZU95ZWJMNklEZFQ4clVVL0s4c3VyZU9WcUo0?=
=?utf-8?B?a2w4QUphcW1ITGg0bkZ1YjBVWmM2Vkd1UGZ0b054U041RndRVjRmbmhib0cy?=
=?utf-8?B?WStiKzVIYmFnVlprUDU1WXpsR0FMZVJwUTFUM05ISUt6emlPZWRheHRXeTEw?=
=?utf-8?B?VTFZRGFFQm55YTQ3ZUNpSGFDcFNNTkxGY0NBZEhKMFMvSkNvdzAwdlQ3cWdM?=
=?utf-8?B?cUVyR3N0eG9QR2s0d004OVR0OE9wa1pIVzFmUWxNcHFYdHJ4SEZGOU8wWEJX?=
=?utf-8?B?TFIrMmtlbUJwSkcwK1VsbHRPN2NBTUxBMFEyd3JVKzJ0dTZXS1F4WGN0Z2x1?=
=?utf-8?B?RHN1dUJzdmtqRTdaSE1DSHh2Mm5WN0owUnFxUkFXeHEwSzM3Tk9pSTRLZ0FW?=
=?utf-8?B?UXRYSElOZCtHM1g1RUZaOStDc2x6cWUvc1BiNlV1bnhmU1pFaVI5bDdhd0FT?=
=?utf-8?B?SW1CSmdJbkVqbFZydVI4VjNMVVlkS3BvYlIyVmhUVWNGSlMwTWhVL0REdmFT?=
=?utf-8?B?N0x0Y3NUVnBud1JQWktIeUxvWm9kVnVCUGd5SDdsdU5qM3hkMmV4cE10bW16?=
=?utf-8?B?S2Y5UVNmajBuQmVvd2NaM3J3bmxZckR6aW1LSUhjdi9nTjQ1R3dlOTBuNWF0?=
=?utf-8?B?Qjhvbkc1dXJKeUtlelhqTnc1bzc3STFoVVZXQlIvamluL0htaHlNZHYvRnpr?=
=?utf-8?B?NENZM3NobXc5bXVEaHF6VGsyem03Wm9YLzZ1aFdwRUtxa2tHM3dJRjBFbitv?=
=?utf-8?B?a2k2M3phQU5rNS9QV2taUndXVGR6UXgyS2VaclZUSzhSdDlHcWJyWFhSM3JE?=
=?utf-8?B?NVI4ME5kUUZJeHlhWGhnbGRlcTFDMVg5eHFuZS93L09TK202NFlkdlVzczBJ?=
=?utf-8?B?VDk5M3FxaFBNYkZNU1VMQUdQSTMvdWxOR0YzcHRhSDNBNlpyUEVHUWd6alEx?=
=?utf-8?B?SE5qU0srSnduVE1wL2lySy9WWXdIRnU1aTlIOXZQZ2Q5amd3dUkxdkhwYWdm?=
=?utf-8?B?U0hNMCtLZDFwQmlrMUtIVmJCeGlGS20rTVFGaDl2RTdNbkhxOFNvUmhUVHBD?=
=?utf-8?Q?et2J7LKuaqDf92snIWW0XyvPlid9hciQIeDJEV6?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b6197ec4-295e-4efd-445f-08d9881377d4
X-MS-Exchange-CrossTenant-AuthSource: SA2PR11MB5210.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 15:19:04.6648 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6vjwUimChwAynXzyLw7I/N6/RWvveWu8EPgbYWIxMf419fRAJkj3GTt1nCoHYvo/7Z7VUiHH1903GhJWAD5+/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2623
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH v6 2/5] telemetry: fix deletion of active
sockets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On 05/10/2021 14:59, Bruce Richardson wrote:
> When DPDK is run with --in-memory mode, multiple processes can run
> simultaneously using the same runtime dir. This leads to each process,
> as it starts up, removing the telemetry socket of another process,
> giving unexpected behaviour.
>
> This patch changes that behaviour to first check if the existing socket
> is active. If not, it's an old socket to be cleaned up and can be
> removed. If it is active, telemetry initialization fails and an error
> message is printed out giving instructions on how to remove the error;
> either by using file-prefix to have a different runtime dir (and
> therefore socket path) or by disabling telemetry if it not needed.
>
> Fixes: 6dd571fd07c3 ("telemetry: introduce new functionality")
>
> Reported-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> ---
Tested-by: Conor Walsh <conor.walsh@intel.com>