From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCA6FA04B0; Tue, 22 Sep 2020 14:19:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C9F01DB74; Tue, 22 Sep 2020 14:19:15 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 5A6461DB71 for ; Tue, 22 Sep 2020 14:19:14 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.143]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id F250D20093; Tue, 22 Sep 2020 12:19:13 +0000 (UTC) Received: from us4-mdac16-31.at1.mdlocal (unknown [10.110.49.215]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id F09948009B; Tue, 22 Sep 2020 12:19:13 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.109]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 761E140072; Tue, 22 Sep 2020 12:19:13 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id E60B3B40071; Tue, 22 Sep 2020 12:19:12 +0000 (UTC) Received: from [192.168.38.17] (10.17.10.39) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 22 Sep 2020 13:19:04 +0100 To: "Min Hu (Connor)" , CC: , , , References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1600668838-31498-1-git-send-email-humin29@huawei.com> <1600668838-31498-2-git-send-email-humin29@huawei.com> <879dfbdb-d706-f4c9-2d5a-6c6eccbc4ab9@huawei.com> From: Andrew Rybchenko Autocrypt: addr=arybchenko@solarflare.com; keydata= mQINBF2681gBEACbdTxu8eLL3UX2oAelsnK9GkeaJeUYSOHPJQpV7RL/iaIskqTwBRnhjXt7 j9UEwGA+omnOmqQMpeQTb/F9Ma2dYE+Hw4/t/1KVjxr3ehFaASvwR4fWJfO4e2l/Rk4rG6Yi 5r6CWU2y8su2654Fr8KFc+cMGOAgKoZTZHZsRy5lHpMlemeF+VZkv8L5sYJWPnsypgqlCG3h v6lbtfZs+QqYbFH6bqoZwBAl5irmxywGR7ZJr1GLUZZ1lfdazSY8r6Vz0/Ip/KVxGu2uxo81 QCsAj0ZsQtwji9Sds/prTiPrIjx8Fc/tfbnAuVuPcnPbczwCJACzQr4q26XATL3kVuZhSBWh 4XfO/EAUuEq5AemUG5DDTM87g7Lp4eT9gMZB6P+rJwWPNWTiV3L7Cn+fO+l9mTPnOqdzBgDe OaulKiNSft1o0DY4bGzOmM2ad2cZt0jfnbMPMTE9zsr6+RFa+M8Ct20o6U1MUE4vP6veErMK of4kZ8PdoMM+Sq1hxMPNtlcVBSP9xMmdSZPlfDYI5VWosOceEcz7XZdjBJKdwKuz70V7eac4 ITSxgNFCTbeJ03zL2MR5s0IvD9ghISAwZ6ieCjU5UATn5+63qpD0nVNLsAdb/UpfvQcKAmvj 0fKlxu/PMVkjBa7/4cfNogYOhWDKUO+1pMaFwvb6/XTo6uMpfQARAQABtCxBbmRyZXcgUnli Y2hlbmtvIDxhcnliY2hlbmtvQHNvbGFyZmxhcmUuY29tPokCVAQTAQoAPhYhBP6NPgcKRj/Y X0yXQahue0sAy4m+BQJduvNYAhsDBQkB4TOABQsJCAcDBRUKCQgLBRYCAwEAAh4BAheAAAoJ EKhue0sAy4m+t3gP/j1MNc63CEozZo1IZ2UpVPAVWTYbLdPjIRdFqhlwvZYIgGIgIBk3ezKL K0/oc4ZeIwL6wQ5+V24ahuXvvcxLlKxfbJ6lo2iQGC7GLGhsDG9Y2k6sW13/sTJB/XuR2yov k5FtIgJ+aHa1PDZnepnGGOt9ka9n/Jzrc9WKYapOIIyLRe9U26ikoVgyqsD37PVeq5tLWHHA NGTUKupe9G6DFWidxx0KzyMoWDTbW2AWYcEmV2eQsgRT094AZwLFN5ErfefYzsGdO8TAUU9X YTiQN2MvP1pBxY/r0/5UfwV4UKBcR0S3ZvzyvrPoYER2Kxdf/qurx0Mn7StiCQ/JlNZb/GWQ TQ7huduuZHNQKWm7ufbqvKSfbPYvfl3akj7Wl8/zXhYdLqb5mmK45HXrgYGEqPN53OnK2Ngx IgYKEWr05KNv09097jLT5ONgYvszflqlLIzC4dV245g7ucuf9fYmsvmM1p/gFnOJBJL18YE5 P1fuGYNfLP+qp4WMiDqXlzaJfB4JcinyU49BXUj3Utd6f6sNBsO8YWcLbKBV9WmA324S3+wj f4NPRp3A5E+6OmTVMLWire2ZvnYp3YvifUj1r8lhoZ2B2vKuWwiTlHOKYBEjnOQJQnqYZEF0 JQQ1xzVDBQKE01BPlA3vy6BGWe6I4psBVqMOB9lAev/H+xa4u6Z3uQINBF269JsBEAC2KB3W 8JES/fh74avN7LOSdK4QA7gFIUQ4egVL81KnxquLzzilABuOhmZf3Rq6rMHSM8xmUAWa7Dkt YtzXStjEBI/uF0mAR3mMz1RcL2Wp+WD/15HjVpA7hPjXSEsWY0K2ymPerK4yrLcfFTHdMonY JfuACCC9NtOZxrWHOJoUS+RT7AWk80q/6D2iwQ47/2dBTznVG+gSeHSes9l91TB09w6f9JX/ sT+Ud0NQfm7HJ7t2pmGI9O6Po/NLZsDogmnIpJp/WwYOZN9JK7u2FyX2UyRzR8jK42aJkRsh DXs16Cc2/eYGakjrdO3x9a+RoxN7EuFtYhGR1PzMXdUiB5i+FyddYXkYUyO43QE/3VPA5l1v TUOagzZq6aONsdNonGJkV3TIG3JmUNtM+D/+r6QKzmgoJ8w576JxEZI09I/ZFN+g7BnUmlMx 6Z3IUOXVX/SWfGFga0YajwajHz03IBhChEbYbbqndVhmshu2GFURxrfUPYWdDXEqkh+08a5U Didia9jm2Opv4oE1e1TXAePyYJl/Zyps4Cv00GObAxibvMBQCUZQ+IBnNldRBOwXXRQV2xpx P+9iO1VYA/QXn0KqRK+SH1JGRXbJYi42YFaW1gE0EU0fiR2Wb9pK+doNEjjOhlzUGuvOEAUS +4m0m3dlfEvpCV9GMr7ERRpZzh9QkQARAQABiQI8BBgBCgAmFiEE/o0+BwpGP9hfTJdBqG57 SwDLib4FAl269JsCGwwFCQlmAYAACgkQqG57SwDLib7x6g//e+eCtNnJz7qFGbjWRJYNLCe5 gQwkhdyEGk4omr3VmjGj3z9kNFy/muh4pmHUngSAnnpwZggx14N4hhKf9y8G4Dwvsqa6b1zB Jq/c4t/SBDtGW4M/E331N04PaQZpcrbTfp1KqHNknk2N7yOk4CcoLVuIZmA5tPguASV8aAfz ZwhWAwn6vUEw9552eXEAnGFGDTCbyryNwzB5jtVQOEEDjTxcCkpcXMB45Tb1QUslRTu/sBAe HhPCQSUcJHR+KOq+P6yKICGAr291PZd6Qc7C3UyE+A3pY/UfdEVWj0STBWx1qvYLaHLrI4O9 KXDgh7luLjZZafcueCaPYmNo4V2lmNb3+7S4TvqhoZS+wN+9ldRQ4gH3wmRZybN6Y/ZCqxol RaZpE3AqdWsGvIgAkD0FpmtZNii9s2pnrhw0K6S4t4tYgXGTossxNSJUltfFQZdXM1xkZhtv dBZuUEectbZWuviGvQXahOMuH2pM64mx2hpdZzPcI2beeJNHkAsGT2KcaMETgvtHUBFRlLVB YxsUYz3UZmi2JSua4tbcGd6iWVN90eb8CxszYtivfpz6o2nPSjNwg0NaVGSHXjAK0tdByZ9t SkwjC3tEPljVycRSDpbauogOiAkvjENfaPd/H26V5hY822kaclaKDAW6ZG9UKiMijcAgb9u5 CJoOyqE8aGS5Ag0EXbr1RwEQAMXZHbafqmZiu6Kudp+Filgdkj2/XJva5Elv3fLfpXvhVt0Y if5Rzds3RpffoLQZk9nPwK8TbZFqNXPu7HSgg9AY7UdCM94WRFTkUCGKzbgiqGdXZ7Vyc8cy teGW+BcdfQycDvjfy50T3fO4kJNVp2LDNdknPaZVe8HJ80Od63+9ksB6Ni+EijMkh6Uk3ulB CSLnT4iFV57KgU2IsxOQVLnm+0bcsWMcCnGfphkY0yKP+aJ6MfmZkEeaDa7kf24N14ktg50m vOGDitcxA/+XXQXOsOIDJx1VeidxYsQ2FfsKu1G8+G6ejuaLf4rV5MI/+B/tfLbbOdikM5PF pxZVgTir9q13qHumMxdme7w5c7hybW412yWAe9TsrlXktFmFjRSFzAAxQhQSQxArS6db4oBk yeYJ59mW52i4occkimPWSm/raSgdSM+0P6zdWUlxxj+r1qiLgCYvruzLNtp5Nts5tR/HRQjE /ohQYaWDSVJEsc/4eGmgwzHzmvHtXeKkasn01381A1Lv3xwtpnfwERMAhxBZ8EGKEkc5gNdk vIPhknnGgPXqKmE1aWu8LcHiY+RHAF8gYPCDMuwyzBYnbiosKcicuIUp0Fj8XIaPao6F+WTi In4UOrqrYhsaCUvhVjsTBbNphGih9xbFJ8E+lkTLL8P3umtTcMPnpsB4xqcDABEBAAGJBHIE GAEKACYWIQT+jT4HCkY/2F9Ml0GobntLAMuJvgUCXbr1RwIbAgUJCWYBgAJACRCobntLAMuJ vsF0IAQZAQoAHRYhBNTYjdjWgdaEN5MrAN+9UR5r/4d3BQJduvVHAAoJEN+9UR5r/4d3EiQP /3lyby6v49HTU94Q2Fn2Xat6uifR7kWE5SO/1pUwYzx6v+z5K2jqPgqUYmuNoejcGl0CTNhg LbsxzUmAuf1OTAdE+ZYvOAjjKQhY4haxHc4enby/ltnHfWJYWJZ9UN5SsIQLvITvYu6rqthO CYjpXJhwkj3ODmC9H1TrvjrBGc6i7CTnR8RCjMEwCs2LI2frHa4R6imViEr9ScMfUnzdABMQ B0T5MOg8NX92/FRjTldU2KovG0ML9mSveSvVHAoEBLy4UIs5nEDdNiO1opJgKb5CXvWQugub 7AR52phNdKVdEB0S4tigJT4NalyTaPiUhFEm+CzZpMQDJ5E+/OowaPRfN4HeJX+c8sB+vUAZ mkAaG75N+IEk5JKFK9Z+bBYgPgaBDFZYdWDB/TMH0ANt+KI5uYg0i12TB4M8pwKG1DEPUmWc F2YpvB3jnbwzsOpSFiJOOlSs6nOB0Sb5GRtPOO3h6XGj+6mzQd6tcL63c9TrrUkjq7LDkxCz SJ2hTYRC8WNX8Uw9skWo5728JNrXdazEYCenUWmYiKLNKLslXCFodUCRDh/sUiyqRwS7PHEA LYC/UIWLMomI0Yvju3KA5v3RQVXhL+Gx2CzSj3GDz9xxGhJB2LfRfjzPbTR/Z27UpjCkd8z0 Ro3Ypmi1FLQwnRgoOKDbetTAIhugEShaLTITzJAP/iRDJCQsrZah5tE8oIl81qKEmBJEGcdt HYikbpQe7ydcXhqTj7+IECa3O7azI5OhCxUH2jNyonJ/phUslHH2G1TTBZK8y4Hrx5RpuRNS esn3P9uKu9DHqBAL7DMsCPwb2p1VNnapD72DBmRhzS/e6zS2R4+r9yNv03Hv7VCxKkmtE63H qpS//qpjfrtsIcHAjnKDaDtL1LYCtHoweI+DOpKKULSAYp/JE6F8LNibPQ0/P3S5ZIJNC4QZ uESjFOalJwFIqGQdkQB7ltRNJENLrHc+2jKGOuyFHm/Sbvp5EMGdaeQ0+u8CY0P+y6oXenwx 7WrJz/GvbNoFhJoJ6RzxCMQrFgxrssVZ7w5HcUj94lbnJ6osdYE/WpSd50B6jet6LKh5revg u9XI9CoqsPQ1V4wKYYdllPuogCye7KNYNKuiiuSNpaF4gHq1ZWGArwZtWHjgc2v3LegOpRQF SwOskMKmWsUyHIRMG1p8RpkBQTqY2rGSeUqPSvaqjT0nq+SUEM6qxEXD/2Wqri/X6bamuPDb S0PkBvFD2+0zr5Bc2YkMGPBYPNGZiTp3UjmZlLfn3TiBKIC92jherY563CULjSsiBEJCOSvv 4VPLn5aAcfbCXJnE3IGCp/hPl50iQqu7BPOYBbWXeb9ptDjGCAThNxSz0WAXkmcjAFE8gdE6 Znk9 Message-ID: <5c8ba025-3c55-637c-0a0c-e99644f33d83@solarflare.com> Date: Tue, 22 Sep 2020 15:18:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <879dfbdb-d706-f4c9-2d5a-6c6eccbc4ab9@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.17.10.39] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25674.003 X-TM-AS-Result: No-23.462800-8.000000-10 X-TMASE-MatchedRID: yebcs53SkkDmLzc6AOD8DfHkpkyUphL9G3FHx4IjDyP5+tteD5RzhVem QtpKzZIz2qLJOCm+Gy+7oI/ypOeHzpcvKjLILi9VLbjXqdzdtCXR+aCnUtmPaMZltfe/nRavUG1 wDP3HbhIRXYN4SMEDUMmaHgcHFdrlOJQuSr/cFG4SEYfcJF0pRYBOBQVQ0d5DcBqXYDUNCaxKj9 RzqMBfu6KSdNH7G+mZnZdrew+UsH3/XoXWj+sk7udnG4+P1pj7Xs5nqGvDCfNfUCHPns/+PnuKC /mB6YsPBSXkmB4RC2vjkXPpiQO8yR8tmNEYF19BT3nBCKOvAEuPSNdj1JMyARxUkJPe1WBqZxgE rgd3evZv1nQ6aUCMQCdgIaMu3pt+X1dHBkE+QZAdt2/pSR7zwGmQExgOfwV4OFiq9T5j3bXBK5p 1RmLr+kPeRmN1p1YN+Zy+KwuRH7fiW50d4aBi5Rwu4QM/6CpyyeUl7aCTy8iRoQLwUmtov8ASM1 FbRaAit5H1gcw1kjovnI30VoIMamxvuC9ELLKuC4s/hE51YdWIniKKY5qrocOtrkhuZC9Wu/rdP 055xvOMbCgqsDmH4cczgDS2JyD1cKE8cHrXBCPjSNzHLdpc2s6j/8n8QDVBYtJaVJe/wLHkNGDE AUnyXkFHF7XbDVpJ3eFzM68HaQ+wwAVMmrrBxylJ2c6NlEA9+wLfgJ/bqPPJCKRwXsPboTVCHPJ mvwzPJWSnrmUvmhjUH/ZwkMrCbXqsbYNMDmXPolVO7uyOCDV+TVCUVrlmhuJ4ZAtEhpMkvR78NB pidADRoeB/Zb0+FwWXF9R6iLAFXa5bkdrX5ZeeAiCmPx4NwFkMvWAuahr8+gD2vYtOFhgqtq5d3 cxkNQP90fJP9eHt X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--23.462800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25674.003 X-MDID: 1600777153-x_HEGiqWYcDb Subject: Re: [dpdk-dev] [PATCH V9 1/3] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/22/20 2:06 PM, Min Hu (Connor) wrote: > > > 在 2020/9/22 16:02, Andrew Rybchenko 写道: >> On 9/22/20 7:58 AM, Min Hu (Connor) wrote: >>> >>> >>> 在 2020/9/21 21:39, Andrew Rybchenko 写道: >>>> On 9/21/20 9:13 AM, Min Hu (Connor) wrote: >>>>> This patch adds Forward error correction(FEC) support for ethdev. >>>>> Introduce APIs which support query and config FEC information in >>>>> hardware. >>>>> >>>>> Signed-off-by: Min Hu (Connor) >>>>> Reviewed-by: Wei Hu (Xavier) >>>>> Reviewed-by: Chengwen Feng >>>>> Reviewed-by: Chengchang Tang >>>>> Reviewed-by: Ajit Khaparde >>>>> Acked-by: Konstantin Ananyev [snip] >>>>> @@ -3328,6 +3349,70 @@ int  rte_eth_led_on(uint16_t port_id); >>>>>    int  rte_eth_led_off(uint16_t port_id); >>>>>      /** >>>>> + * @warning >>>>> + * @b EXPERIMENTAL: this API may change, or be removed, without >>>>> prior notice >>>>> + * >>>>> + * Get Forward Error Correction(FEC) capability. >>>>> + * >>>>> + * @param port_id >>>>> + *   The port identifier of the Ethernet device. >>>>> + * @param fec_cap >>>>> + *   returns the FEC capability from the device, as follows: >>>>> + *   RTE_ETH_FEC_CAPA_NOFEC >>>>> + *   RTE_ETH_FEC_CAPA_AUTO >>>>> + *   RTE_ETH_FEC_CAPA_BASER >>>>> + *   RTE_ETH_FEC_CAPA_RS >>>>> + * @return >>>>> + *   - (0) if successful. >>>>> + *   - (-ENOTSUP) if underlying hardware OR driver doesn't support. >>>>> + *     that operation. >>>>> + *   - (-EIO) if device is removed. >>>>> + *   - (-ENODEV)  if *port_id* invalid. >>>>> + */ >>>>> +__rte_experimental >>>>> +int rte_eth_fec_get_capability(uint16_t port_id, uint32_t *fec_cap); >>>> >>>> The API does not allow to report capabilities per link speed: >>>> which FEC mode is supported at which link speed? >>>> >>>> What about something like: >>>> >>>> struct rte_eth_fec_capa { >>>>     uint32_t speed; /**< Link speed (see ETH_SPEED_NUM_*) */ >>>>     uint32_t capa;  /**< FEC capabilities bitmask (see >>>> RTE_FEC_CAPA_*) */ >>>> }; >>>> >>>> __rte_experimental >>>> int rte_eth_fec_get_capability(uint16_t port_id, uint32_t *num, struct >>>> rte_eth_fec_capa *speed_capa); >>>> >>>> where: >>>>    - num is in/out with a number of elements in an array >>>>    - speed_capa is out only with per-speed capabilities >>>> >>> There is no need to report capabilities per link speed, because >>> relastionship between the link speed and fec mode is fixed. The >>> infomations can be referred to in official documents or internet. >> >> Should an application download documents and search for it? :) > > OK， I will report capabilities per link speed in V11. > By the way, >>>> where: >>>>    - num is in/out with a number of elements in an array > > could you describe "num" more detailedly, how to use this value? On input, num should specify a number of elements in speed_capa array provided by the caller to get FEC capabilities. If the number is insufficient to, error should be returned and the number should contain required number of elements. If sufficient, on output driver should return a number of filled in array elements. >> >>> >>> A ethernet port may have various link speed in diffrent situations(for >>> example, optical module with different speed is used). But we do not >>> care about capabilities per link speed. We only care about FEC capa of >>> the ethernet device at a specific moment, because set FEC mode also >>> depend on the current FEC capa. >> >> Capabilities should not be for a specific moment. Capabilities >> should be fixed and stable (if transceiver is not replaced). >> Capabilities should not depend on a link speed or link status. >> Otherwise an application can't use it in a reliable way. >> >>> >>> By the way, we can also get link speed of the device by API >>> "rte_eth_link_get" in the same time. >>> >>> thanks. >>> >>>>> + >>>>> +/** >>>>> + * @warning >>>>> + * @b EXPERIMENTAL: this API may change, or be removed, without >>>>> prior notice >>>>> + * >>>>> + * Get current Forward Error Correction(FEC) mode. >>>>> + * >>>>> + * @param port_id >>>>> + *   The port identifier of the Ethernet device. >>>>> + * @param mode >>>>> + *   returns the FEC mode from the device. >>>>> + * @return >>>>> + *   - (0) if successful. >>>>> + *   - (-ENOTSUP) if underlying hardware OR driver doesn't support. >>>>> + *     that operation. >>>>> + *   - (-EIO) if device is removed. >>>>> + *   - (-ENODEV)  if *port_id* invalid. >>>>> + */ >>>>> +__rte_experimental >>>>> +int rte_eth_fec_get(uint16_t port_id, enum rte_eth_fec_mode *mode); >>>> >>>> Please, specify what should be reported if link is down. >>>> E.g. if set to RS, but link is down. >>>> >>>> Does AUTO make sense here? >>>> >>> OK, I will add the information in the function header comment: >>> when link down，None AUTO mode(RS, BASER. NOFEC) keep as it is when link >>> up, AUTO mode will change from rs，baser to nofec when quering the mode. >> >> I'll take a look at the patch, above text is hardly readable. > (1). If the current mode of device is one of these modes: > RS, BASER. NOFEC. > when link up, for example, the mode is RS. when the device is linked > down, the mode is always RS. > (2). If the current mode of device is AUTO: > when the device is linked down, the mode varies in this order: > rs->baser->nofec, until Auto-negotiation success (link shoud be > up first). > > But this is defined in our hardware. I think the first feature(1) are > common and can be adopted. Sorry, I don't understand. What abgot if link is down and AUTO is enabled, AUTO is returned, otherwise, configured FEC mode is returned. If link is up, current FEC mode is returned (i.e. not AUTO, either NOFEC, or RS, or BASER). >>>>> + >>>>> +/** >>>>> + * @warning >>>>> + * @b EXPERIMENTAL: this API may change, or be removed, without >>>>> prior notice >>>>> + * >>>>> + * Set Forward Error Correction(FEC) mode. >>>>> + * >>>>> + * @param port_id >>>>> + *   The port identifier of the Ethernet device. >>>>> + * @param mode >>>>> + *   the FEC mode. >>>>> + * @return >>>>> + *   - (0) if successful. >>>>> + *   - (-EINVAL) if the FEC mode is not valid. >>>>> + *   - (-ENOTSUP) if underlying hardware OR driver doesn't support. >>>>> + *   - (-EIO) if device is removed. >>>>> + *   - (-ENODEV)  if *port_id* invalid. >>>>> + */ >>>>> +__rte_experimental >>>>> +int rte_eth_fec_set(uint16_t port_id, enum rte_eth_fec_mode mode); >>>> >>>> It does not allow to tweak autoneg facilities. >>>> E.g. "I know that RS is buggy, so I want to exclude it from >>>> auto-negotiation". >>>> So, I suggest to change mode to capa bitmask. >>>> If AUTO is set, other bits may be set and specify allowed >>>> options. E.g. AUTO|RS|BASER will require FEC, i.e. NOFEC is >>> The two FEC modes cannot be configured for hardware at the same time, >>> including AUTO and other FEC modes. This is determined by Hardware >>> itself. >> >> Which HW? Yours? If so, it does not matter. The patch adds >> generic API. My comments are not abstract thoughts. There >> are requirements and capabilities behind. > > yes, it is in my HW. But I think the feature of FEC will exist in other > HW: the two FEC modes cannot be configured for hardware at the same time. > By the way, if set two FEC mode in our HW, the result will be unknown. > I also test X710 nic device, it does not support that feature. > I do not support that solutions. thanks. I'm not trying to say that two FEC modes could be running simultaneously. I'm trying to say that in the future a PHY could support more than one FEC mode and autonegotiation could make a choice which FEC mode to use. E.g. NOFEC, FOO and BAR modes supported set (AUTO|FOO|BAR) will require either FOO or BAR to be negotiated and does not allow NOFEC. >>> Thanks. >>> >>>> not allowed. If just RS, it means that auto-negotiation is >>>> disabled and RS must be used. >>>> If AUTO is unset, only one bit may be set in capabilities. >>>> Since we don't do it per speed, I think it is safe to ignore >>>> unsupported mode bits. I.e. do not return error if unsupported >>>> capa is requested to together with AUTO, however it could be > Why? if the mode is unsupported (not in capa),why we can configure > the the mode to the device? Because this is unreaonable. Also, > the configure will not be ineffective, and the hardware will return > error back to the driver. I agree that requested mode should be in capabilities for at least some speed, but not required to be applicable to currently negotiated and running speed. May be it is obvious. I.e. if I set AUTO|NOFEC|RS when capabilities are 25G(NOFEC,AUTO,BASER) and 100G(NOFEC,AUTO,RS), it will enforce NOFEC for 25G (since BASER is disabled) and allow either NOFEC or RS for 100G. >>>> a problem if no modes are allowed for negotiated link speed. >>>> Thoughts are welcome. >>>> >>>>> + >>>>> +/** >>>>>     * Get current status of the Ethernet link flow control for >>>>> Ethernet device >>>>>     * >>>>>     * @param port_id >>>> >>>> [snip] >>>> >>>> . >>>> >> >> . >>