From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62B4A43CA0; Wed, 13 Mar 2024 16:59:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAA1042E61; Wed, 13 Mar 2024 16:59:09 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41]) by mails.dpdk.org (Postfix) with ESMTP id DAA3742E47 for ; Wed, 13 Mar 2024 16:59:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bOIkaauMdto+NXC1BH0WDbRuMTRAuVbTK+b+I8ZnYImQ81EGQCHiNuY8Iu6+p33+Vo3s43w0CRhjSHbkY0tMODLju7gOHN41sUDgaoBbmLlNDSCk+MSW2ebcPMjKcICxwpFumIW2wMzp2fxxXNZhQvcktYVE14ZxpGcOpxHf++mnXeazMCrQYN50tNBQVPCTpUTrc3ph1s+cO6CMziBpJVrv3ESJtCz1g+Gv8iIVnbDHM2v+9ebIIs9OLTcN06u5V2wT8279bj/3uP8fKw83/oTFqs2v+5sELPyL+yq2pEo12h6pAAYYTvyVCTpNhrYsePX1OZ0BbgfSz9tkV5yStg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Uf/bJwyncORWu48rrfLQlnwGet6efW2iYfi5gLafspw=; b=cTo3X6VAMw0jAvvrGswy5b3CD5fH/eW5WK7umxcrkL0QnZqSzKZ4AeVTqpUZVsoMQtF3s2M7UyzRXA22W5yK1MRrSLJZY1R/H/ES7iUJYUIY0QdZ6/aECeU/BrVhUlUQkD+kF2N0xc1Uba4HJnQJzErbCsJZUL8tadnWVFzqsbg/TzpIuC7rvFRSBHCjU4NbxLhOkM0kDWR0mLS3t0ZRwnwkZFK0C4cGUQWY8NFNTyWg7YgKETU0T1AJ7PtyIxeD3mwANlbC2nz232wChS8IdD+E9+A0+LzQFD4EGC07DuhL4YqgOCOFNq9mCYLvebKT720aNu3kgfTDdFD1rKcpEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Uf/bJwyncORWu48rrfLQlnwGet6efW2iYfi5gLafspw=; b=Vg9JdZ39ioMLVA1/RwHLDxhpEzEQYre5+NbkiVw+xZ2T/mUH/kE9xHdMjHnSIg9v8cEzmV3YFQZKioh+fwm5IxP8eVZu0ky8FSZLLqvBXcqiYevo+hpvqpw/BaAtIcwlkrZG+iYOVYEU/6NZ7pUhBZ9QlHyjorRYjAMmb7oXw40= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ2PR12MB8135.namprd12.prod.outlook.com (2603:10b6:a03:4f3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Wed, 13 Mar 2024 15:59:07 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::3ec7:6339:1c14:c529%5]) with mapi id 15.20.7362.035; Wed, 13 Mar 2024 15:59:07 +0000 Message-ID: <5cb30f0b-d487-47d3-acab-75ba1a5a931a@amd.com> Date: Wed, 13 Mar 2024 15:59:06 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 03/31] net/ena: update imissed stat with Rx overruns Content-Language: en-US To: shaibran@amazon.com Cc: dev@dpdk.org References: <20240312180716.8515-1-shaibran@amazon.com> <20240312180716.8515-4-shaibran@amazon.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <20240312180716.8515-4-shaibran@amazon.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ2PR12MB8135:EE_ X-MS-Office365-Filtering-Correlation-Id: f5f22874-ae20-42fa-277d-08dc43768367 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: JvmooB6J1LAwcf26iMqzZL1LTd1NJ6m+ouMsshxCP7qAj75RRi1t2wODlrsYdvtqOSznrK0T1gOt2ubzx6r7miR/M304yj2q3xJ9EsRCvLd7AWnj3Z89cORJid7L9+ReVkzlt3ORyuCnSf9R3ynfYO/nTFfkfYDVJp4n+kjSuKlbl1cfnhcU21OQwjOgSzrxQdoYmw/uVyEufDIPRJux31eIuNeCsl9CLhVfxBJMluyeYLnNtovdgcKLGH730NasGyY6YQkInKMbf6yE+6X1N5HmCEImneKhD3QMUBd83yUogYTqLf2dTA781DtPwe30eNew9RnZ10tLliV9Nu22YJh8nESdAdOHq7b4nH+3bqURus4qoVycxITBf1QU3CZN48QwhV6/RPt3qsK4OOKSVOgm1h7ET6yaiRRJjEB4jWMhtS23wMwSR2BmSp01CK8/EtTt6rY09VpjSwuyJc6O0pESWf3rjZNe7ZslEXz7roBsvbpIiS7ISbaGKoY6twJrvRv/w3bFkSi41NF1WsrMsI6OaFWJ+n0Wcl+x0NoHp9Dmtc5QMAhlKbBnAF62fnZwYbSXi9rPQTtRjMr7A0VVVFQa/lpIJZbiXtLWeFfhWObt58g8/bqmF8natdNntZTZgJvzyJrTcEdGztlLXeNkxNA+V3ECF2DLkMI6WMjURSE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(376005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MklWa2c1ejVVVTUvUjUyOTE2ZTV1b2p2WExuaXRBTmU0NGZ6c3lqcERLS0NV?= =?utf-8?B?Q1lwVnE4MEs5S2JKUHFoWmJpUmlFOFYzNzY4STZLcU1JMkhrVkxrSGhVNkVJ?= =?utf-8?B?RlZvMVJtcFZ4cnpjUWRZeHhNUXVyOS9IMVJyK2FhaGRlTHZOMHRrR1ZIaTl0?= =?utf-8?B?K1AzcEhESnZ2Yk1BeGpDQmVvRUs3K01Dd3haUmhSVDRuTUZUeDJFWUsxWmVj?= =?utf-8?B?KzMvZzdtbnJvZDJkclhkRlJjdE12TzFLK0oyb1RvaHZ6NFdNVHZpWkx0dEVQ?= =?utf-8?B?S0N3YVV4TzJaSVlUYnJPTU1FZFVha3pEN3VGQ0lEKzhWd3B5b0gwK1dMZm85?= =?utf-8?B?WjdCMU51NE81aVZpSEpuVVUrakxtSmdMWndLejloZE52aVcrYU16TUZLdm9Y?= =?utf-8?B?ZXlGbTZPbGMxZUszajA2c1RYRVgrSUc0TDBjQ1hkM3l3S2NYaHd0MTRqQW9x?= =?utf-8?B?bm1sZ3NQd0NaVDZ2cTJ3YmdZQmNGU2d0dmZxU2FHR29TZ2FtejZFK2s1cTJn?= =?utf-8?B?YVVMR1V1SlFSNGc3d2JmU2l3ZG1zVGhGanV3TEtMa0ZHZmRaQjk0Q3ZrTHg3?= =?utf-8?B?dCtVb3lSOVl4alFoZGtyc3QzT0VUVXhEZ01KaXplSDdNWlJmZ0hqa20xV0Nx?= =?utf-8?B?ZTFFZmlpN3BMYytkcjMzbDcxampTZEgrRjNaRHJxNjVHVDErSlAzYWtTR1Rw?= =?utf-8?B?QkMzZkdDU3BDY2w4ZkxkV29tTHMyNVhWWlZLVXh5VkRMRzhlaGZkS20yUlVE?= =?utf-8?B?T05FWXVnTHlEOFlYd0hsMlBJK0FhNGJyZFhqY2VPd3NCSE42VzZFdmIxMks1?= =?utf-8?B?eU1XcWVlcy8xSUx0Ym9odHJVZzZ6N2x2eERwSHdVZ0RuVnhmdmg4ekhPbTF5?= =?utf-8?B?dUcvSTFLV0NGRE1RVWh1aTRTMThpL1QzbWdTYmtaR0ZCL3lWdkcrZUlWSmpH?= =?utf-8?B?bm01QURlTms4ZVc3YlQ3aDNnUVZRc1M0ODNRSmdnOXYrNTY2NXVzT0lHd29V?= =?utf-8?B?T1I5bndYazNwbXd0emVXbTlvZkQ4MS9TNHBrajBvdytyZXNEenZqamhLaGJ3?= =?utf-8?B?YnZCMmRCb1RDaXY3YXMrWXUxZ201ajQ0MGdtOXJKdUh3akN0SnJlZ0huL0FH?= =?utf-8?B?eFlSUTdLaGpNWFBkb21rMFQwOFRnS2xNYXI2Z2lRc0ZPelg2T1BqUmVlUnFE?= =?utf-8?B?dDl2UnpsVGlEa1FXQVRTd00zQVJ1cnJEV2hoQk5EaUVXVU5NaHJiR3ZXdEw5?= =?utf-8?B?cXY3MmxHREcvWXZVcjFHNmhpa2tRZjc5QncwMGlqZDZXRjd5MWxRYTVEMmNO?= =?utf-8?B?Y2FhTjhjSjM1eTA4Qm10TU9jdDl5S3NpZGt4a3k5S3NLWG4xbmdTck1DMi9D?= =?utf-8?B?R1JkdVI2TjAzQnJaK1lxR3pIdXgyVHNqaTBiMWRtNngvekQyb0xLaytJSVFH?= =?utf-8?B?VVVXcTl3UlAzcExCN2J0WWZ0Ty9lOWtQSmhPSDB2OWhTRDlkZy9JK0V4ZEFx?= =?utf-8?B?Q3JtQk9ZWGNJaFNXZGpYZGQ5NHpHaTBnUHFEdTc5eHRxMW1DNEdMbnA2UUJj?= =?utf-8?B?TGQxWC95bXJlNk5SRCtWM0FudzBGWm1mSHVuUmFkQW8reFF3YUFOSTQzMjVn?= =?utf-8?B?bkU3TnBhQjVvTld1bHFEMTFsVUV5SjUrWklBblB4ellrd3p3Rk1SaWVkTjJY?= =?utf-8?B?WFh5TmdUOTZpR2dQVi9UenV1N2xOQk9kRFdqTDhtM050c1kzTmpja1ZlZDZM?= =?utf-8?B?aGZFa3pqaGNsdU1VeHFDYWdld1dmMnp3STYxU3pKUTFBQ3Q4OGxvSEQwNVVM?= =?utf-8?B?eWt2dGFoRlFLRG9TUVZSTXJTNUxENjVZQk9jN09vbTMxVGJTS3VMZGpLMis1?= =?utf-8?B?VnFkYjNKQjZGVnBNZ1dJUmpnY2ppQlIrVEY5WmJCVXFRVWxkMXhsYkF5Y0dO?= =?utf-8?B?YUFOSmVuQ3E5UFpEaW9PT1c4YTdHcWxiSjduR3AvNFhxK1JCa2VMUGo2VTBq?= =?utf-8?B?OHQ3b3gzWThib1FVSFpSSlBISHFXT09kV2Y1dTdzQTVxZjI0S0JlVmRpUlVX?= =?utf-8?B?QzNPb01WK0RWaXc5Y1V3dCtzRXlobGZ6clNnWWNTVkR0Ulppa0N5ZEwwamUx?= =?utf-8?Q?PnP8PUKWtW63DEIQeo9HDmRiZ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f5f22874-ae20-42fa-277d-08dc43768367 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Mar 2024 15:59:07.1751 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CAqr1A2oaaxhiixcM+Qk/hXBdfjvKTMlQbzY1PgiIeqWP6lpzprXETsajvgKiEFd X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8135 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/12/2024 6:06 PM, shaibran@amazon.com wrote: > From: Shai Brandes > > Depending on its acceleration support, the device updates > a different statistic when an ingress packet is dropped > because no buffers are available to hold it. > - In AWS instance types from later generations > 'rx_overruns' is updated. > - Otherwise, in legacy instance types, > 'rx_dropped_cnt' is updated. > > That is, there is no need to report rx_overruns separately > as an xstat and the driver can simply sum up the two > self-contained counters as the 'imissed' statistic. > > Signed-off-by: Shai Brandes > Reviewed-by: Amit Bernstein > Formatted release notes update while merging.