From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 83CAF2BF4 for ; Tue, 2 Oct 2018 10:25:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Oct 2018 01:25:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,331,1534834800"; d="scan'208";a="267686548" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.49]) ([10.237.221.49]) by fmsmga005.fm.intel.com with ESMTP; 02 Oct 2018 01:25:52 -0700 To: Ajit Khaparde , dev@dpdk.org References: <95301884-14c8-bbfd-ade9-ded04bdb6a95@intel.com> <20180929020006.71505-1-ajit.khaparde@broadcom.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <5cbb67b1-320d-f4ba-898d-7b7bf7921984@intel.com> Date: Tue, 2 Oct 2018 09:25:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180929020006.71505-1-ajit.khaparde@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 00/15] bnxt patchset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 08:25:54 -0000 On 9/29/2018 2:59 AM, Ajit Khaparde wrote: > Patchset against dpdk-next-net. > > v1->v2: > net/bnxt: get rid of ff pools array and use the vnic info array instead > - Fix access to uninitialized variable. > - Rectify the wrong 'Fixes' reference. > > net/bnxt: update HWRM version > - Update from 1.9.2.45 to version 1.9.2.53 > > v2->v3: > net/bnxt: update HWRM version > - Tried to split into more than one patch. > > - Updated commit logs and messages for rest based on review comments. > > Please apply. > > Ajit Khaparde (10): > net/bnxt: fix MTU setting > net/bnxt: update HWRM version > net/bnxt: update HWRM version part 2 > net/bnxt: update HWRM version part 3 Is there a logical to separation of part 1,2 & 3? Commit logs are empty and there is nothing distinctive from commits. If the separation is not logical but just physically split into 3 pieces I am for merging them back with the "Update the HWRM API to version 1.9.2.53" commit log. Or if there is a logic please clarify it on patch subject and commit log. I will wait your answer before moving on. Thanks, ferruh