From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3D6AFA0A03; Tue, 19 Jan 2021 04:47:30 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D01B6140E12; Tue, 19 Jan 2021 04:47:29 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id DF033140DE7 for ; Tue, 19 Jan 2021 04:47:27 +0100 (CET) IronPort-SDR: wVbbj96xWfAwhuSGGczy/7ZvmyDQqV8TRaB0bg2lJTOaZT0LIEQuvAuw5fgVG/3Wb+7lOm3mLo 9/g7dmSKZ6Sw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="263681673" X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="263681673" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2021 19:47:25 -0800 IronPort-SDR: jg/LLro2Zo/RKnfwbtUDhmDbvk2+3J8l3mO+qF+W93kztfQzE76cZKcnikl6MDtdVvQKkb4Pb3 MC9D46QEk8Jw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,357,1602572400"; d="scan'208";a="390967981" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 18 Jan 2021 19:47:24 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 18 Jan 2021 19:47:23 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 19 Jan 2021 11:47:21 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Tue, 19 Jan 2021 11:47:21 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Zhang, AlvinX" , "Guo, Jia" , "Xie, WeiX" CC: "dev@dpdk.org" , "Zhang, AlvinX" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable Thread-Index: AQHW6xlu2GUulKhrqUi+ahlZNfcXc6osixIAgAHKPnA= Date: Tue, 19 Jan 2021 03:47:21 +0000 Message-ID: <5ccc58f0384444d1b027bb89dd751931@intel.com> References: <20210114065248.17160-1-alvinx.zhang@intel.com> <20210115083411.9324-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Xing, Beilei > Sent: Monday, January 18, 2021 4:27 PM > To: Zhang, AlvinX ; Guo, Jia ;= Xie, > WeiX > Cc: dev@dpdk.org; Zhang, AlvinX > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable >=20 >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Zhang,Alvin > > Sent: Friday, January 15, 2021 4:34 PM > > To: Guo, Jia ; Xie, WeiX > > Cc: dev@dpdk.org; Zhang, AlvinX > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix out-of-scope variable > > > > From: Alvin Zhang > > > > Using "key", which points to an out-of-scope variable "rss_key_default"= . > > > > Coverity issue: 365293 > > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") > > > > Signed-off-by: Alvin Zhang > > --- > > > > V2: Update the commit log. > > --- > > drivers/net/i40e/i40e_hash.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_hash.c > > b/drivers/net/i40e/i40e_hash.c index > > e07f806..83a9af5 100644 > > --- a/drivers/net/i40e/i40e_hash.c > > +++ b/drivers/net/i40e/i40e_hash.c > > @@ -901,10 +901,12 @@ struct i40e_hash_match_pattern { > > PMD_DRV_LOG(WARNING, > > "RSS key length invalid, must be %u bytes, now set key > to > > default", > > (uint32_t)sizeof(rss_conf->key)); > > - key =3D (const uint8_t *)rss_key_default; > > + > > + memcpy(rss_conf->key, rss_key_default, sizeof(rss_conf->key)); > > + } else { > > + memcpy(rss_conf->key, key, sizeof(rss_conf->key)); > > } > > > > - memcpy(rss_conf->key, key, sizeof(rss_conf->key)); > > rss_conf->conf.key =3D rss_conf->key; > > rss_conf->conf.key_len =3D sizeof(rss_conf->key); } > > -- > > 1.8.3.1 >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi