From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
bluca@debian.org
Subject: Re: [dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation
Date: Thu, 1 Apr 2021 15:40:13 +0300 [thread overview]
Message-ID: <5cf02981-634a-bb08-8219-8aa67bec6e44@oktetlabs.ru> (raw)
In-Reply-To: <20210401123339.GB1627@bricha3-MOBL.ger.corp.intel.com>
On 4/1/21 3:33 PM, Bruce Richardson wrote:
> On Thu, Apr 01, 2021 at 03:14:40PM +0300, Andrew Rybchenko wrote:
>> On 4/1/21 2:50 PM, Bruce Richardson wrote:
>>> Ensure all lists of drivers are one-per-line and replace tabs with spaces
>>> in each file to correspond to the new standard.
>>>
>>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>>> ---
>>> drivers/baseband/meson.build | 8 ++-
>>> drivers/bus/meson.build | 7 ++-
>>> drivers/common/meson.build | 9 +++-
>>> drivers/compress/meson.build | 7 ++-
>>> drivers/crypto/meson.build | 38 ++++++-------
>>> drivers/event/meson.build | 17 ++++--
>>> drivers/mempool/meson.build | 8 ++-
>>> drivers/meson.build | 33 ++++++------
>>> drivers/net/meson.build | 102 +++++++++++++++++------------------
>>> drivers/raw/meson.build | 15 +++---
>>> drivers/regex/meson.build | 3 +-
>>> drivers/vdpa/meson.build | 4 +-
>>> 12 files changed, 142 insertions(+), 109 deletions(-)
>>>
>>> diff --git a/drivers/baseband/meson.build b/drivers/baseband/meson.build
>>> index 920e3b02ee..22d0036cd7 100644
>>> --- a/drivers/baseband/meson.build
>>> +++ b/drivers/baseband/meson.build
>>> @@ -2,7 +2,11 @@
>>> # Copyright(c) 2018 Luca Boccassi <bluca@debian.org>
>>>
>>> if is_windows
>>> - subdir_done()
>>> + subdir_done()
>>> endif
>>>
>>> -drivers = ['null', 'turbo_sw', 'fpga_lte_fec', 'fpga_5gnr_fec', 'acc100']
>>> +drivers = ['null',
>>> + 'turbo_sw',
>>> + 'fpga_lte_fec',
>>> + 'fpga_5gnr_fec',
>>> + 'acc100']
>> It looks like it is more than 4 spaces here (and many similar
>> cases below), but previous patch and longs lists below in the
>> file use 4 spaces alignment.
> Yes, for indenting line continuations, I've tended to prefer to use a
> double-indent, and save single indent for new blocks of code.
I see. May be it is better to put the first 'null' and the last 'acc100' on
its own line with trailing comma?
Also shouldn't the list be alpha-numerically sorted?
next prev parent reply other threads:[~2021-04-01 12:43 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 11:49 [dpdk-dev] [RFC PATCH 00/14] Build file update proposals Bruce Richardson
2021-04-01 11:49 ` [dpdk-dev] [RFC PATCH 01/14] editorconfig: add entry for meson files Bruce Richardson
2021-04-01 11:49 ` [dpdk-dev] [RFC PATCH 02/14] build: simplify library build file Bruce Richardson
2021-04-01 11:49 ` [dpdk-dev] [RFC PATCH 03/14] build: correct indentation in list of libs Bruce Richardson
2021-04-01 13:30 ` Thomas Monjalon
2021-04-01 14:01 ` Bruce Richardson
2021-04-01 11:49 ` [dpdk-dev] [RFC PATCH 04/14] build: simplify the driver build configuration file Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 05/14] build: clean up driver list indentation Bruce Richardson
2021-04-01 12:14 ` Andrew Rybchenko
2021-04-01 12:33 ` Bruce Richardson
2021-04-01 12:40 ` Andrew Rybchenko [this message]
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 06/14] build: reduce indentation in app build spec Bruce Richardson
2021-04-01 13:32 ` Thomas Monjalon
2021-04-01 14:05 ` Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 07/14] build: reduce indentation in examples " Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 08/14] build: change infrastructure file tabs to spaces Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 09/14] lib: change meson " Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 10/14] drivers: " Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 11/14] examples: " Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 12/14] app: " Bruce Richardson
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 13/14] lib: remove librte_ prefix from directory names Bruce Richardson
2021-04-01 13:42 ` Thomas Monjalon
2021-04-01 11:50 ` [dpdk-dev] [RFC PATCH 14/14] lib: allow disabling optional libraries Bruce Richardson
2021-04-01 12:27 ` [dpdk-dev] [RFC PATCH 00/14] Build file update proposals Andrew Rybchenko
2021-04-01 13:15 ` Luca Boccassi
2021-04-01 13:36 ` Thomas Monjalon
2021-04-01 14:10 ` Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 00/14] Build file updates Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 01/14] build: simplify library build file Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 02/14] build: tidy up list of libraries to build Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 03/14] build: simplify the driver build configuration file Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 04/14] build: clean up driver lists Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 05/14] build: reduce indentation in app build spec Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 06/14] build: reduce indentation in examples " Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 07/14] build: change infrastructure file tabs to spaces Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 08/14] lib: cleanup whitespace in meson build files Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 09/14] drivers: change meson file tabs to spaces Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 10/14] examples: " Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 11/14] app: " Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 12/14] editorconfig: add entry for meson files Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 13/14] lib: remove librte_ prefix from directory names Bruce Richardson
2021-04-16 17:04 ` [dpdk-dev] [PATCH 14/14] lib: allow disabling optional libraries Bruce Richardson
2021-04-18 8:45 ` [dpdk-dev] [PATCH 00/14] Build file updates Xueming(Steven) Li
2021-04-19 13:06 ` Bruce Richardson
2021-04-21 13:01 ` Xueming(Steven) Li
2021-04-21 15:52 ` Xueming(Steven) Li
2021-04-19 0:20 ` Thomas Monjalon
2021-04-19 13:09 ` Bruce Richardson
2021-04-19 13:47 ` Thomas Monjalon
2021-04-19 14:23 ` Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 00/16] " Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 01/16] build: simplify library build file Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 02/16] build: tidy up list of libraries to build Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 03/16] build: simplify the driver build configuration file Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 04/16] build: clean up driver lists Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 05/16] build: reduce indentation in app build spec Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 06/16] build: reduce indentation in examples " Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 07/16] build: change infrastructure file tabs to spaces Bruce Richardson
2021-04-27 19:16 ` David Christensen
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 08/16] lib: cleanup whitespace in meson build files Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 09/16] drivers: change meson file tabs to spaces Bruce Richardson
2021-04-21 1:48 ` Xu, Rosen
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 10/16] examples: " Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 11/16] app: " Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 12/16] editorconfig: add entry for meson files Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 13/16] doc: add meson coding style section to contributors guide Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 14/16] lib: remove librte_ prefix from directory names Bruce Richardson
2021-04-28 20:18 ` David Christensen
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 15/16] devtools: add script to ease backport of renamed files Bruce Richardson
2021-04-20 10:22 ` [dpdk-dev] [PATCH v2 16/16] lib: allow disabling optional libraries Bruce Richardson
2021-04-21 12:08 ` [dpdk-dev] [PATCH v2 00/16] Build file updates Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf02981-634a-bb08-8219-8aa67bec6e44@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).